[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=360059

Roman Gilg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/1d362c4ae2e26
   ||4a80c002ab6718c1b1d9437c20c
 Status|CONFIRMED   |RESOLVED

--- Comment #11 from Roman Gilg  ---
Git commit 1d362c4ae2e264a80c002ab6718c1b1d9437c20c by Roman Gilg.
Committed on 03/01/2017 at 14:37.
Pushed by romangilg into branch 'master'.

[Digital Clock] Bug fixes and ui code optimization

Summary:
- Fixed timezone size and alignment in vertical mode
- Instead of `Flow` use `Grid` for labels as it's simpler and gives better
  control over alignment
- Seperator in small horizontal mode centered between date and time and in
  height now dependent on label size
- Less empty space around time in small horizontal mode
- Binding loop and initlializting anchor errors fixed
- Elements now size completely down and have always the same ratio to each
other
  with the time label being the largest
- Round functions removed since they disrupted the resizing for small sizes
- Introduce max font size values for text elements in panel mode
Related: bug 367585, bug 373396

Reviewers: #plasma, mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3630

M  +206  -148  applets/digital-clock/package/contents/ui/DigitalClock.qml

https://commits.kde.org/plasma-workspace/1d362c4ae2e264a80c002ab6718c1b1d9437c20c

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=360059

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #10 from Roman Gilg  ---
Take a look at my proposed ui cleanup: https://phabricator.kde.org/D3630

The screenshots there are slightly outdated, but if you are able to compile
Plasma Workspace on your machine, you can try out the diff yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[x]

https://bugs.kde.org/show_bug.cgi?id=360059

x  changed:

   What|Removed |Added

 CC||ro...@yopmail.fr

--- Comment #9 from x  ---
What comment 8 says and illustrates with a screenshot: the date font size is
too big (and so is the time's, btw).

Would it somehow be possible to have an option to select not just the font
face, but also the font size for the time, and separately, for the date?

Reason why you want them to be different: most frequently the user looks at the
time, and if that is the shorter string, then it would make sense to allow it
to take more space by increasing its font size relative to the date, which is
only glanced at occasionally.

On the other hand, some users may prefer to have a long time (with seconds) and
only a short date, or no date at all. In this case, they may also prefer a
smaller font size in order to save screen space (or bigger font size, if they
have eyesight trouble).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Wulf via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

Wulf  changed:

   What|Removed |Added

 CC||wulf.richa...@gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Nikos Platis via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

Nikos Platis  changed:

   What|Removed |Added

 CC||npla...@gmail.com

--- Comment #8 from Nikos Platis  ---
Created attachment 101464
  --> https://bugs.kde.org/attachment.cgi?id=101464=edit
Screenshot showing the large date size

In addition, in Plasma 5.8, the date seems to have a minimum font size that is
too big (in previous versions the minimum font size for the date was indeed too
small, and it could become unreadable). So, especially if you want to see the
full date, you end up using too much space on the taskbar. Also, as it is
apparent on the screenshot, the bottom few pixels of the date are cut off at
this taskbar size.

The screenshot also makes evident why one should be able to customize the date
format on the clock (eg. I want to see the day of the week but I would prefer a
shorter version), but that's probably on bug 278200...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Mark Fairbairn via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

--- Comment #7 from Mark Fairbairn  ---
Created attachment 101272
  --> https://bugs.kde.org/attachment.cgi?id=101272=edit
too large font

increasing tray width by just one pixel results in a large jump in font size to
one that is now too big - but solves the wasted space to the left of the clock
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Mark Fairbairn via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

--- Comment #6 from Mark Fairbairn  ---
Created attachment 101267
  --> https://bugs.kde.org/attachment.cgi?id=101267=edit
space to left clock

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Mark Fairbairn via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

--- Comment #5 from Mark Fairbairn  ---
Created attachment 101266
  --> https://bugs.kde.org/attachment.cgi?id=101266=edit
small font clock

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Mark Fairbairn via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

Mark Fairbairn  changed:

   What|Removed |Added

 CC||farcu...@gmail.com

--- Comment #4 from Mark Fairbairn  ---
with the release of 5.7.95 (5.8 beta) this issue seems to have gone in the
opposite direction with the digital clock plasmoid font now too small (and with
too much space to the left of the clock.
Font size can be increased in systemsettings but results in too large fonts
elsewhere in plasma

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

David Edmundson  changed:

   What|Removed |Added

 CC||energumenos...@gmail.com

--- Comment #3 from David Edmundson  ---
*** Bug 366140 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Daniel Faust via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

Daniel Faust  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||hessija...@mailbox.org

--- Comment #2 from Daniel Faust  ---
There is a patch at https://git.reviewboard.kde.org/r/127393/, which unifies
the font used for the date and the time when the clock is shown in a narrow
panel. But it will in most cases increase the font size of the date label.

If having an option to scale the font size is important to you, you might want
to create a feature request just for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360059] Inconsistent and too large font used for time in digital clock plasmoid

[Peter Lewis via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360059

Peter Lewis  changed:

   What|Removed |Added

 CC||p...@muddygoat.org

--- Comment #1 from Peter Lewis  ---
Created attachment 97671
  --> https://bugs.kde.org/attachment.cgi?id=97671=edit
Screenshot illustrating the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.