[plasmashell] [Bug 360219] Right Click opens files

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=360219

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||alexlon...@gmail.com

--- Comment #40 from Kai Uwe Broulik  ---
*** Bug 375853 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=360219

Kai Uwe Broulik  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/d2fde361d3c8fb4
   ||0fb6c1e53e4178042799b6691
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.8.6
 Resolution|--- |FIXED

--- Comment #39 from Kai Uwe Broulik  ---
Git commit d2fde361d3c8fb40fb6c1e53e4178042799b6691 by Kai Uwe Broulik.
Committed on 09/01/2017 at 07:28.
Pushed by broulik into branch 'Plasma/5.8'.

[Folder View] Fix right click erroneously opening files

It turns out mouse.buttons is 0 for "clicked" events whereas mouse.button is
properly set.
It should bail out when released with right mouse button as that opens the
context menu
but this condition is never met.

According to documentation this looks intentional, at least it says "For mouse
move
events […]. For mouse press and double click events […]. For mouse release
events […]."
I can see no mention of regular "clicked", no idea why that is, though.
FIXED-IN: 5.8.6

M  +1-1containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/d2fde361d3c8fb40fb6c1e53e4178042799b6691

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #38 from Eike Hein  ---
Patch seems fine, please commit Kai.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #37 from Wolfgang Bauer  ---
(In reply to Kai Uwe Broulik from comment #36)
> Created attachment 103044 [details]
> Possible patch
> 
> Can you please test the following patch?

I tried it, and the patch does indeed fix the problem here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=360219

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #36 from Kai Uwe Broulik  ---
Created attachment 103044
  --> https://bugs.kde.org/attachment.cgi?id=103044=edit
Possible patch

Can you please test the following patch?

I can sometimes trigger the bug and turns out that mouse.buttons is 0 for
clicked events whereas mouse.button is properly set. It should bail out when
released with right mouse button as that opens the context menu but the
condition is never met.

According to documentation this looks intentional, at least it says "For mouse
move events […]. For mouse press and double click events […]. For mouse release
events […]." I can see no mention of regular "clicked", no idea why that is,
though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Aurélien Murith]

https://bugs.kde.org/show_bug.cgi?id=360219

Aurélien Murith  changed:

   What|Removed |Added

 CC||aurelienmur...@netc.fr

--- Comment #35 from Aurélien Murith  ---
Problem still present on Plasma 5.8.2 (Qt 5.7).

Right-clicking on files that are on the desktop (folder view) often (not
always) opens them, in addition of opening the context menu.

It's a really annoying bug...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Francesco via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Francesco  changed:

   What|Removed |Added

 CC||muzi...@email.it

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Michael D via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #34 from Michael D  ---
The bug is present in plasm a 5.8.1 (Neon Dev stable). I have a folder view
widget in my panel. If i invoke it and right click an item, the item opens and
the right click menu appears at the same time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[P . Otato via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #33 from P.Otato  ---
Hey,

I filed a report on the same topic (Bug 368793) and found this bug report
later. Therefore I marked my bug report as duplicate of this one.
The problem exists for me in Plasma 5.5.5 (openSUSE Leap 42.1) as well as in
Plasma 5.8 (KDE Neon GIT-stable branch) and can be always be reproduced. It
happens when the right mouse button is clicked very fast, the icon is not
selected previously (although I'm not sure if this makes a difference). The
problem does not exist with slow right mouse button clicks.

I used xev to make sure that no mouse movement is involved or others buttons
are pressed simultaneously. It is reproducible with different usb mice. The bug
was also tested on a notebook using the touchpad keys to be certain there is no
pointer movement.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[P . Otato via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

P.Otato  changed:

   What|Removed |Added

 CC||cfd_...@web.de

--- Comment #32 from P.Otato  ---
*** Bug 368793 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Tsu Jan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Tsu Jan  changed:

   What|Removed |Added

 CC||tsujan2...@gmail.com

--- Comment #31 from Tsu Jan  ---
For me, both on a desktop computer with nvidia and on a laptop with Intel, the
only way of right clicking an item on the desktop without opening it is holding
the right mouse button for 1-2 seconds (Manjaro Testing with
plasma-workspace-5.7.4).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #30 from Wolfgang Bauer  ---
I noticed meanwhile that this only happens if I tap the right mouse button
extremely shortly.
If I keep it pressed for a "longer" period (maybe 0.1 seconds, hard to say
exactly...), the file/icon is *not* opened.

Maybe this helps in reproducing the issue...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #29 from Wolfgang Bauer  ---
(In reply to Eike Hein from comment #27)
> My assumption is that this bug only happens after the state previously got
> corrupted by using the context menu elsewhere.

Well, in my case this occurs right after login, without doing anything else
first.
I.e. I just right-click on an icon in the folderview after logging in and it
gets opened (in addition to showing the context menu).

(In reply to Eike Hein from comment #28)
> Here's an updated patch for Qt 5.7 if you want to test:
> https://codereview.qt-project.org/#/c/166455/

I tried it and it does NOT help with this problem.

Btw, Qt 5.7.0 failed to compile with this patch here, I had to remove the "0L"
parameter in the call to deliverHoverEvent().

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #28 from Eike Hein  ---
Here's an updated patch for Qt 5.7 if you want to test:
https://codereview.qt-project.org/#/c/166455/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #27 from Eike Hein  ---
My assumption is that this bug only happens after the state previously got
corrupted by using the context menu elsewhere. This is not included in any of
the steps-to-reproduce, but I can't reproduce the problem otherwise, and
reading the code I can't see how it would happen otherwise - unless there's a
different Qt bug that causes mouse.buttons in MouseArea's clicked() handler to
be wrong, which is also possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #26 from kdeb...@toeai.com ---
(In reply to Eike Hein from comment #25)
> This is actually caused by a Qt bug; my fix for it is stuck since a while
> ago - https://codereview.qt-project.org/#/c/146786/

In reading that bug, the "common example" given at the top describes "clicking
outside the popup, and then clicking in the same spot that was clicked to
dismiss the popup."  That sounds a whole lot more like Bug 366065 than this
bug.  To be clear, this bug describes files being opened exactly on the
right-click of that file icon, and NOT on clicking elsewhere to dismiss the
popup menu.

Likewise, the other example given is always reproducible: "on the desktop
surface: Right-click empty space to get context menu, right-click above [i.e.
on] desktop icon to dismiss menu, right-click icon again and you still get the
empty-space context instead of the icon one."
That explains how you might get the wrong context menu in right-clicking a
desktop icon, but how does it explain opening that file/link when you
right-click it?

Also, that Qt bug and Bug 366065 are always reproducible, whereas this bug is
only "Reproducible: Sometimes", which makes this bug seem more like a timing
problem, race condition, or something dependent on less obvious circumstances.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #25 from Eike Hein  ---
This is actually caused by a Qt bug; my fix for it is stuck since a while ago -
https://codereview.qt-project.org/#/c/146786/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #24 from Wolfgang Bauer  ---
(In reply to kdebugs from comment #23)
> (In reply to Wolfgang Bauer from comment #21)
> > Maybe your right-handed/left-handed mouse settings got temporarily messed up
> > for some reason? ;-)
> 
> Nothing else was backward, and I would have noticed if I got a context menu
> with a left-click.

All right, that was just a though.
And just to be clear, I didn't want to deny the existance of this bug, rather
the opposite. As I wrote, I can reproduce it quite reliable here, on two
different systems and in a VM. But in my case, the context menu does reliably
appear and stays.

(In reply to Wolfgang Bauer from comment #22)
> For the record, this happened with Qt 5.6 and still happens with 5.7.
> I'm not sure if it was a problem with 5.5 too, but I will check.

I can reproduce it in a VM with openSUSE Leap 42.1 too, which uses Plasma 5.5.5
and Qt 5.5.1.
So it apparently is not caused by a change or bug in Qt 5.6 at least...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #23 from kdeb...@toeai.com ---
(In reply to Wolfgang Bauer from comment #21)
> It may have been the same problem, though in my experience the context menu
> does show up, only the file is opened at the same time.

In the upload provided in comment #11, you can see that the context menu opens
but immediately disappears.  The appearance or lack of the menu may just come
down to the speed and current load of the particular machine.  I can quite
reliably reproduce this bug by continually left-clicking the desktop followed
by right-clicking the icon repeatedly until it launches.  When it does launch,
a context menu does NOT appear for me, however when I tried to capture that
with my screen recorder, it slowed things down enough that the context menu did
momentarily appear, as in the attachment already uploaded.

I did have it happen on the first right-click once today - what was most
different yesterday was that it was happening first time, every time, until I
logged out.

> Maybe your right-handed/left-handed mouse settings got temporarily messed up
> for some reason? ;-)

Nothing else was backward, and I would have noticed if I got a context menu
with a left-click.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #22 from Wolfgang Bauer  ---
(In reply to Eike Hein from comment #20)
> No need to be sorry, thanks for the report!

Ok, but normally I would have opened a separate bug report. ;-)
It just seemed to have the same cause...

> I still want to address these right-click woes, but it's being hampered by
> the fact that I personally can't reproduce it and the code does the right
> thing already (the click handler checks for the right mouse button and balks
> out). This might need more complicated state to reproduce (a la bug 366065)
> or be a Qt bug (lying about which button was used in the event handler).

It's quite reliably reproducible here (since 5.5 or so).
I plan to investigate further myself, just didn't have time yet.

For the record, this happened with Qt 5.6 and still happens with 5.7.
I'm not sure if it was a problem with 5.5 too, but I will check.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #21 from Wolfgang Bauer  ---
(In reply to kdebugs from comment #18)
> Possibly related:  Today on Manjaro w/ plasma 5.6.5 I had desktop icons in
> folder view layout launching with just a single right-click.  No menu
> displayed - just instantly launched the application.  I realize this is
> somewhat different from the bug reported above, but it's similar and I
> couldn't reproduce it after logging out and back in, so I won't file a
> separate report.

It may have been the same problem, though in my experience the context menu
does show up, only the file is opened at the same time.

Maybe your right-handed/left-handed mouse settings got temporarily messed up
for some reason? ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #20 from Eike Hein  ---
No need to be sorry, thanks for the report!

I still want to address these right-click woes, but it's being hampered by the
fact that I personally can't reproduce it and the code does the right thing
already (the click handler checks for the right mouse button and balks out).
This might need more complicated state to reproduce (a la bug 366065) or be a
Qt bug (lying about which button was used in the event handler).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #19 from Wolfgang Bauer  ---
(In reply to Eike Hein from comment #16)
> The latter is actually a bug in Kicker it seems.

Ok, sorry.
I can confirm that your commit fixes that problem.
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

kdeb...@toeai.com changed:

   What|Removed |Added

 CC||kdeb...@toeai.com

--- Comment #18 from kdeb...@toeai.com ---
Possibly related:  Today on Manjaro w/ plasma 5.6.5 I had desktop icons in
folder view layout launching with just a single right-click.  No menu displayed
- just instantly launched the application.  I realize this is somewhat
different from the bug reported above, but it's similar and I couldn't
reproduce it after logging out and back in, so I won't file a separate report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #17 from Eike Hein  ---
Git commit 0065d3548c7db695b06d80250b11d018214967dc by Eike Hein.
Committed on 23/07/2016 at 00:46.
Pushed by hein into branch 'Plasma/5.7'.

Don't activate it on release events when a drag was started prior to it.

M  +1-0applets/kicker/package/contents/ui/ItemListDelegate.qml
M  +1-0applets/kicker/package/contents/ui/SideBarItem.qml

http://commits.kde.org/plasma-desktop/0065d3548c7db695b06d80250b11d018214967dc

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #16 from Eike Hein  ---
The latter is actually a bug in Kicker it seems.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #15 from Wolfgang Bauer  ---
This still happens in 5.7.2.

Note that the file is only opened if you right-click and immediately release
the mouse button.
If you keep it pressed, the file is never opened, only the context menu
appears.
So that's at least a workaround.

Maybe related: if you drag and drop an entry from the application menu to the
folderview it is also "opened". You can see the popup that asks whether you
want to copy/move/symlink for a second but it disappears again before you can
actually choose anything and the application is started instead.
Only seems to happen with Kicker though, not Kickoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Chris Williamson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Chris Williamson  changed:

   What|Removed |Added

 CC||chris@johnchristianwilliams
   ||on.name

--- Comment #14 from Chris Williamson  ---
This bug just started happening to me after I upgraded Kubuntu to version 16.04
(from 15.10).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Eike Hein  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #13 from Eike Hein  ---
Thank you, that's helpful. I'll try to get around to this problem soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Florian Röhrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #12 from Florian Röhrer  ---
I only did a single right click on the file

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Florian Röhrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #11 from Florian Röhrer  ---
Created attachment 98274
  --> https://bugs.kde.org/attachment.cgi?id=98274=edit
behaviour of right clicking

you can see the behaviour on second 5 of the video...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Eike Hein  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |WAITINGFORINFO

--- Comment #10 from Eike Hein  ---
Could you record and attach a short video using e.g. vokoscreen? It might give
me a better clue about what's going on.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Florian Röhrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #9 from Florian Röhrer  ---
At the moment I have Plasma 5.6.1 installed and it still happens...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #8 from Eike Hein  ---
I can't reproduce this. The code changed a bit since 5.5.5; please reopen if
the problem persists with 5.6.x.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Eike Hein  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #7 from Eike Hein  ---
Not at the moment, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Florian Röhrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #6 from Florian Röhrer  ---
Do you need any further information because the status of this bug is
"NEEDSINFO WAITINGFORINFO"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #5 from Eike Hein  ---
Against the "Folder" component of product "plasmashell".

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Florian Röhrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #4 from Florian Röhrer  ---
I use single click. For the future...where should i have reported this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #3 from Eike Hein  ---
Do you use single click or double click?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Eike Hein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #2 from Eike Hein  ---
Folder bugs can't be fixed if they're reported against the wrong component and
the reports aren't seen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 360219] Right Click opens files

[Florian Röhrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360219

--- Comment #1 from Florian Röhrer  ---
Is this bug going to be fixed in the near future? It is really annoying and
happens nearly every time. 
It only appears for files which are on the Desktop (folder view)

-- 
You are receiving this mail because:
You are watching all bug changes.