[plasmashell] [Bug 363878] option to make icons bigger

[Jack Lilhammers]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #16 from Jack Lilhammers  ---
Created attachment 123066
  --> https://bugs.kde.org/attachment.cgi?id=123066=edit
Spacing proof of concept

And it works!
It's just a proof of concept, but I'll work on it and submit a PR

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Jack Lilhammers]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #15 from Jack Lilhammers  ---
(In reply to Eike Hein from comment #14)
> > is this the correct file to edit?
> 
> No, sizing data mostly comes from the theme-specific SVG files and
> declarative expressions in Task.qml.

Ok, but I think that at least spacing is handled by the task manager, because
every theme seems to have square task icons, and that's unlikely.

In Task.qml I see the Item object that declares "width: height" and then uses
function adjustMargin(vert, size, margin) to calculate the margins, calling
function horizontalMargins() from layout.js.

Maybe adding a parameter could do the trick. Something like this:

function horizontalMargins(customMargin) {
return taskFrame.margins.left + taskFrame.margins.right + customMargin;
}

Forgive me if I ask dumb questions or say something stupid, I'm mostly a
firmware developer, have little experience with qt, and only with widgets, but
I'd really like to "fix" this design

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #14 from Eike Hein  ---
> is this the correct file to edit?

No, sizing data mostly comes from the theme-specific SVG files and declarative
expressions in Task.qml.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Jack Lilhammers]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #13 from Jack Lilhammers  ---
(In reply to Eike Hein from comment #9)
> Have you tried increasing the maximum panel icon size in System Settings ->
> Icons, Jack?

Yes, I have. As apache pointed out it's not that, and icons scale really well
when increasing the panel height.

As a matter of fact my main issue is spacing.
There's too little space between the icons, and it should be configurable, or
at least widened.
Just look at Dash to panel on Gnome, Start is back on Windows 10, or vanilla
even Windows 10 taskbar, 
Assuming that changing icons scaling may be difficult because of the small bar
above and the + sign when there are multiple instances open, spacing should be
quite trivial.
I was looking here:
https://github.com/KDE/plasma-desktop/blob/master/applets/taskmanager/package/contents/ui/code/layout.js

is this the correct file to edit?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[apache]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #12 from apache  ---
This is even better example how icon size doesn't match another widget size
(time and date) in terms of panel space utilization
https://i.imgur.com/nQLEQyT.png

I know it is different widget but just to clarify the problem.

I hope in Plasma 6 you would come back to plasma 4 solutions in terms of
customization of icons, fonts and colors.

In my humble opinion you improved what was better. Best is the enemy of good.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[apache]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #11 from apache  ---
Icons on task manager are not scalable in a sense that they can only have size
that is set in system settings. (Ok. it is kind of scaling but limited to
actual icons size). But task manager seems to have these predefined spaces. The
result is that making panel wider only increases space on panel that I marked
in red at the bottom of icon. And this is the case until panel is made larger
and next fixed size of icon jumps. 

Example - the same icon size with different spaces - one is from task manager
and the other from launcher added to panel from menu:

https://i.imgur.com/PnvTja4.png

https://i.imgur.com/99sPyPv.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[apache]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #10 from apache  ---
https://i.imgur.com/q4HkaeZ.png

Icon size settings has fixed values such as for example 48, 64. Increasing,
decreasing doesn't change anything because task manager widget (or panel - I am
not sure) are designed in the way that there is a space between icon and task
manager / panel edge. I marked in in red.

Of course it is not a bug. It is bad design that results in icon being always a
few pixel smaller than task / panel widget. 

Maybe this is different approach to "what looks good" but to me these spaces
that I marked red are useless / unnecessary / waste of space.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #9 from Eike Hein  ---
Have you tried increasing the maximum panel icon size in System Settings ->
Icons, Jack?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Jack Lilhammers]

https://bugs.kde.org/show_bug.cgi?id=363878

Jack Lilhammers  changed:

   What|Removed |Added

 CC||jack.lilhamm...@gmail.com

--- Comment #8 from Jack Lilhammers  ---
While I don't think that this is technically a bug, it sure is a missing
feature! I really prefer the icons only task manager over the other
alternatives, but the icons are small and crammed together with no way to
configure the appearence.
Icons scaling and spacing have to be hardcoded somewhere in source. Sometime
ago I skimmed through the code and didn't find 'em, but I can do it again. I'd
appreciate if someone could point me in the right direction

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363878

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #7 from Nate Graham  ---
No response and I can't really figure out what's being asked for; moving to
close.

Apache, if you want this bug report to be re-opened and worked on, here's the
information we need:

1. Upgrade to Plasma 5.11 and tell us if the issue still reproduces
2. If it does, please explain the issue in your own words or preferably with a
screen recording (but not a bunch of links to forum threads).

I know this has been a somewhat frustrating experience for you, and I apologize
for that. But we need more and clearer information to investigate the issue!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363878

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #6 from Nate Graham  ---
It's not totally clear what you're asking for, but let me have a go: are you
asking for the Icons-Only Task Manager to not have such thick padding around
the icons at various widths of the panel itself?

If so, I think the better solution is to have the icon smoothly scale as you
resize the panel, rather than keeping the current jerky resize behavior and
adding a setting to add or subtract padding.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[apache via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #5 from apache  ---
I just want to let you know that this is very old story:
https://bugs.kde.org/show_bug.cgi?id=254651
https://bugs.kde.org/show_bug.cgi?id=303787

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[apache via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363878

apache  changed:

   What|Removed |Added

 CC||sabayo...@gmail.com

--- Comment #4 from apache  ---
Created attachment 99341
  --> https://bugs.kde.org/attachment.cgi?id=99341=edit
desired settings

Did you take your time read it carefully? It states in description:

Please read Size of Task Manager Icons and System Tray Icons 
https://forum.kde.org/viewtopic.php?f=285=124799 

Everything is there. See also attachment.

I don't want wasted pixels as shown on screenshots. 
Plasma 5 Breeze Light Task manager
http://i.imgur.com/gB3qlUs.jpg
Plasma 5 Breeze Light Icons only Task manager
http://i.imgur.com/8WafAG3.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363878

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #3 from Kai Uwe Broulik  ---
I have no idea what your bug report is even about. Instead of dumping a bunch
of links please describe in the bug report itself what you want changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[apache via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #2 from apache  ---
Bug 363879 - option to make icons bigger is not a duplicate of this one. I want
to have this options in both widgets because I use regular task manager but my
acquaintances prefer icon task manager.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 363878] option to make icons bigger

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363878

--- Comment #1 from Kai Uwe Broulik  ---
*** Bug 363879 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.