[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Konrad Materka]

https://bugs.kde.org/show_bug.cgi?id=365105

Konrad Materka  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/krus |https://commits.kde.org/pla
   |ader/4b3d3b3ab21cff913a0529 |sma-integration/bc1c85144ad
   |fddabe94744f607b95  |b9a40ed8a6a38ac84234c738dbc
   ||7f
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Konrad Materka  ---
Git commit bc1c85144adb9a40ed8a6a38ac84234c738dbc7f by Konrad Materka.
Committed on 05/11/2019 at 11:42.
Pushed by kmaterka into branch 'master'.

[KDEPlatformSystemTrayIcon] Recreate deleted menu

Summary:
Recreate internal menu when needed.
It is possible that internal representation of system tray menu is
deleted. This can happen when QSystemTrayIcon is hidden.

Test Plan: Unit tests included

Reviewers: apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24843

M  +10   -2autotests/CMakeLists.txt
A  +106  -0autotests/kdeplatformsystemtrayicon_unittest.cpp [License:
LGPL (v2/3+eV)]
M  +40   -21   src/platformtheme/kdeplatformsystemtrayicon.cpp
M  +8-1src/platformtheme/kdeplatformsystemtrayicon.h

https://commits.kde.org/plasma-integration/bc1c85144adb9a40ed8a6a38ac84234c738dbc7f

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Konrad Materka]

https://bugs.kde.org/show_bug.cgi?id=365105

Konrad Materka  changed:

   What|Removed |Added

   Version Fixed In||5.18
 CC||mate...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Konrad Materka]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #13 from Konrad Materka  ---
Git commit aa6bb9b06cfba67c1ba226d053a49e0bc1b69cad by Konrad Materka.
Committed on 17/10/2019 at 15:34.
Pushed by kmaterka into branch 'master'.

[KStatusNotifierItem] Allow left click when menu is null

Summary:
If associatedWidget and menu are the same then instead of "activate"
action context menu is used. When both are null coparition is always
true but context menu can't be shown, since it is null.
It is partial solution for a problem described in
https://bugs.kde.org/show_bug.cgi?id=365105.

Test Plan:
As described in the bug:
* create QSystemTrayIcon
* assign QMenu
* show, hide and show again
Both right click and left click do nothing.

After change left click works

Reviewers: davidedmundson, broulik, nicolasfella, #frameworks

Reviewed By: davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24667

M  +2-2src/kstatusnotifieritem.cpp
M  +1-5src/kstatusnotifieritemdbus_p.cpp

https://commits.kde.org/knotifications/aa6bb9b06cfba67c1ba226d053a49e0bc1b69cad

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=365105

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Konrad Materka]

https://bugs.kde.org/show_bug.cgi?id=365105

Konrad Materka  changed:

   What|Removed |Added

 CC||h...@urpla.net

--- Comment #12 from Konrad Materka  ---
*** Bug 411851 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Pavlo84]

https://bugs.kde.org/show_bug.cgi?id=365105

Pavlo84  changed:

   What|Removed |Added

 CC||polyako...@gmail.com

--- Comment #11 from Pavlo84  ---
Confirmed that have the same situation with tray on Archlinux Plasma 5.11.4

Whats the status of bug?
Has anybody news?
Last comment was 2 month ago.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=365105

Alex Bikadorov  changed:

   What|Removed |Added

 Blocks|350920  |


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=350920
[Bug 350920] please revert removal of "minimize to tray"
-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=365105

Alex Bikadorov  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #10 from Alex Bikadorov  ---

sorry, closed the wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=365105

Alex Bikadorov  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/krus
   ||ader/4b3d3b3ab21cff913a0529
   ||fddabe94744f607b95
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Alex Bikadorov  ---
Git commit 4b3d3b3ab21cff913a0529fddabe94744f607b95 by Alexander Bikadorov.
Committed on 28/10/2016 at 17:14.
Pushed by abikadorov into branch 'master'.

FIXED: [ 365105 ] Workaround for bug in KF5+QSystemTrayIcon

M  +15   -0krusader/krusader.cpp

http://commits.kde.org/krusader/4b3d3b3ab21cff913a0529fddabe94744f607b95

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Alex Bikadorov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #8 from Alex Bikadorov  ---
Ehm, any news here?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Marcin Gryszkalis via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

Marcin Gryszkalis  changed:

   What|Removed |Added

 Blocks||350920

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[Piotr Wicijowski via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

Piotr Wicijowski  changed:

   What|Removed |Added

 CC||piw...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #7 from David Edmundson  ---
Update:

We have one menu for the whole tray instance
We create and delete KSNI object in init() and cleanup() which are called on
show() hide()

The SNI takes ownership of the menu

so for the the second init, we set the SNI to a now deleted menu.

It doesn't crash because it's wrapped in a QWeakpointer + guards as this came
up before and someone did a bodge job of fixing it in
ee62e7d9d2fe185f00562a74602aa4c19e8a88c7 fixing the symptoms without
identifying the root cause.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #6 from David Edmundson  ---
it's getting inside the first if() in here:


void KStatusNotifierItemDBus::Activate(int x, int y)
{
if (m_statusNotifierItem->d->associatedWidget ==
m_statusNotifierItem->d->menu) {
ContextMenu(x, y);
} else {
m_statusNotifierItem->activate(QPoint(x, y));
}
}


The reason being d->assoociatedWidget is null
and d->menu is null

hence it matches, but it's not really what that code is trying to do.

Doing the obvious fix on that fixes the bug. (plus again in
KStatusNotifierItem::activate where the code is repeated for no reason)

However, d->menu shouldn't  be null - you're clearly setting one.

Will investigate that - or maybe just get rid of the plasma SNI integration
given that's in Qt now..

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

David Edmundson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #5 from David Edmundson  ---
confirmed. 

unset XDG_CURRENT_DESKTOP 
unset KDE_FULL_SESSION 

so that it doesn't use our QPT fixes it - so the bug is probably in our
plasma-integration lib

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[A . Bikadorov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #4 from A. Bikadorov  ---
You can also use the Qt example:
https://doc.qt.io/qt-5/qtwidgets-desktop-systray-example.html

Same bug there

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[A . Bikadorov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #3 from A. Bikadorov  ---
Created attachment 99861
  --> https://bugs.kde.org/attachment.cgi?id=99861=edit
Cmake file

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[A . Bikadorov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

--- Comment #2 from A. Bikadorov  ---
Created attachment 99860
  --> https://bugs.kde.org/attachment.cgi?id=99860=edit
Demo code

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #1 from David Edmundson  ---
Could you just upload a small demo app as you've clearly written one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365105] QSystemTrayIcon with context menu does not react after second show

[A . Bikadorov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365105

A. Bikadorov  changed:

   What|Removed |Added

 CC||goto...@gmx.net

-- 
You are receiving this mail because:
You are watching all bug changes.