[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=365317

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||benjamin.h...@gmail.com

--- Comment #15 from Kai Uwe Broulik  ---
*** Bug 399088 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=365317

Nate Graham  changed:

   What|Removed |Added

 CC||nick.craig@gmail.com

--- Comment #14 from Nate Graham  ---
*** Bug 393748 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=365317

David Edmundson  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/ec1931f7b2980
   ||a3cd445c09def1bb4a9b5ad607f

--- Comment #13 from David Edmundson  ---
Git commit ec1931f7b2980a3cd445c09def1bb4a9b5ad607f by David Edmundson.
Committed on 29/03/2018 at 14:38.
Pushed by davidedmundson into branch 'master'.

Batch window changes events on XCB

Summary:
In a log from someone talking about high CPU we can see get multiple X
events for the same window as multiple events, but directly next to each
other. This causes the TaskManager to process changes multiple times
instead of just once which is a waste.

An example is just pressing "enter" in konsole, which will pointlessly
update the title.

This causes problems for expensive app lookup and also QML performs text
layouts immediately so any text changes cause quite large CPU usage if done
more than 60fps; especially a task text resizing
could result in resizing the entire panel.

Something not relevant in kwin that also monitors these rolls.

This class sits between KWindowSystem and XWindowTasksModel
transparently buffering the changes.
Related: bug 378010

Reviewers: #plasma, hein, broulik

Reviewed By: #plasma, hein, broulik

Subscribers: ngraham, cfeck, broulik, hein, graesslin, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7481

M  +1-0libtaskmanager/CMakeLists.txt
M  +0-1libtaskmanager/TODO.txt
A  +80   -0libtaskmanager/xwindowsystemeventbatcher.cpp [License: BSD]
A  +51   -0libtaskmanager/xwindowsystemeventbatcher.h [License: BSD]
M  +6-5libtaskmanager/xwindowtasksmodel.cpp

https://commits.kde.org/plasma-workspace/ec1931f7b2980a3cd445c09def1bb4a9b5ad607f

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=365317

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #12 from Alexander Mentyu  ---
Upon running the Python script - Panel and Desktop become unresponsive - Plasma
displays CPU usage up to 100% in htop utitility - and for one time after
killing the script - Plasma didn't stop to consume CPU - how can i test the
https://phabricator.kde.org/D7481 patch?

Plasma: 5.12.2
Apps: 17.12.2
Frameworks: 5.43.0
Qt: 5.10.1
Kernel: 4.14.20-2-MANJARO
OS: Netrunner Rolling

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=365317

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=365317

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #11 from David Edmundson  ---
Does someone want to test if https://phabricator.kde.org/D7481 has any impact?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Graham Perrin]

https://bugs.kde.org/show_bug.cgi?id=365317

Graham Perrin  changed:

   What|Removed |Added

 CC||grahamper...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=365317

--- Comment #10 from Eike Hein  ---
This is somewhat a known todo. The old libtaskmanager contained event
compression code ignoring updates across time slices of 200ms, the new
libtaskmanager currently doesn't yet. It's mentioned in the FIXMEs/TODOs of the
lib.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=365317

Kai Uwe Broulik  changed:

   What|Removed |Added

  Component|general |Task Manager
   Assignee|k...@davidedmundson.co.uk|h...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[PhysiOS]

https://bugs.kde.org/show_bug.cgi?id=365317

PhysiOS  changed:

   What|Removed |Added

 CC||phys...@peacefulnukes.com

--- Comment #9 from PhysiOS  ---
I can confirm it as well, I am making a game with libgdx and I ran into this
issue. Plasma freezes up temporarily and uses ~95% of one of my cpu cores until
it's unfrozen. 

I am running KDE Plasma 5.8.4, KDE Frameworks 5.28.0 if that is of any help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Martin Doege via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365317

--- Comment #8 from Martin Doege  ---
Maybe it could use a timestamp for these events and drop them if they are older
than a few seconds. Or maybe there should be a maximum length for the queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365317

--- Comment #7 from Kai Uwe Broulik  ---
It most likely queues all the events and then processes them one by one so it
continues long after the script has already quit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Martin Doege via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365317

--- Comment #6 from Martin Doege  ---
Yes, and as I wrote this unresponsiveness persists for quite a while after you
quit the script. I could understand a little task bar lag while the script is
running, but the recovery after that is far too slow.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365317

--- Comment #5 from Kai Uwe Broulik  ---
Wait a second. You actually constantly change the icon name in your script. So
that it announces icon changes is to be expected, I missed that. But still, we
should either compress those events or do something else more sensible than
freezing. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365317

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from Kai Uwe Broulik  ---
I can confirm. It seems like it reloads (or re-queries from the model and thus
reloads) the window icon whenever the title changes causing it to go crazy.

#10 0x733c7b14 in QImageWriter::write(QImage const&) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
#11 0x733a1d56 in operator<<(QDataStream&, QImage const&) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
#12 0x733d31cc in operator<<(QDataStream&, QPixmap const&) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
#13 0x74f863c4 in ?? () from
/usr/lib/x86_64-linux-gnu/libKF5IconThemes.so.5
#14 0x74f876a0 in KIconLoader::loadIcon(QString const&,
KIconLoader::Group, int, int, QStringList const&, QString*, bool) const ()
   from /usr/lib/x86_64-linux-gnu/libKF5IconThemes.so.5
#15 0x74f7da94 in KIconEngine::pixmap(QSize const&, QIcon::Mode,
QIcon::State)
() from /usr/lib/x86_64-linux-gnu/libKF5IconThemes.so.5
#16 0x733e5e48 in QIcon::pixmap(QWindow*, QSize const&, QIcon::Mode,
QIcon::State) const () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
#17 0x733e5f0e in QIcon::pixmap(QSize const&, QIcon::Mode,
QIcon::State) const
() from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
#18 0x7fffe050699a in ?? ()
   from
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemX11Plugin.so
#19 0x7fffe0503ee6 in ?? ()
   from
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemX11Plugin.so
#20 0x751c04a4 in KWindowSystem::icon(unsigned long long, int, int,
bool, int)
() from /usr/lib/x86_64-linux-gnu/libKF5WindowSystem.so.5
#21 0x751c04d7 in KWindowSystem::icon(unsigned long long, int, int,
bool) ()
   from /usr/lib/x86_64-linux-gnu/libKF5WindowSystem.so.5
#22 0x7fff362ecadc in
TaskManager::XWindowTasksModel::Private::icon(unsigned long long) () from
/usr/lib/x86_64-linux-gnu/libtaskmanager.so.6
#23 0x7fff362ed373 in TaskManager::XWindowTasksModel::data(QModelIndex
const&, int) const () from /usr/lib/x86_64-linux-gnu/libtaskmanager.so.6

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 365317] Rapid window title updates cause plasmashell to become unresponsive

[Martin Doege via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365317

Martin Doege  changed:

   What|Removed |Added

Summary|Fast window title updates   |Rapid window title updates
   |cause plasmashell to become |cause plasmashell to become
   |unresponsive|unresponsive

-- 
You are receiving this mail because:
You are watching all bug changes.