[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Version Fixed In||5.17.0 Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla |sma-workspace/e20f155190ac4 |sma-workspace/67c1117fa52d4 |e47bd2a9c1967b79f6e125c95ec |3877626ed2d7e3b5cdf02f3e5df --- Comment #13 from Nate Graham --- Git commit 67c1117fa52d43877626ed2d7e3b5cdf02f3e5df by Nate Graham, on behalf of Konrad Materka. Committed on 15/08/2019 at 16:54. Pushed by ngraham into branch 'master'. [System Tray] Do not send ContextMenu signal twice Summary: System Tray sends two "ContextMenu" events which breaks focus. One is send on mouse pressed, second on mouse clicked. As a result right click on the system tray icon causes focus to lock on the icon. If later user clicks somewhere else event is send to the first icon. Related: bug 409768 FIXED-IN: 5.17.0 Test Plan: The best to test with Skype for Linux with SNI bridge. To reproduce: * Right click on the Skype icon, click on menu item (can be Show Skype) * Right click on any other icon in system tray (or even any other place on the panel) * Skype menu will appear After fix: * Right click on the Skype icon, click on menu item (can be Show Skype) * Right click on any other icon in system tray (or even any other place on the panel) * Correct menu should show Reviewers: #plasma, broulik, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: broulik, apol, plasma-devel, #plasma_workspaces Tags: #plasma Differential Revision: https://phabricator.kde.org/D22804 M +2-3applets/systemtray/package/contents/ui/items/AbstractItem.qml M +5-0applets/systemtray/package/contents/ui/items/PlasmoidItem.qml https://commits.kde.org/plasma-workspace/67c1117fa52d43877626ed2d7e3b5cdf02f3e5df -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Nate Graham changed: What|Removed |Added CC||vitor...@pm.me --- Comment #12 from Nate Graham --- *** Bug 410749 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 --- Comment #11 from Konrad Materka --- My fix from comment above is not correct - it breaks right click for plasmoids. Improved patch sent for review: https://phabricator.kde.org/D22804 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 --- Comment #10 from hal...@gmail.com --- (In reply to Konrad Materka from comment #8) > I confirm that with latest Plasma 5.16.3. I found solution, will provide > patch later. > > Root cause: > System Tray sends two "ContextMenu" events which breaks focus. One is send > on mouse pressed, second on mouse clicked. It is leftover from not full > reverted patch. > Revert commit: > https://github.com/KDE/plasma-workspace/commit/27b1030756002e91b60ba51483efe9c2c477d16e > > > Fix: > Remove lines 111-113 from: > https://github.com/KDE/plasma-workspace/blob/master/applets/systemtray/package/contents/ui/items/AbstractItem.qml > > Local test: > Edit file and logout/reboot: > /usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/ > items/AbstractItem.qml > > > It will also fix Wine applications, now it is not possible to close context > menu by clicking outside of the menu. Sometimes it is not working at all - > menu shows, but cannon click on any position. > Surprisingly GTK + xembededsniproxy was working fine (For example XChat). > GTK applications ignore first event because mouse state is invalid > (pressed), only the second event is handled. Just tried the fix on my machine, and can confirm that it works. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Konrad Materka changed: What|Removed |Added CC||linus.kardell+kdebugs@gmail ||.com --- Comment #9 from Konrad Materka --- *** Bug 409649 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Konrad Materka changed: What|Removed |Added CC||kmate...@wp.pl --- Comment #8 from Konrad Materka --- I confirm that with latest Plasma 5.16.3. I found solution, will provide patch later. Root cause: System Tray sends two "ContextMenu" events which breaks focus. One is send on mouse pressed, second on mouse clicked. It is leftover from not full reverted patch. Revert commit: https://github.com/KDE/plasma-workspace/commit/27b1030756002e91b60ba51483efe9c2c477d16e Fix: Remove lines 111-113 from: https://github.com/KDE/plasma-workspace/blob/master/applets/systemtray/package/contents/ui/items/AbstractItem.qml Local test: Edit file and logout/reboot: /usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/AbstractItem.qml It will also fix Wine applications, now it is not possible to close context menu by clicking outside of the menu. Sometimes it is not working at all - menu shows, but cannon click on any position. Surprisingly GTK + xembededsniproxy was working fine (For example XChat). GTK applications ignore first event because mouse state is invalid (pressed), only the second event is handled. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Bruce Anderson changed: What|Removed |Added CC||banderson19...@san.rr.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 hal...@gmail.com changed: What|Removed |Added CC||hal...@gmail.com --- Comment #7 from hal...@gmail.com --- I'm experiencing this issue in Plasma 5.16.2, although the behavior is a little different: - Plasmoids in the system tray that do provide context menus are unaffected - The user needs to click on one of the context menu items for the bug to occur Strangely, this was not an issue for me in Plasma 5.13-5.15. Only the update to 5.16 started causing this issue. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Marco Martin changed: What|Removed |Added Resolution|FIXED |--- Ever confirmed|0 |1 CC||notm...@gmail.com Status|RESOLVED|REOPENED --- Comment #6 from Marco Martin --- commit closed wrong bug, sorry -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Marco Martin changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/pla ||sma-workspace/e20f155190ac4 ||e47bd2a9c1967b79f6e125c95ec --- Comment #5 from Marco Martin --- Git commit e20f155190ac4e47bd2a9c1967b79f6e125c95ec by Marco Martin. Committed on 29/03/2017 at 11:42. Pushed by mart into branch 'master'. Setting a sensible minimum size for plasmawindowed Summary: plasmawindowed didn't set any minimum size to its window, so it could be resized unusably small. it tried to find its attached Layout, but the attached property object wasn't created. now set the minimum size by the following heiristics: * if there is a switchsize, set it to switch to full representation * then take the full representation minimum size if available and bigger then switch size * otherwise, set it as SizeEnormous icon size * in any case, don't let the window be less than that Test Plan: tried both an applet that exports a layout and ful lrepresentation (kickoff) and an applet that wants to stay collapsed (analog clock) kickoff stays expanded at a reasonable minimum size, the clock can be scaled down to 128x128 Reviewers: #plasma, broulik Reviewed By: #plasma, broulik Subscribers: broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D5235 M +1-0plasma-windowed/CMakeLists.txt M +29 -15 plasma-windowed/plasmawindowedview.cpp M +2-0plasma-windowed/plasmawindowedview.h https://commits.kde.org/plasma-workspace/e20f155190ac4e47bd2a9c1967b79f6e125c95ec -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Joost Bremmer changed: What|Removed |Added CC||toos...@gmail.com --- Comment #4 from Joost Bremmer --- Also seem to still have this problem (plasma-workspace 5.9.4; Arch Linux). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 sparhawk changed: What|Removed |Added CC||kdeb...@plast.id.au --- Comment #3 from sparhawk --- I can confirm this in Arch Linux, Plasma 5.9.1-2. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 --- Comment #2 from Kai Uwe Broulik --- Wrong bug, I was refering to this commit https://cgit.kde.org/plasma-workspace.git/commit/?id=dfdb7296275c2c4bb9eda77982f8ff5663e58e5f (is both in 5.8.6 and 5.9.1) -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik --- Are you really using Plasma 5.9.1? I did a fix that landed there (cf. Bug 375941) but if you're still experiencing this, my fix wasn't good enough. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 376277] Right clicking on a system tray icon causes keeps focus on the icon even if user has moved elsewhere
https://bugs.kde.org/show_bug.cgi?id=376277 Serge Roussak changed: What|Removed |Added CC||beaux_mo...@tut.by -- You are receiving this mail because: You are watching all bug changes.
