[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Michail Vourlakos]

https://bugs.kde.org/show_bug.cgi?id=379414

--- Comment #8 from Michail Vourlakos  ---
(In reply to Ivan Čukić from comment #7)
> Fixed in the commit e8e2be90834b6526006f4961d62d511079d24d26 (for 5.10)

just a little note, the fix changes a bit the launchers ordering in some cases.
If I read correctly the code the patch adds the non active launchers(that are
hidden) after the active state launchers (launchers that are currently shown). 

So when the user moves the launchers for various activities will always end up
in the following ordering:

[global launchers] + [activity specific launchers]

if the user adds a global launcher after the [activity specific] launchers
after moving the launchers in other activities he will end up with the above
ordering.

Being honest, no problem, I prefer it that way

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Ivan Čukić]

https://bugs.kde.org/show_bug.cgi?id=379414

Ivan Čukić  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Ivan Čukić  ---
Fixed in the commit e8e2be90834b6526006f4961d62d511079d24d26 (for 5.10)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=379414

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Ivan Čukić]

https://bugs.kde.org/show_bug.cgi?id=379414

Ivan Čukić  changed:

   What|Removed |Added

   Assignee|h...@kde.org|ivan.cu...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Ivan Čukić]

https://bugs.kde.org/show_bug.cgi?id=379414

--- Comment #6 from Ivan Čukić  ---
I'll see what can be done. The sad part is that the pinned tasks is a
completely different beast to kicker favs. (here we chose to have different
per-applet pinned things, not global, so it does not use activity linking at
all)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=379414

--- Comment #5 from Eike Hein  ---
BTW: Keep in mind 5.10 final tagging is soon; while this is not a regression it
is serious and I'd like to see it addressed it in that release still, if
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=379414

--- Comment #4 from Eike Hein  ---
Basically the reason is that the data round trip is broken between the model
and the applet. The launcherList() getter returns a list built from
d->launchersOrder, but the setLauncherList() setter builds a new
d->launchersOrder from what's passed in, and on a move(), the applet passes in
a new list based on what it sees after filtering by activity. The result is
that the launchers specific to activities other than the current activity get
dropped. The change signal is emitted, and a new list from the getter sans them
is written to the config.

To sum it up, if you have activity-specific launchers on an activity different
from the current one, reordering launchers in the currenty activity will remove
them.


This is not a regression in this dev cycle, this bug was introduced with
per-activity launchers in 5.9.0 and is a design oversight in the code.

We can't make setLauncherList() implicitly activity-specific because we need a
setter for the full list to reload it from config. We need a
setLauncherListCurrentActivity() that's smart enough to do a merge.

Ivan, can you write this? You solved the same problem for Kicker-based
launchers so you presumably have a preferred way now. I'd like to see
consistent behavior between the interfaces, if possible/desirable, and I'm not
exactly sure what policy decisions you made on the launcher menus side for this
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Ivan Čukić]

https://bugs.kde.org/show_bug.cgi?id=379414

Ivan Čukić  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #3 from Ivan Čukić  ---
Confirming also for the normal task manager. I'll try to find what broke.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Gabriel C]

https://bugs.kde.org/show_bug.cgi?id=379414

Gabriel C  changed:

   What|Removed |Added

 CC||nix.or@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Michail Vourlakos]

https://bugs.kde.org/show_bug.cgi?id=379414

--- Comment #2 from Michail Vourlakos  ---
on prob Eike... It probably influences both plasma 5.9 and 5.10

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=379414

Eike Hein  changed:

   What|Removed |Added

 CC||ivan.cu...@kde.org

--- Comment #1 from Eike Hein  ---
I'm currently on a Wayland-focused Plasma dev sprint, but I'll try to look into
this at some point this month. Sorry for delays.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 379414] [Data Loss] - TaskManager loses launchers from alternative Activities

[Michail Vourlakos]

https://bugs.kde.org/show_bug.cgi?id=379414

Michail Vourlakos  changed:

   What|Removed |Added

   Severity|normal  |major
   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.