[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=385097

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=385097

David Edmundson  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/bfe2539aa0553 |sma-workspace/54c13f4c8ae93
   |6cf5e9c6b3327e5f1a6ebc91a73 |dd1b17f9d9a3a1a59e384d91ff4
 Resolution|--- |FIXED

--- Comment #10 from David Edmundson  ---
Git commit 54c13f4c8ae93dd1b17f9d9a3a1a59e384d91ff4 by David Edmundson, on
behalf of Randy Kron.
Committed on 28/01/2018 at 21:18.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Further improve quality of images in notifications

This revision further improves the quality of images in notifications
that was addressed in revision D9993. When I first looked into this, I
tried setting ScaleType on the PreviewJob but it had no effect. I found
that the preview images were being scaled to the small vertical size
that was requested, and this resulted in my first revision. I should
have tried setting ScaleType in addition.

Notification with unpatched libnotificationshelperplugin.so

{F5677396}

Notification with patch applied

{F5677397}

Test Plan:
Take screenshot with Spectacle with unpatched
libnotificationshelperplugin.so  installed and observe the blurry
preview image in the notification.

Install the patched libnotificationshelperplugin.so and restart
plasmashell.

Take another screenshot with Spectacle and observe the much improved
quality of the preview image in the notification.

Reviewers: #plasma_workspaces, #plasma, broulik, ngraham

Subscribers: #plasma, #plasma_workspaces, plasma-devel, broulik, ngraham

Tags: #plasma, #spectacle

Differential Revision: https://phabricator.kde.org/D10146

M  +1-0applets/notifications/plugin/thumbnailer.cpp

https://commits.kde.org/plasma-workspace/54c13f4c8ae93dd1b17f9d9a3a1a59e384d91ff4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385097

--- Comment #9 from Nate Graham  ---
You're very welcome. But also thank the people doing most of the hard work! I'm
mostly organizing, promoting, and trying to avoid taking credit for others'
superb labors.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=385097

--- Comment #8 from Dr. Chapatin  ---
Thank you Nate.
Keep your great work please.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385097

Nate Graham  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #7 from Nate Graham  ---
Re-opening since this was only half-fixed. Thankfully, Randy has submitted
another patch that does the other half: https://phabricator.kde.org/D10146

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=385097

David Edmundson  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.12.0
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/bfe2539aa0553
   ||6cf5e9c6b3327e5f1a6ebc91a73

--- Comment #5 from David Edmundson  ---
Git commit bfe2539aa05536cf5e9c6b3327e5f1a6ebc91a73 by David Edmundson, on
behalf of Randy Kron.
Committed on 26/01/2018 at 16:54.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Improve quality of images in notifications (Bug 385097)

Summary:
FIXED-IN: 5.12.0

This patch to plasma-workspace is to improve the quality of images in
notifications as reported in [[ https://bugs.kde.org/show_bug.cgi?id=385097 |
Bug 385097 ]].

It is still not perfect because KIO::PreviewJob is used to create the
thumbnail, and it only produces two sizes, 128px and 256px, so it is likely
that a small image will be scaled up, blurring it somewhat.

I took two screenshots of the same Dolphin window. Here is the before, without
the patch:
{F5665511}

And the after, with the patch:
{F5665513}

Better, but still not perfect.

Test Plan: Take screenshots with Spectacle with and without the patched
libnotificationshelperplugin library and observe the image quality in the
notification. plasmashell must be restarted when the library file is changed
for it to take effect.

Reviewers: #plasma_workspaces, #plasma, broulik

Reviewed By: #plasma_workspaces, #plasma, broulik

Subscribers: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma

Tags: #spectacle, #plasma

Differential Revision: https://phabricator.kde.org/D9993

M  +2-1applets/notifications/plugin/thumbnailer.cpp

https://commits.kde.org/plasma-workspace/bfe2539aa05536cf5e9c6b3327e5f1a6ebc91a73

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=385097

--- Comment #6 from Dr. Chapatin  ---
Improvement is welcome, but the problem reported here is not fixed.
Picture preview is still blury.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385097

--- Comment #4 from Nate Graham  ---
Randy helpfully submitted a patch: https://phabricator.kde.org/D9993

...And it's been accepted! If Kai doesn't land it today, I'll do it tonight.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385097

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from Nate Graham  ---
Wonderful, thanks Randy. However, we can't directly accept patches in bug
reports; they have to go through our review process on
http://phabricator.kde.org/. Even incomplete or as a work-in-progress, it would
be worth submitting your patch (with before-and-after screenshots, if possible)
just to solicit comments and maybe collaboratively converge towards a solution.

Here is the documentation for how to sign up for and use Phabricator:
https://community.kde.org/Infrastructure/Phabricator

Can't wait to see you there!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Randy]

https://bugs.kde.org/show_bug.cgi?id=385097

--- Comment #2 from Randy  ---
Created attachment 110014
  --> https://bugs.kde.org/attachment.cgi?id=110014=edit
plasma-workspace patch

I have a patch for plasma-workspace that improves this, but it's still not
perfect because KIO::PreviewJob is being used to create the thumbnail and it
only creates two sizes, 128px or 256px. So, depending on the final image size
required, a smaller image will still be scaled up, blurring it somewhat.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385097] Notification with image: image is blurry when image aspect ratio doesn't match the aspect ratio used in the notification

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385097

Nate Graham  changed:

   What|Removed |Added

Product|Spectacle   |plasmashell
Version|unspecified |master
 CC||plasma-b...@kde.org
Summary|Notification shows blury|Notification with image:
   |screenshot preview  |image is blurry when image
   ||aspect ratio doesn't match
   ||the aspect ratio used in
   ||the notification
  Component|General |Notifications
   Assignee|m...@baloneygeek.com  |k...@privat.broulik.de
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are watching all bug changes.