[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2019-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #26 from Nate Graham  ---
Nice job, a great fix!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2019-02-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.56

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2019-02-05 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=396011

Fabian Vogt  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kde
   ||clarative/856672f370fb32c7a
   ||3c3d1a13d873fb8b767d0e8
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #25 from Fabian Vogt  ---
Git commit 856672f370fb32c7a3c3d1a13d873fb8b767d0e8 by Fabian Vogt, on behalf
of Tranter Madi.
Committed on 05/02/2019 at 18:55.
Pushed by fvogt into branch 'master'.

Correct the accept flag of the event object on DragMove

Summary:
  - `m_enabled` or `m_temporaryInhibition` could change while DragMove, so we
should place `setAccepted()` on top of the function body. Otherwise, the accept
flag of `event` could be wrong in the case `m_enabled` or
`m_temporaryInhibition` changes while DragMove.
  - Don't call `setAccepted(false)` wrongly if `event->pos() ==
m_oldDragMovePo`

Test Plan:
- Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too
difficult -> fixed
- Drag an icon on Desktop (Folder view layout) from one place to another one ->
too difficult -> fixed
- Add widgets to the Plasma panel -> too difficult -> fixed
- Drag a file from Dolphin -> Desktop (Folder view layout) -> still easy

Reviewers: mart, broulik, #plasma, hein, bruns

Reviewed By: mart, #plasma

Subscribers: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D16643

M  +2-3src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

https://commits.kde.org/kdeclarative/856672f370fb32c7a3c3d1a13d873fb8b767d0e8

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2019-01-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

smash...@live.com changed:

   What|Removed |Added

 CC||smash...@live.com
Version|5.14.3  |5.14.5
   Platform|openSUSE RPMs   |Manjaro

--- Comment #24 from smash...@live.com ---
Patch D16643 fixes the issue for me as well.

Manjaro 18.0.2
qt 5.12.0-3.0
plasma 5.14.5-2

Thanks trmdi

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2019-01-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

asca...@q.com changed:

   What|Removed |Added

 CC||asca...@q.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-12-27 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

tr...@yandex.com changed:

   What|Removed |Added

 CC||and...@podzimek.org

--- Comment #23 from tr...@yandex.com ---
*** Bug 402606 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-12-02 Thread Jan Przybylak
https://bugs.kde.org/show_bug.cgi?id=396011

Jan Przybylak  changed:

   What|Removed |Added

 CC||jplx...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-11-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

tr...@yandex.com changed:

   What|Removed |Added

Version|5.14.2  |5.14.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-11-03 Thread David Korth
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #22 from David Korth  ---
Patch D16643 fixes the issue for me for both desktop and panel widgets.

Using KF 5.51, Plasma 5.14.2, and Qt 5.11.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-11-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #21 from Nate Graham  ---
Possible patch: https://phabricator.kde.org/D16643

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #20 from tr...@yandex.com ---
Created attachment 116043
  --> https://bugs.kde.org/attachment.cgi?id=116043=edit
Video3

Video3: add a widget to the Plasma panel is so difficult !!!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

tr...@yandex.com changed:

   What|Removed |Added

Version|5.14.0  |5.14.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #19 from tr...@yandex.com ---
A new case:
- Add widgets to the Plasma panel

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-23 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #18 from Eike Hein  ---
Thanks.

I'll try to reproduce the Dolphin-related cases later.

Dragging on FV is easy here, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #17 from tr...@yandex.com ---
Created attachment 115843
  --> https://bugs.kde.org/attachment.cgi?id=115843=edit
Video2

Summary:
- Drag a file from Dolphin -> Desktop (Folder view layout) -> work 100%
- Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too
difficult - Video: https://bugs.kde.org/show_bug.cgi?id=395491
- Drag an icon on Desktop (Folder view layout) from one place to another one ->
too difficult - Video: [Video2]

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #16 from tr...@yandex.com ---
(In reply to Eike Hein from comment #15)
> I'm not sure I understand the bug report then, you may need to clarify for
> me. The original report talks about "When dragging a file icon on the
> desktop in Folder View". So you're talking a Folder View widget on top of
> Desktop Containment? Icons aren't movable in FV widgets. Or do you mean Icon
> widgets on top of Desktop Containment, and the original report is wrong?

See the video: https://bugs.kde.org/show_bug.cgi?id=395491

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-23 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=396011

Eike Hein  changed:

   What|Removed |Added

 CC||h...@kde.org

--- Comment #15 from Eike Hein  ---
I'm not sure I understand the bug report then, you may need to clarify for me.
The original report talks about "When dragging a file icon on the desktop in
Folder View". So you're talking a Folder View widget on top of Desktop
Containment? Icons aren't movable in FV widgets. Or do you mean Icon widgets on
top of Desktop Containment, and the original report is wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

tr...@yandex.com changed:

   What|Removed |Added

  Component|Folder  |Desktop Containment
   Assignee|h...@kde.org|se...@kde.org

--- Comment #14 from tr...@yandex.com ---
(In reply to Eike Hein from comment #13)
> Unfortunately I've never encountered this problem on any of my systems. Qt
> 5.12, though.

Just tried again. It doesn't happen with Folder view layout, but it does happen
with Desktop Containment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-22 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #13 from Eike Hein  ---
Unfortunately I've never encountered this problem on any of my systems. Qt
5.12, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #12 from tr...@yandex.com ---
(In reply to trmdi from comment #11)
> (In reply to Patrick Silva from comment #9)
> > upstream bug was closed because requested info was not provided. :(
> 
> I can not reproduce the bug on that example.
> But the bug still happens on Plasma 5.14.0 / openSUSE Tumbleweed

This means it's a Plasma bug ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396011

tr...@yandex.com changed:

   What|Removed |Added

Version|5.13.2  |5.14.0
   Platform|Gentoo Packages |openSUSE RPMs

--- Comment #11 from tr...@yandex.com ---
(In reply to Patrick Silva from comment #9)
> upstream bug was closed because requested info was not provided. :(

I can not reproduce the bug on that example.
But the bug still happens on Plasma 5.14.0 / openSUSE Tumbleweed

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|UPSTREAM|---
 Ever confirmed|0   |1

--- Comment #10 from Nate Graham  ---
Eike, any chance you could take a look here when you get some breathing room?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-21 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=396011

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #9 from Patrick Silva  ---
upstream bug was closed because requested info was not provided. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

 CC||tr...@yandex.com

--- Comment #7 from Nate Graham  ---
*** Bug 395491 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-10-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

 CC||rgb@gmail.com

--- Comment #8 from Nate Graham  ---
*** Bug 399489 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-07-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #6 from Nate Graham  ---
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-07-03 Thread David Korth
https://bugs.kde.org/show_bug.cgi?id=396011

David Korth  changed:

   What|Removed |Added

URL||https://bugreports.qt.io/br
   ||owse/QTBUG-69246

--- Comment #5 from David Korth  ---
Upstream bug: https://bugreports.qt.io/browse/QTBUG-69246

Going to try creating a minimal test case, though I don't have too much
experience with QML / Qt Quick.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-07-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #4 from Nate Graham  ---
Thanks! Please mention the Qt bug report URL here, and let's see what shakes
out there. We can always re-open this if there's anything we need to do on our
side.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-07-02 Thread David Korth
https://bugs.kde.org/show_bug.cgi?id=396011

--- Comment #3 from David Korth  ---
I'm using Qt 5.11.1. I'll file a bug upstream.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-07-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=396011

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
Looks like a Qt bug and affects all places using Qml and drag and drop, e.g.
dragging a file from Dolphin to the wallpaper dialog also shows the same
erratic changing between accepted and denied cursor

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396011] Dragging icons doesn't work most of the time

2018-07-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396011

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
Not able to reproduce with git master on Neon.

-- 
You are receiving this mail because:
You are watching all bug changes.