[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-08-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #13 from el...@seznam.cz ---
Sure. I have added 2 screenshots. One from wayland (Wayland + scale factor 2 +
dock size 48px) and one from X11 (X11 + scale factor 2 + dock size 96px). 

X11 screenshot is 4K, but wayland screenshot was for some unknown reason saved
only as full HD. I used Spectacle. Anyway, worst looking icon is Thunderbird.
Hopefully you will see what I mean.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-08-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #12 from el...@seznam.cz ---
Created attachment 114285
  --> https://bugs.kde.org/attachment.cgi?id=114285=edit
latte-x11-smooth

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-08-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #11 from el...@seznam.cz ---
Created attachment 114284
  --> https://bugs.kde.org/attachment.cgi?id=114284=edit
latte-wayland-jagged

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-08-02 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=396770

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #10 from David Edmundson  ---
> Wayland + scale factor 2 + dock size 48px = OK, but icons have jagged edges

Couldn't reproduce. I turned on Qt's scaling and went up to 4x, it was all
smooth.

Can you post a screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #9 from el...@seznam.cz ---
Thank you very much for that comprehensive explanation. It certainly made
things clearer.

So I guess best thing for me will be to wait for Wayland session becoming
stable enough to be used daily.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-23 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=396770

David Edmundson  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #8 from David Edmundson  ---
Things are complex:

 - plasma does it's own scaling thing making things just bigger based on font
size. It was first, but it has a limited scope and is somewhat rubbish (hence
context menu being wrong)

 - Qt has a thing to have a separate physical and virtual pixels within the
client app. Mostly fantastic. Used in all apps.
Causes a mess for things like panels where we have to communicate between apps
or the WM which don't use the same virtual pixels as the client sees.
Given we have above, it's disabled in Plasma.

 - wayland also understands scaling that has the separate virtual and physical
pixels. It requires the "qt scaling" above to keep things high res but at least
we now use the same virtual pixels between app communication.

On wayland we enabled Qt scaling, using the internal env I added. 

When enabled in general as your virtual font size is now scaled back to 96dpi, 
Plasma's scaling cancels out. (even if it makes the code a mess)

Latte dock being plasma is mostly doing it the "plasma way" but it has a
setting in "px" which doesn't fit in within the Plasma font approach and won't
cancel out when we enable scaling. Your initial bug.
It also /might/ do it's own icon pixmap handling, which needs to be adapted for
Qt scaling. (potential jaggedness)


-

In any case, I shall look into fixing latte + wayland having jagged edges.  
If that happens to fix anything else, great. Otherwise, tough.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #7 from el...@seznam.cz ---
Update to my previous observations:

Wayland + scale factor 2 + dock size 48px = OK, but icons have jagged edges
Wayland + scale factor 2 + dock size 96px = large icons, but no jagged edges
Wayland + scale factor 2 + dock size 48px + PLASMA_USE_QT_SCALING=1= OK, but
icons have jagged edges

So it seems that PLASMA_USE_QT_SCALING has no effect in Wayland session.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #5 from el...@seznam.cz ---
I would like to have latte dock of size 48px. With various settings it works
like this:

X11 + scale factor 1 + dock size 48px = OK
X11 + scale factor 2 + dock size 48px = small icons
X11 + scale factor 2 + dock size 96px = OK
X11 + scale factor 2 + dock size 48px + PLASMA_USE_QT_SCALING=1 = size OK, but
icons have jagged edges
Wayland + scale factor 2 + dock size 48px = OK
Wayland + scale factor 2 + dock size 96px = large icons

I believe that scaling should be done on background and front end application
should be using same size of 48px regardless of scale factor. Of course front
end application must be aware of scale factor when displaying high resolution
content like images or bitmap icons.

I'm also attaching another picture. It shows desktop right click menu. In front
is my actual desktop and in the background is VirtualBox which basically
doubles the size of display without scaling. However as you can see font size
about the same (I have font DPI set to 192). But icons on real desktop are only
half the size as they should be. When I set PLASMA_USE_QT_SCALING=1, icons are
scaled as expected and font size remains the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #5 from el...@seznam.cz ---
I would like to have latte dock of size 48px. With various settings it works
like this:

X11 + scale factor 1 + dock size 48px = OK
X11 + scale factor 2 + dock size 48px = small icons
X11 + scale factor 2 + dock size 96px = OK
X11 + scale factor 2 + dock size 48px + PLASMA_USE_QT_SCALING=1 = size OK, but
icons have jagged edges
Wayland + scale factor 2 + dock size 48px = OK
Wayland + scale factor 2 + dock size 96px = large icons

I believe that scaling should be done on background and front end application
should be using same size of 48px regardless of scale factor. Of course front
end application must be aware of scale factor when displaying high resolution
content like images or bitmap icons.

I'm also attaching another picture. It shows desktop right click menu. In front
is my actual desktop and in the background is VirtualBox which basically
doubles the size of display without scaling. However as you can see font size
about the same (I have font DPI set to 192). But icons on real desktop are only
half the size as they should be. When I set PLASMA_USE_QT_SCALING=1, icons are
scaled as expected and font size remains the same.

--- Comment #6 from el...@seznam.cz ---
Created attachment 114078
  --> https://bugs.kde.org/attachment.cgi?id=114078=edit
Scaling of desktop right click menu

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=396770

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from David Edmundson  ---
> PLASMA_USE_QT_SCALING=1, 

You can't randomly set hidden internal environment variables. Lots of things
will be broke.

Can you clarify if the Wayland behavior is correct? You used the term double
size.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #3 from el...@seznam.cz ---
And when I say plasma panel, I mean System Tray icons which are quite small
without PLASMA_USE_QT_SCALING=1. Also right click menu uses small icons which
look like 16px icons on HiDPI display.

And to make things more confusing, Wayland session seems to do this
differently. System Tray icons have correct size and Latte Dock icons have
double size. So this actually behaves like I would expect it to.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=396770

--- Comment #2 from el...@seznam.cz ---
Let's say I use icons with size 32px and scale 1. Then I switch scale to 2, I
still should be using icons with size 32px, right? Or is pixel always
considered physical pixel and then I should use 64px?

I'm coming from web world where pixel is considered as virtual pixel and screen
density manages how many physical pixels are mapped to virtual pixel.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 396770] Icons have wrong scaling on HiDPI

2018-07-22 Thread Michail Vourlakos
https://bugs.kde.org/show_bug.cgi?id=396770

Michail Vourlakos  changed:

   What|Removed |Added

   Assignee|mvourla...@gmail.com|k...@davidedmundson.co.uk
  Component|plasmoid|general
Product|latte-dock  |plasmashell
Version|0.8.0   |5.13.3
 CC||plasma-b...@kde.org
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are watching all bug changes.