[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added Version Fixed In||5.25 Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/commit/ ||02d6d0a4090094437bc5ff334d1 ||24e9cf3b8b70e Status|ASSIGNED|RESOLVED --- Comment #26 from Nate Graham --- Git commit 02d6d0a4090094437bc5ff334d124e9cf3b8b70e by Nate Graham, on behalf of Méven Car. Committed on 14/03/2022 at 13:38. Pushed by ngraham into branch 'master'. RecentUsageModel: propagate mimeType to KFileItem ctor FIXED-IN: 5.25 Best used in conjunction with with https://invent.kde.org/frameworks/kio/-/merge_requests/780 which will allow kicker recentUsageModel not to make any stat call but solely base its iconName based on passed mimetype, allowing to act as if KFileItem::SkipMimeTypeFromContent was set. M +1-1applets/kicker/plugin/actionlist.cpp M +9-4applets/kicker/plugin/recentusagemodel.cpp M +1-1applets/kicker/plugin/recentusagemodel.h https://invent.kde.org/plasma/plasma-workspace/commit/02d6d0a4090094437bc5ff334d124e9cf3b8b70e -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #25 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1507 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #24 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/780 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added Status|ASSIGNED|CONFIRMED Assignee|meve...@gmail.com |k...@davidedmundson.co.uk CC||qydwhotm...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added CC||med.medin.2...@gmail.com --- Comment #23 from Nate Graham --- *** Bug 435366 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #22 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/174 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added Status|CONFIRMED |ASSIGNED Priority|NOR |HI Assignee|k...@davidedmundson.co.uk|meve...@gmail.com --- Comment #21 from Nate Graham --- There's a patch that fixes this: https://phabricator.kde.org/D26407 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #20 from Nate Graham --- Half fixed with https://phabricator.kde.org/D26580 Hopefully the rest will be fixed soon with https://phabricator.kde.org/D26407 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #19 from Postix --- Alternative to D23198: https://phabricator.kde.org/D26407 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Postix changed: What|Removed |Added CC||pos...@posteo.eu -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #18 from Txutxifel --- Hi, It's still present in Opensuse Tumbleweed. -Kde applications 19.12 -Plasma 5.17.4 -Kde Frameworks 5.64 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Patrick Silva changed: What|Removed |Added CC||ja...@thornber.io --- Comment #17 from Patrick Silva --- *** Bug 412312 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #16 from Méven Car --- Patch proposal: https://phabricator.kde.org/D23198 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 fadem...@gmail.com changed: What|Removed |Added CC||fadem...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #15 from Nate Graham --- *** Bug 410300 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #14 from Patrick Silva --- (In reply to Méven Car from comment #11)> > Could you Patrick Silva please file a separate bug next time. > > This is a bug introduced in : > https://phabricator.kde.org/D19784#502503 > The comment pointed diagnoses the issue and suggest a path to fixing. reported as bug 410300 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #13 from Méven Car --- @broulik Your patch addresses an older bug in task manager, and although the new one has a similar effect, it is caused a missing mimetype check rather an incorrect url passed. See https://phabricator.kde.org/D19784#502503 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #12 from Kai Uwe Broulik --- I bet this is pretty much the same thing as I tried to address in https://phabricator.kde.org/D22005 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #11 from Méven Car --- About the second screenshot added in : Patrick Silva 2019-07-25 18:02:15 UTC Created attachment 121732 [details] unknown icon in "History" tab of kickoff Related: "History" tab of kickoff also shows unknown icon for recent documents. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.16.80 KDE Frameworks Version: 5.61.0 Qt Version: 5.12.3 Could you Patrick Silva please file a separate bug next time. This is a bug introduced in : https://phabricator.kde.org/D19784#502503 The comment pointed diagnoses the issue and suggest a path to fixing. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #10 from Méven Car --- Nate, not likely, KActivities only stores file paths, the view and icon are the responsibility of the client, here the kickoff plasmoid. https://phabricator.kde.org/D22005 Seems to me the way to go -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added CC||meve...@gmail.com --- Comment #9 from Nate Graham --- Méven, could this be a problem in KActivities? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #8 from Patrick Silva --- Created attachment 121732 --> https://bugs.kde.org/attachment.cgi?id=121732=edit unknown icon in "History" tab of kickoff Related: "History" tab of kickoff also shows unknown icon for recent documents. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.16.80 KDE Frameworks Version: 5.61.0 Qt Version: 5.12.3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Alexander Potashev changed: What|Removed |Added CC||aspotas...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 toon.peperm...@hotmail.com changed: What|Removed |Added CC||toon.peperm...@hotmail.com --- Comment #7 from toon.peperm...@hotmail.com --- In my case (Plasma 5.16.2 on Kubuntu 19.04) both folders and Kate text files show the unknown icon in recent documents. This all worked fine for me in Plasma 5.15.4 (also tested on Kubuntu live iso). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #6 from Nate Graham --- There are two possible patches that could fix this: - https://phabricator.kde.org/D16087 - https://phabricator.kde.org/D22005 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added CC||jesa...@gmail.com --- Comment #5 from Nate Graham --- *** Bug 408337 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 --- Comment #4 from Buck Shockley --- This still occurs in the following software versions with the Breeze theme. KDE Plasma Version: 5.15.1 KDE Frameworks Version: 5.55.0 Qt Version: 5.12.1 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579
Chris Holland changed:
What|Removed |Added
CC||zrenf...@gmail.com
--- Comment #3 from Chris Holland ---
I can reproduce in Manjaro with Plasma 5.14.4, Frameworks 5.52, Qt 5.11.2. Note
I'm using the *Breath* icons, which I assume inherits the Breeze icons.
*
https://github.com/KDE/plasma-desktop/blame/master/applets/taskmanager/package/contents/ui/ContextMenu.qml#L101
*
https://github.com/KDE/plasma-desktop/blame/master/applets/taskmanager/plugin/backend.cpp#L286
Here's the KFileItem::iconName() code path:
* https://github.com/KDE/kio/blame/master/src/core/kfileitem.cpp#L893
* https://github.com/KDE/kio/blame/master/src/core/kfileitem.cpp#L1492
-
If I add a few `qDebug()` statements, it seems all the "Recent Doc" icons are
"application-octet-stream".
qDebug() << "url:" << url;
qDebug() << " scheme:" << url.scheme();
qDebug() << " isLocal:" << url.isLocalFile();
qDebug() << " isDir:" << fileItem.isDir();
qDebug() << " icon:" << fileItem.iconName();
url: QUrl("/home/chris/Pictures/Screenshots")
scheme: ""
isLocal: false
isDir: false
icon: "application-octet-stream"
I tried setting the scheme to "file" when it's empty. Which fixed
`url.isLocalFile()` but did not fix `KFileItem::isDir()`.
if (url.scheme() == QStringLiteral("")) {
url.setScheme("file");
}
url: QUrl("file:///home/chris/Pictures/Screenshots")
scheme: "file"
isLocal: true
isDir: false
icon: "application-octet-stream"
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added CC||win8li...@gmail.com --- Comment #2 from Nate Graham --- *** Bug 402663 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik --- Something I tried to address with [1] but it needs further investigation, or a fix/workaround in Task Manager plasmoid. [1] https://phabricator.kde.org/D16087 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 401579] Folders in recent documents show unknown icon
https://bugs.kde.org/show_bug.cgi?id=401579 Nate Graham changed: What|Removed |Added Component|Theme - Breeze |general Assignee|visual-des...@kde.org |k...@davidedmundson.co.uk CC||n...@kde.org Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
