[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 Nate Graham changed: What|Removed |Added Version Fixed In||5.19.0 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 tr...@yandex.com changed: What|Removed |Added Latest Commit|https://commits.kde.org/kio |https://commits.kde.org/pla |/fbb2be9aad196d92ca1a7adcc8 |sma-desktop/36e918b09780763 |afa8b63ba83659 |59c17c70c136bd27862db9d63 Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #9 from tr...@yandex.com --- Git commit 36e918b0978076359c17c70c136bd27862db9d63 by Tranter Madi. Committed on 04/02/2020 at 05:55. Pushed by trmdi into branch 'master'. Delay popup when dropping things into containments Summary: Depend: D26691 Test Plan: Drop files into desktop folder layout/folder widget, the menu is shown correctly in all cases. Reviewers: #plasma, davidedmundson, broulik, hein Reviewed By: #plasma, hein Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D26514 M +2-2containments/desktop/package/contents/ui/FolderView.qml M +3-2containments/desktop/plugins/folder/foldermodel.cpp M +1-1containments/desktop/plugins/folder/foldermodel.h https://commits.kde.org/plasma-desktop/36e918b0978076359c17c70c136bd27862db9d63 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #8 from tr...@yandex.com --- Git commit f8be3ea7102fbd584da1a39f5285ca72b5e69afa by Tranter Madi. Committed on 04/02/2020 at 05:54. Pushed by trmdi into branch 'master'. Optimize code when dropping files into the desktop Summary: Currently, when you have the desktop in the Desktop layout, if you drop 10 jpg files into the desktop, it creates 10 menus at the same position. When you have the desktop in the Folder layout, if you drop 10 jpg files into the desktop, it calls `KIO::setApplicationActions()` 10 times. What does this improve? - Do not create KIO::MimetypeJob for each file - Do not call `DropJob::setApplicationActions()` too many times/ create too many menus for each file. My idea is that, when you drop files into the desktop: - If they have the same `mimetype` -> we add actions support this `mimetype`. - If not -> we only show the action from `KIO::DropJob` and only actions support different `mimetypes` at the same time like `Add icon`... **Require:** D26484 Reviewers: #plasma, mart, broulik, #vdg, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D26691 M +95 -152 src/scriptengines/qml/plasmoid/containmentinterface.cpp M +2-4src/scriptengines/qml/plasmoid/containmentinterface.h A +110 -0src/scriptengines/qml/plasmoid/dropmenu.cpp [License: LGPL (v2+)] A +66 -0src/scriptengines/qml/plasmoid/dropmenu.h [License: LGPL (v2+)] https://commits.kde.org/plasma-framework/f8be3ea7102fbd584da1a39f5285ca72b5e69afa -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #7 from Christoph Feck --- Thanks for the clarification. You can use CCBUG: ## in commit messages to reference a bug without closing it. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #6 from tr...@yandex.com --- Maybe I shouldn't have added the BUG: line in the patch above. Sorry. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #5 from tr...@yandex.com --- (In reply to Christoph Feck from comment #4) > Tranter, could you please add a clarification which issue remains after the > recent commit? https://phabricator.kde.org/D26691 looks related, but only > seems an optimization? Yes, the above commit only add the new method in KIO::DropJob. Plasma need to make use of it to fix this bug but it hasn't yet. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #4 from Christoph Feck --- Tranter, could you please add a clarification which issue remains after the recent commit? https://phabricator.kde.org/D26691 looks related, but only seems an optimization? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 tr...@yandex.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 tr...@yandex.com changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kio ||/fbb2be9aad196d92ca1a7adcc8 ||afa8b63ba83659 Status|CONFIRMED |RESOLVED --- Comment #3 from tr...@yandex.com --- Git commit fbb2be9aad196d92ca1a7adcc8afa8b63ba83659 by Tranter Madi. Committed on 13/01/2020 at 12:34. Pushed by trmdi into branch 'master'. Add KIO::DropJobFlag to allow manually showing the menu Summary: This patch allows the application to manually popup the menu by using the `KIO::ShowMenuManually` flag with the `DropJob::showMenu()` method. Test Plan: Can't reproduce the bug with this patch. Reviewers: #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Reviewed By: dfaure Subscribers: ngraham, broulik, anthonyfieroni, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D26484 M +29 -5src/widgets/dropjob.cpp M +37 -0src/widgets/dropjob.h https://commits.kde.org/kio/fbb2be9aad196d92ca1a7adcc8afa8b63ba83659 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #2 from tr...@yandex.com --- It seems to be caused by this line: https://phabricator.kde.org/source/plasma-desktop/browse/master/containments/desktop/package/contents/ui/FolderView.qml$165 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 --- Comment #1 from Noah Davis --- I can reproduce this. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 415917] The context menu when dropping a file to the desktop corner doesn't appear correctly
https://bugs.kde.org/show_bug.cgi?id=415917 Noah Davis changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||noaha...@gmail.com Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
