[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-02-14 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=416695

David Edmundson  changed:

   What|Removed |Added

   Version Fixed In||5.18.1
  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/7a48de1efa224e6
   ||16d9f24f1fa1e4cdab0bce196
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from David Edmundson  ---
Git commit 7a48de1efa224e616d9f24f1fa1e4cdab0bce196 by David Edmundson.
Committed on 14/02/2020 at 12:17.
Pushed by davidedmundson into branch 'Plasma/5.18'.

Set toolbox to invisble when it's hidden

Summary:
opacity was bound to editMode, but this did not affect visibility or
enabled.

Not only is this somewhat wasteful, enabled is very important as
otherwise shortcuts for buttons get intercepted to match the accelerator
applied to the internal buttons. This breaks all the multi-key shortcuts
that plasma uses as alt+d gets taken.
FIXED-IN: 5.18.1

Test Plan:
Mad gammaray skillz to find the bug

Checked alt+d, a now opens the widget explorer
Checked edit mode through the context menu still showed the toolbox

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27386

M  +1-0toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
M  +0-2toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

https://commits.kde.org/plasma-desktop/7a48de1efa224e616d9f24f1fa1e4cdab0bce196

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-02-13 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=416695

--- Comment #3 from David Edmundson  ---
Wow, it's the invisible toolbox.

A button in there has some text that gets a kirigami acclerator applied

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-02-13 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=416695

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #2 from David Edmundson  ---
22:21:01.519 QShortcutMap::createNewSequences
createNewSequences(QKeyEvent(ShortcutOverride, Key_D, AltModifier, text="d"),
ignoredModifiers=QFlags(NoModifier)),
possibleKeys=(QKeySequence("Alt+D"))
22:21:01.519 QShortcutMap::find Possible shortcut key sequences:
QVector(QKeySequence("Alt+D"))
22:21:01.519 QShortcutMap::find Found better match (
QVector(QKeySequence("Alt+D")) ), clearing key sequence list
22:21:01.519 QShortcutMap::find Added ok key sequence
QVector(QKeySequence("Alt+D"))
22:21:01.520 QShortcutMap::find Returning shortcut match ==  2
22:21:01.520 QShortcutMap::nextState
QShortcutMap::nextState(QKeyEvent(ShortcutOverride, Key_D, AltModifier,
text="d")) = 2 (exact match)
22:21:01.520 QShortcutMap::dispatchEvent QShortcutMap::dispatchEvent(): Sending
QShortcutEvent(""Alt+D"", -167, false) to
object(ToolButton_QMLTYPE_21_QML_209(0x557fb03cf060))



some toolbutton somewhere has the shortcut "alt+d", possibly through the added
accelerators

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-02-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416695

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |major
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-02-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=416695

--- Comment #1 from Christoph Feck  ---
These shortcuts used to work in previous versions, and it was intended that
they all start with Alt+D.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-02-09 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=416695

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 416695] Chord keyboard shortcuts that begin with Alt+D all open the desktop settings window

2020-01-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416695

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||n...@kde.org
   Severity|minor   |normal
Summary|Context menu in Desktop |Chord keyboard shortcuts
   |Layout is confusing |that begin with Alt+D all
   ||open the desktop settings
   ||window

-- 
You are receiving this mail because:
You are watching all bug changes.