[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 Alexander Popel changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/commit/ ||6dc59a699895b34d8b0a8ca9492 ||3f6135f0e9e0a Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #8 from Alexander Popel --- Git commit 6dc59a699895b34d8b0a8ca94923f6135f0e9e0a by Oleksandr Popel. Committed on 30/04/2021 at 16:54. Pushed by ngraham into branch 'master'. Add a setting to keep normal notifications always on top M +2-1applets/notifications/package/contents/ui/global/Globals.qml M +3-0libnotificationmanager/kcfg/notificationsettings.kcfg M +14 -0libnotificationmanager/settings.cpp M +7-0libnotificationmanager/settings.h https://invent.kde.org/plasma/plasma-workspace/commit/6dc59a699895b34d8b0a8ca94923f6135f0e9e0a -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 Nicolas Fella changed: What|Removed |Added CC||cyrus.fr...@hotmail.com --- Comment #7 from Nicolas Fella --- *** Bug 421594 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 King Kang Kong changed: What|Removed |Added CC||r2b2x3+kde...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 --- Comment #6 from Alexander Popel --- Hmm, I just realized that there will be really annoying problem with such approach. As notification would be considered critical, it won't time out. This means that when I'm watching a video or a movie and receive a notification that I don't need to react to immediately, it won't go away by itself. I'll have to reach to my mouse and close it manually which is really inconvenient. Guess the fix won't be this simple :( -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 --- Comment #5 from Nate Graham --- Yeah, that'll work, at least until we want to change the visual appearance of notifications based on their severity value, as per Bug 411314. :) However maybe we can cross that bridge when we come to it. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 --- Comment #4 from Alexander Popel --- Yeah, I was able to find those interesting things before and they all come down to this ternary QML operation: type: model.urgency === NotificationManager.Notifications.CriticalUrgency && notificationSettings.keepCriticalAlwaysOnTop ? PlasmaCore.Dialog.CriticalNotification : PlasmaCore.Dialog.Notification It's just that my first instinct was to leave normal notifications' type as "PlasmaCore.Dialog.Notification" and implement the logic on a lower level (somewhere near "if this is a CriticalNotification - paint it on top" code). But I guess that's unnecessary and it's fine to just make the type of a normal notification be 'PlasmaCore.Dialog.CriticalNotification' if user wants to see it on top? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 --- Comment #3 from Nate Graham --- Try grepping for "keepCriticalAlwaysOnTop" in the plasma-workspace source code. You'll find some interesting things that you can use as a model. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 --- Comment #2 from Alexander Popel --- So I've decided to look into it myself, but can't find the code responsible for showing notification over full-screen window if its type is Dialog::CriticalNotification. I guess fixing this is as simple as adding an additional check there for a new option (like "Show normal notifications over full-screen windows" or something)? I could try to do that if somebody showed me the right direction. Although I have 0 experience in Plasma development, and only a bit more in C++ development so can't promise anything 😅 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 Nate Graham changed: What|Removed |Added Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 425071] Option to show all notifications in fullscreen windows
https://bugs.kde.org/show_bug.cgi?id=425071 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Severity|normal |wishlist CC||n...@kde.org --- Comment #1 from Nate Graham --- I have wished for this myself from time to time, yes. The only time I have a window full-screen is when I'm watching a YouTube video of some sort, which is always lower priority than any notifications that come in. I would prefer to be interrupted by those notifications rather than missing them. Maybe that's just because I'm a workholic lol If I really don't want any notifications at all, I'll quit apps that send them or turn on Do Not Disturb mode manually. -- You are receiving this mail because: You are watching all bug changes.
