[plasmashell] [Bug 435004] Circular timeout indicator looks bad at fractional scale or when using some non-Breeze icon themes

2022-08-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=435004

Nate Graham  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 435004] Circular timeout indicator looks bad at fractional scale or when using some non-Breeze icon themes

2022-08-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=435004

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |e52bfaf9e94193a3f966c4539fc |e462a0e3fcfbbb03dd7ebfc6ff7
   |21a9f25fac3ca   |b29ef9403e20e

--- Comment #6 from Nate Graham  ---
Git commit e462a0e3fcfbbb03dd7ebfc6ff7b29ef9403e20e by Nate Graham, on behalf
of Eugene Popov.
Committed on 16/08/2022 at 00:27.
Pushed by ngraham into branch 'Plasma/5.24'.

applets/notifications: Fix displaying header progress indicator on different
DPI

Currently, the progress indicator is normally displayed only if the DPI is a
multiple of 100; at other DPI values it's almost invisible or not visible at
all. This commit fixes that issue.
FIXED-IN: 5.24.7


(cherry picked from commit b5f903862e9383a8c7cb6087c1cdb5786c140f7b)

M  +2-2applets/notifications/package/contents/ui/NotificationHeader.qml

https://invent.kde.org/plasma/plasma-workspace/commit/e462a0e3fcfbbb03dd7ebfc6ff7b29ef9403e20e

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 435004] Circular timeout indicator looks bad at fractional scale or when using some non-Breeze icon themes

2022-08-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=435004

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |b5f903862e9383a8c7cb6087c1c |e52bfaf9e94193a3f966c4539fc
   |db5786c140f7b   |21a9f25fac3ca

--- Comment #5 from Nate Graham  ---
Git commit e52bfaf9e94193a3f966c4539fc21a9f25fac3ca by Nate Graham, on behalf
of Eugene Popov.
Committed on 16/08/2022 at 00:27.
Pushed by ngraham into branch 'Plasma/5.25'.

applets/notifications: Fix displaying header progress indicator on different
DPI

Currently, the progress indicator is normally displayed only if the DPI is a
multiple of 100; at other DPI values it's almost invisible or not visible at
all. This commit fixes that issue.
FIXED-IN: 5.24.7


(cherry picked from commit b5f903862e9383a8c7cb6087c1cdb5786c140f7b)

M  +2-2applets/notifications/package/contents/ui/NotificationHeader.qml

https://invent.kde.org/plasma/plasma-workspace/commit/e52bfaf9e94193a3f966c4539fc21a9f25fac3ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 435004] Circular timeout indicator looks bad at fractional scale or when using some non-Breeze icon themes

2022-08-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=435004

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||b5f903862e9383a8c7cb6087c1c
   ||db5786c140f7b
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.24.7

--- Comment #4 from Nate Graham  ---
Git commit b5f903862e9383a8c7cb6087c1cdb5786c140f7b by Nate Graham, on behalf
of Eugene Popov.
Committed on 16/08/2022 at 00:25.
Pushed by ngraham into branch 'master'.

applets/notifications: Fix displaying header progress indicator on different
DPI

Currently, the progress indicator is normally displayed only if the DPI is a
multiple of 100; at other DPI values it's almost invisible or not visible at
all. This commit fixes that issue.
FIXED-IN: 5.24.7

M  +2-2applets/notifications/package/contents/ui/NotificationHeader.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b5f903862e9383a8c7cb6087c1cdb5786c140f7b

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 435004] Circular timeout indicator looks bad at fractional scale or when using some non-Breeze icon themes

2021-12-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=435004

Nate Graham  changed:

   What|Removed |Added

Summary|Close button overlaps   |Circular timeout indicator
   |countdown circle in 150%|looks bad at fractional
   |scale   |scale or when using some
   ||non-Breeze icon themes
 Status|ASSIGNED|CONFIRMED

--- Comment #3 from Nate Graham  ---
That merge request was not merged. Discussion in there revealed that the
current approach is fundamentally unfixable for cases like this because it was
designed to be pixel-perfect at integer scale with Breeze icons. However when
using fractional scaling, icons scale in a different way from how the countdown
indicator scales, so the pixel-perfect representation breaks. It also breaks at
any scale when using an icon theme with close icon metrics that do not exactly
match those of the Breeze icon theme.

We have three options:

1. Use a hardcoded close button drawn with QtQuick primitives instead of an
icon from the icon theme, which will scale the same way as the close indicator.
- Downside: close button icon becomes visually inconsistent when using a
non-Breeze icon theme

2. Give up on the circular timeout indicator and use a different visual
representation that doesn't try to hug an icon
- Downsides: might look worse or more visually intrusive; circular timeout
indicator is pretty cool after all

3. Do nothing and accept glitches like this
- Downside: looks bad when using fractional scaling or some alternative icon
themes

-- 
You are receiving this mail because:
You are watching all bug changes.