[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=444142

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.24
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/commit/62
   ||a9ff23e95ce84b39bb7e9854f8e
   ||1b181a20e07
 Resolution|--- |FIXED

--- Comment #15 from Nate Graham  ---
Git commit 62a9ff23e95ce84b39bb7e9854f8e1b181a20e07 by Nate Graham, on behalf
of Bharadwaj Raju.
Committed on 28/10/2021 at 17:45.
Pushed by ngraham into branch 'master'.

applets/taskmanager: Don't open other tooltips by hover if current one was
opened by click
Related: bug 430438
FIXED-IN: 5.24

M  +16   -1applets/taskmanager/package/contents/ui/Task.qml
M  +1-1   
applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
M  +7-1applets/taskmanager/package/contents/ui/code/tools.js
M  +2-0applets/taskmanager/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/62a9ff23e95ce84b39bb7e9854f8e1b181a20e07

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #14 from Nate Graham  ---
Git commit f8798ba69aa0f4e29c2fde035a87932379678040 by Nate Graham, on behalf
of Bharadwaj Raju.
Committed on 28/10/2021 at 17:41.
Pushed by ngraham into branch 'master'.

Introduce dismissOnHoverLeave property and toolTipVisibleChanged signal

Introduces new signal `toolTipVisibleChanged(bool toolTipVisible)`, so users
can be
signalled when the tooltip is shown or hidden.

This is needed for implementing a fix to
https://bugs.kde.org/show_bug.cgi?id=444142,
so that tooltips opened with a click are not dismissable by hovering over
another Task.

M  +2-0src/declarativeimports/core/tooltip.cpp
M  +6-0src/declarativeimports/core/tooltip.h

https://invent.kde.org/frameworks/plasma-framework/commit/f8798ba69aa0f4e29c2fde035a87932379678040

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-22 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=444142

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #13 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/628

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #12 from qydwhotm...@gmail.com ---
The timeout should be "the tooltip will disappear after 4s without any action".
So I think it's easier to fix and different from 358930.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread David
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #11 from David  ---
(In reply to Bharadwaj Raju from comment #10)
> Just to clarify, you're encountering this bug when you try to move your
> mouse in a diagonal to a window in the opened tooltip, and you cross over
> another app, right?

It does happens like that and most of the times that is what makes it so
annoying, but I also encounter this bug while moving the mouse horizontally,
deviating from a straight diagonal (e.g. the previews span 5 icons, I move
horizontally and then upwards, now the previews are from a different app).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Bharadwaj Raju
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #10 from Bharadwaj Raju  ---
Just to clarify, you're encountering this bug when you try to move your mouse
in a diagonal to a window in the opened tooltip, and you cross over another
app, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread David
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #9 from David  ---
I guess it is the same underlying cause as in 358930, but this happens with a
left-click so I don't think the solution to that bug would do, since that's
just a 100ms timeout for re-generating on-hover previews, whereas for a
left-click I think most people would expect the previews to stay there, since
they are supposed to be generated on click and not on hover.

I think a more logical action would be for them to disappear after a longer
timeout without showing the previews of a different app, like in MS windows and
in earlier versions of latte.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Bharadwaj Raju
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #8 from Bharadwaj Raju  ---
(In reply to qydwhotmail from comment #7)
> It seems to fix the bug, a new logic is needed like:
> 
> if isToolTipOpenByClick; then
>   ignore containsMouse events until timeout

That would be a general solution to bug 358930 as well. Except, adding timeouts
like that will make the UI less responsive. We can fix the problem without
relying on timeouts. The ideal solution is a triangle mouse filter, see
https://bjk5.com/post/44698559168/breaking-down-amazons-mega-dropdown. I'm
working on adding a triangle mouse filter to the task manager, which will fix
both this and the other bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #7 from qydwhotm...@gmail.com ---
It seems to fix the bug, a new logic is needed like:

if isToolTipOpenByClick; then
  ignore containsMouse events until timeout

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Bharadwaj Raju
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #6 from Bharadwaj Raju  ---
Bug 358930 is not only for multiple rows, it happens with single rows as well

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread David
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #5 from David  ---
It's not the same as 358930 since it happens with only one row, and as far as I
can tell there is no pre-selected window within the thumbnails when I first
click them. And yes, this is X11.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Bharadwaj Raju
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #4 from Bharadwaj Raju  ---
(In reply to Nate Graham from comment #3)
> No, it's actually not that. The problem is that when you click on a grouped
> app with these settings, it pre-selects the first thumbnail in the tooltip,
> which automatically causes its window to be highlighted. When you move the
> cursor over to another app, the tooltip changes to show that app, with the
> first thumbnail (which is now something else) still pre-selected, so the
> highlighted app changes.
> 
> Probably when you click on a grouped app to show tooltips, we shouldn't
> automatically select any of the thumbnails in it.

Having a thumbnail pre-selected only happens if you're 1) using Wayland and 2)
have previously clicked on a thumbnail to activate it. This is a bug. See my MR
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/494.

Since OP is using X11, either that bug isn't Wayland-specific as I thought, or
they're actually describing a symptom of bug 358930.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #3 from Nate Graham  ---
No, it's actually not that. The problem is that when you click on a grouped app
with these settings, it pre-selects the first thumbnail in the tooltip, which
automatically causes its window to be highlighted. When you move the cursor
over to another app, the tooltip changes to show that app, with the first
thumbnail (which is now something else) still pre-selected, so the highlighted
app changes.

Probably when you click on a grouped app to show tooltips, we shouldn't
automatically select any of the thumbnails in it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Bharadwaj Raju
https://bugs.kde.org/show_bug.cgi?id=444142

--- Comment #2 from Bharadwaj Raju  ---
Is the real problem actually that when you open a tooltip and try to move your
mouse into it, you accidentally cross other apps and their tooltips activate?
If so, that is bug 358930.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 444142] Setting window tooltips as click action in task manager shifts previewed app as mouse moves

2021-10-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=444142

Nate Graham  changed:

   What|Removed |Added

 CC||bharadwaj.raju777@protonmai
   ||l.com, n...@kde.org,
   ||plasma-b...@kde.org,
   ||qydwhotm...@gmail.com
   Assignee|unassigned-b...@kde.org |h...@kde.org
Version|unspecified |5.23.1
 Ever confirmed|0   |1
   Severity|normal  |minor
Product|kde |plasmashell
  Component|general |Task Manager and Icons-Only
   ||Task Manager
 Status|REPORTED|CONFIRMED
   Target Milestone|--- |1.0

--- Comment #1 from Nate Graham  ---
Can reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.