[plasmashell] [Bug 448526] Blue highlight disappears after right-clicking on items in right pane
https://bugs.kde.org/show_bug.cgi?id=448526 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1021 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 448526] Blue highlight disappears after right-clicking on items in right pane
https://bugs.kde.org/show_bug.cgi?id=448526 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In||5.25.3 Latest Commit||https://invent.kde.org/plas ||ma/plasma-desktop/commit/81 ||129445316dcbe3082b14e48e013 ||8b303cd5863 --- Comment #4 from Nate Graham --- Git commit 81129445316dcbe3082b14e48e0138b303cd5863 by Nate Graham. Committed on 05/07/2022 at 17:02. Pushed by ngraham into branch 'master'. applets/kickoff: remove highlight visibility conditions These conditions seem unnecessary and cause a minor bug. Let's remove them and allow the ListView to manage highlight visibility itself. FIXED-IN: 5.25.3 M +0-2applets/kickoff/package/contents/ui/KickoffGridView.qml M +0-2applets/kickoff/package/contents/ui/KickoffListView.qml https://invent.kde.org/plasma/plasma-desktop/commit/81129445316dcbe3082b14e48e0138b303cd5863 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 448526] Blue highlight disappears after right-clicking on items in right pane
https://bugs.kde.org/show_bug.cgi?id=448526 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/commit/81 |ma/plasma-desktop/commit/9c |129445316dcbe3082b14e48e013 |9b53b6bf021ddc8709a34db998f |8b303cd5863 |b21f4138f61 --- Comment #5 from Nate Graham --- Git commit 9c9b53b6bf021ddc8709a34db998fb21f4138f61 by Nate Graham. Committed on 05/07/2022 at 17:22. Pushed by ngraham into branch 'Plasma/5.25'. applets/kickoff: remove highlight visibility conditions These conditions seem unnecessary and cause a minor bug. Let's remove them and allow the ListView to manage highlight visibility itself. FIXED-IN: 5.25.3 (cherry picked from commit 81129445316dcbe3082b14e48e0138b303cd5863) M +0-2applets/kickoff/package/contents/ui/KickoffGridView.qml M +0-2applets/kickoff/package/contents/ui/KickoffListView.qml https://invent.kde.org/plasma/plasma-desktop/commit/9c9b53b6bf021ddc8709a34db998fb21f4138f61 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 448526] Blue highlight disappears after right-clicking on items in right pane
https://bugs.kde.org/show_bug.cgi?id=448526 Nate Graham changed: What|Removed |Added Summary|Blue highlight disappears |Blue highlight disappears |after right-clicking on |after right-clicking on |apps|items in right pane -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 448526] Blue highlight disappears after right-clicking on items in right pane
https://bugs.kde.org/show_bug.cgi?id=448526
--- Comment #2 from Noah Davis ---
I think this was done intentionally at some point, but I can't remember when it
was done, why it was done or who did it. I'm OK with removing or keeping it.
Git blame says it's my code, but I distinctly remember trying to preserve
existing behavior.
```qml
highlight: PlasmaCore.FrameSvgItem {
// The default Z value for delegates is 1. The default Z value for
the section delegate is 2.
// The highlight gets a value of 3 while the drag is active and
then goes back to the default value of 0.
z: root.currentItem && root.currentItem.Drag.active ?
3 : 0
opacity: view.activeFocus
|| (plasmoid.rootItem.contentArea === root
&& plasmoid.rootItem.searchField.activeFocus) ? 1 : 0.5
imagePath: "widgets/viewitem"
prefix: "hover"
visible: plasmoid.rootItem.contentArea !== root
|| ActionMenu.menu.status !== 1
}
```
`visible: plasmoid.rootItem.contentArea !== root || ActionMenu.menu.status !==
1` is the relevant bit of code. We just need to remove `||
ActionMenu.menu.status !== 1`.
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 448526] Blue highlight disappears after right-clicking on items in right pane
https://bugs.kde.org/show_bug.cgi?id=448526 Patrick Silva changed: What|Removed |Added Version|5.23.90 |5.24.90 -- You are receiving this mail because: You are watching all bug changes.
