[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/ |0bb681869f0462e74d0c411e210 |6c2d9d4a66db35ab208f194f6a3 |8bf3e0d371dd5 |7c7d0bc634d11 --- Comment #5 from Nate Graham --- Git commit 6c2d9d4a66db35ab208f194f6a37c7d0bc634d11 by Nate Graham, on behalf of David Edmundson. Committed on 15/02/2022 at 00:39. Pushed by ngraham into branch 'Plasma/5.24'. Move to runtime check of valid font DPI The current code checks if we have an entry, but not that the entry is sane. FIXED-IN: 5.24.1 (cherry picked from commit 0bb681869f0462e74d0c411e2108bf3e0d371dd5) M +3-2kcms/fonts/fontinit.cpp https://invent.kde.org/plasma/plasma-workspace/commit/6c2d9d4a66db35ab208f194f6a37c7d0bc634d11 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918 Nate Graham changed: What|Removed |Added Version Fixed In||5.24.1 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/commit/ ||0bb681869f0462e74d0c411e210 ||8bf3e0d371dd5 --- Comment #4 from Nate Graham --- Git commit 0bb681869f0462e74d0c411e2108bf3e0d371dd5 by Nate Graham, on behalf of David Edmundson. Committed on 15/02/2022 at 00:38. Pushed by ngraham into branch 'master'. Move to runtime check of valid font DPI The current code checks if we have an entry, but not that the entry is sane. FIXED-IN: 5.24.1 M +3-2kcms/fonts/fontinit.cpp https://invent.kde.org/plasma/plasma-workspace/commit/0bb681869f0462e74d0c411e2108bf3e0d371dd5 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1457 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918
--- Comment #2 from David Edmundson ---
>Good catch, looks like that's exactly what happens.
>`fontsCfg.readEntry(fontDpiKey, 0)` means "fall back to 0 if fontDpiKey isn't
>found". And then that 0 gets unconditionally written out.
Just above we have:
if (!fontsCfg.hasKey(fontDpiKey)) {
return;
}
It means there is a key with this set to 0 set by someone.
So similar bug, but not the fault of my patch (obviously :D )
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918 Nate Graham changed: What|Removed |Added Component|general |Startup process CC||k...@davidedmundson.co.uk Assignee|k...@davidedmundson.co.uk|plasma-b...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Keywords||regression CC||n...@kde.org Status|REPORTED|CONFIRMED --- Comment #1 from Nate Graham --- Good catch, looks like that's exactly what happens. `fontsCfg.readEntry(fontDpiKey, 0)` means "fall back to 0 if fontDpiKey isn't found". And then that 0 gets unconditionally written out. Would you like to submit a merge request to fix it? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 449918] plasma-workspace-5.24.0 sets Xft.dpi to 0 in Xresources
https://bugs.kde.org/show_bug.cgi?id=449918 he...@freedesk.net changed: What|Removed |Added CC||he...@freedesk.net -- You are receiving this mail because: You are watching all bug changes.
