[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-29 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=455560

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/commit/76
   ||4b072fe82b3ee31aed6bd0d3ddf
   ||23e6810f844
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.26

--- Comment #5 from Nate Graham  ---
Git commit 764b072fe82b3ee31aed6bd0d3ddf23e6810f844 by Nate Graham.
Committed on 29/06/2022 at 22:57.
Pushed by ngraham into branch 'master'.

Make windowlist app name display configurable

Before Plasma 5.25, this widget's panel button was always just an icon. That
changed in 5.25, so now it also has text when used on a horizontal panel,
where there's space for it. This makes the widget awkward if there are other
widgets adjacent to it, because its width will constantly change based on the
name of the active application, causing other widgets to shift around and
breaking the user's muscle memory. On the other hand, this is fine as long as
the widget has a flexible spacer between it and any other widgets, or if its
adjacent widgets have their own built-in space-filling flexible spacers, as
the Task Manager and Global Menu widgets do.

Because that can't be programmatically determined, and also because users of
horizontal panels may prefer the icons-only version anyway, let's make this
configurable.

This new config option only works when the widget is located on a horizontal
panel, so it automatically disables itself and shows an explanatory message
when it's being used in any other circumstance.

| Config UI when the widget is on a horizontal panel | Config UI when the
widget is on a vertical panel | Config UI when the widget is on the Desktop |
| -- |
 |  |
|
![Horizontal_panel](/uploads/a8b6da1269f316dd8eec024ada89b1e6/Horizontal_panel.png)
|
![Vertical_panel](/uploads/f079d4e34f67df93e4cdca923c68c29f/Vertical_panel.png)
| ![Desktop](/uploads/3aed5d892fe4f8d83cde6a8fddef476c/Desktop.png) |
FIXED-IN: 5.26

@cblack @teams/usability @teams/vdg

A  +17   -0applets/window-list/contents/config/config.qml [License:
GPL(v2.0+)]
A  +18   -0applets/window-list/contents/config/main.xml
A  +54   -0applets/window-list/contents/ui/ConfigGeneral.qml [License:
GPL(v2.0+)]
M  +1-1applets/window-list/contents/ui/MenuButton.qml

https://invent.kde.org/plasma/plasma-desktop/commit/764b072fe82b3ee31aed6bd0d3ddf23e6810f844

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=455560

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=360309

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-23 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=455560

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1001

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=455560

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED
   Keywords|regression  |
 CC||uhh...@gmail.com
   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=455560

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|INTENTIONAL |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Nate Graham  ---
I understand. Thanks for the clarification.

In fact we added the mode you want for vertical panels, where there is never
enough space for a label. We could probably bubble that up as a user-facing
config option:

[] Show text when used on a horizontal panel

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-21 Thread Denis Lisov
https://bugs.kde.org/show_bug.cgi?id=455560

--- Comment #2 from Denis Lisov  ---
(In reply to Nate Graham from comment #1)
> I understand that the variable length based on window title can become
> annoying, but a list of windows (per the widget's name) pretty much has to
> display the window title. If it only displays the icon, it's not a list
> anymore, and furthermore, only showing icons would leave you unable to
> visually distinguish between windows that have the same icon, as when you
> open multiple windows of an app. If we capped the length, then it would
> elide long text at a certain point and that would be annoying too.

Sorry, I may have stated the question not clear enough.
Up to Plasma 5.24 the Window List applet used to have a single function:
provide a way of choosing the window to switch to in two clicks via the popup.
Since 5.25 it also has the second function of showing the user which
application is active at the moment by replacing a small "open window list"
button with a bigger and variable-size "current application" button.
I don't have any problems with the window list pop-up itself showing both
window icons and full-length window titles - as you say, it would be strange to
have a list of windows that would not actually list windows. What I'm asking
for is an option to disable the second function and go back to a "open window
list" button instead of a "current application" one.
For me the "current application" button provides no useful information because
(a) the application that's currently active is part of my working context
that's hard to lose track of, (b) this information isn't needed often as one
usually cares about the window they're switching to, not the one they're
switching from, and (c) it's easy to find the active window frame or look at
the Task Manager applet even if lost. Furthermore, as the button displays the
application name and not the window name it's already useless for
distinguishing between windows of the same application, and the icon would be
enough for distinguishing between different applications in most cases.

Could you please clarify if I'm misunderstanding something or not understanding
the intended use cases? It really looks to me like replacing the "open window
list" panel button with the "current application" panel button trades panel
space and layout consistency (due to variable width) for extra information
that's in many cases both obvious from other indicators (decorations, task
manager applet, etc) and useless / unactionable (do you often happen to ask
yourself "what application does the focused window belong to"?).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 455560] Window List applet's text label should be optional

2022-06-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=455560

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|RESOLVED
   Keywords||regression
 Resolution|--- |INTENTIONAL

--- Comment #1 from Nate Graham  ---
I understand that the variable length based on window title can become
annoying, but a list of windows (per the widget's name) pretty much has to
display the window title. If it only displays the icon, it's not a list
anymore, and furthermore, only showing icons would leave you unable to visually
distinguish between windows that have the same icon, as when you open multiple
windows of an app. If we capped the length, then it would elide long text at a
certain point and that would be annoying too.

So I don't think we can go back to the way we had it before, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.