[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 Fushan Wen changed: What|Removed |Added Version Fixed In|5.26|5.24.7 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 Fushan Wen changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/ |d6d47393bab32dc60b43e0eeac1 |ac6f1c858e1e6fa1f0a97f52769 |6c035000a0358 |585d38ea098f3 --- Comment #11 from Fushan Wen --- Git commit ac6f1c858e1e6fa1f0a97f52769585d38ea098f3 by Fushan Wen, on behalf of Eugene Popov. Committed on 24/07/2022 at 00:19. Pushed by fusionfuture into branch 'Plasma/5.24'. [FIX] Unable to remove manually added wallpaper It's not necessary to assign m_removableWallpapers asynchronously, because the value assigned to it doesn't depend on the result of that asynch function. !!! This MR is for the Plasma/5.25 branch only and it SHOULD NOT be cherry-picket into the master branch. (cherry picked from commit d6d47393bab32dc60b43e0eeac16c035000a0358) M +2-1wallpapers/image/backgroundlistmodel.cpp https://invent.kde.org/plasma/plasma-workspace/commit/ac6f1c858e1e6fa1f0a97f52769585d38ea098f3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 Fushan Wen changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/commit/ ||d6d47393bab32dc60b43e0eeac1 ||6c035000a0358 --- Comment #10 from Fushan Wen --- Git commit d6d47393bab32dc60b43e0eeac16c035000a0358 by Fushan Wen, on behalf of Eugene Popov. Committed on 24/07/2022 at 00:18. Pushed by fusionfuture into branch 'Plasma/5.25'. [FIX] Unable to remove manually added wallpaper It's not necessary to assign m_removableWallpapers asynchronously, because the value assigned to it doesn't depend on the result of that asynch function. !!! This MR is for the Plasma/5.25 branch only and it SHOULD NOT be cherry-picket into the master branch. M +2-1wallpapers/image/plugin/backgroundlistmodel.cpp https://invent.kde.org/plasma/plasma-workspace/commit/d6d47393bab32dc60b43e0eeac16c035000a0358 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #9 from Nate Graham --- The big refactor for Plasma 5.26 can't really be backported. It's just too much. Please don't re-open issues that have been marked as FIXED unless you have new information indicating that the issue is not actually fixed in the version it is marked as fixed in. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 popov895 changed: What|Removed |Added Resolution|FIXED |--- CC||popov...@ukr.net Status|RESOLVED|REOPENED Ever confirmed|0 |1 --- Comment #8 from popov895 --- Hmm, what about Plasma 5.25? Plasma 5.26 will only be released in three months. P.S. I cannot reproduce this issue on openSUSE Tumbleweed. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 Nate Graham changed: What|Removed |Added CC||n...@kde.org Version Fixed In||5.26 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Nate Graham --- I can also not reproduce with current git master. Feel free to re-open if it still happens in Plasma 5.26. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 --- Comment #6 from Yaroslav Sidlovsky --- (In reply to Fushan Wen from comment #5) > I suspect the config is not read if it does not exist before adding a custom > wallpaper. I can reproduce this bug even when plasmarc already exists on my home PC running Fedora. > But I can't reproduce on Plasma 5.26 as the wallpaper plugin has been > refactored greatly. Then let's wait for version 5.26 :) Thanks! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 --- Comment #5 from Fushan Wen --- I suspect the config is not read if it does not exist before adding a custom wallpaper. But I can't reproduce on Plasma 5.26 as the wallpaper plugin has been refactored greatly. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 --- Comment #4 from Yaroslav Sidlovsky --- (In reply to Fushan Wen from comment #1) > I don't remember the bug exists in 5.24 and the code is not changed in > 5.25. Can you post ~/.config/plasmarc before and after the custom > wallpaper is added? plasmarc doesn't exists before wallpaper was added, and after new wallpaper has been added it contains: ``` [Wallpapers] usersWallpapers=/home/neon/Pictures/wallhaven-j3g7yy.jpg ``` -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 --- Comment #3 from Yaroslav Sidlovsky --- (In reply to Fushan Wen from comment #1) > I don't remember the bug exists in 5.24 and the code is not changed in > 5.25. Can you post ~/.config/plasmarc before and after the custom > wallpaper is added? Wait a sec. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 --- Comment #2 from Yaroslav Sidlovsky --- P.S. If I save wallpaper image into `~/.local/share/wallpapers/` - image will be always removable. See this line: https://invent.kde.org/plasma/plasma-workspace/-/blob/0f01d289befec6b3cc0135bb6bc2fa31cf52f00d/wallpapers/image/plugin/model/imagelistmodel.cpp#L97. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 457019] Can't remove manually added wallpaper
https://bugs.kde.org/show_bug.cgi?id=457019 --- Comment #1 from Fushan Wen --- I don't remember the bug exists in 5.24 and the code is not changed in 5.25. Can you post ~/.config/plasmarc before and after the custom wallpaper is added? -- You are receiving this mail because: You are watching all bug changes.
