[plasmashell] [Bug 457077] Favorites item uses a monochrome icon, whereas everything else uses a colorful icon

2023-09-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=457077

--- Comment #3 from Nate Graham  ---
We'd need a colorful version of this icon. There is `folder-favorites` but that
looks like a folder and doesn't quite seem appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 457077] Favorites item uses a monochrome icon, whereas everything else uses a colorful icon

2022-07-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=457077

Nate Graham  changed:

   What|Removed |Added

 CC||m...@nueljl.in

--- Comment #2 from Nate Graham  ---
So there are a few problems here:
* in plasma-workspace/applets/kicker/plugin/rootmodel.cpp, we use the
`bookmarks` icon which is not semantically correct, as a bookmark is something
different from a favorited item.
* If we switched to using either of the more semantically correct `favorite` or
`favorites` icon, those icons in the Breeze icon theme are also monochrome at
their small sizes

I see two ways we could proceed here:
1. Change the `bookmarks` icon in the Plasma theme to look like a colorful star
2. Change the icon used to `applications-favorites` and create that icon in the
Breeze icon theme, ensuring there's a colorful version for both the 22px and
32px sizes.

Noah and Manuel, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 457077] Favorites item uses a monochrome icon, whereas everything else uses a colorful icon

2022-07-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=457077

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
   Severity|normal  |minor
Summary|Replace monochrome icons|Favorites item uses a
   |with colored icons for  |monochrome icon, whereas
   |Favorites and Help items|everything else uses a
   ||colorful icon

--- Comment #1 from Nate Graham  ---
The help icon has already been fixed in
https://invent.kde.org/frameworks/breeze-icons/-/commit/acc75ff7762d7de0bd6489abc821dba506c2a43b.
Let's use this bug report to track fixing the Favorites icon.

-- 
You are receiving this mail because:
You are watching all bug changes.