[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2023-02-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=462097

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #8 from Nate Graham  ---
Note that the fix here was to make icons smaller when using the "Large"
spacing, as the real bug was that they were too big when using "Large" spacing
and a 38px panel. If you want icons to be bigger, make the panel 40px.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2023-02-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=462097

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-desktop/commit/0e |ma/plasma-desktop/commit/2b
   |d0ae8a90e44f34d67495e650d52 |03cd33ea7e9149b995985a5e029
   |0965352c21c |552ace5a7db

--- Comment #7 from Nate Graham  ---
Git commit 2b03cd33ea7e9149b995985a5e029552ace5a7db by Nate Graham, on behalf
of Niccolò Venerandi.
Committed on 01/02/2023 at 15:59.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/taskmanager: Fix icon size when spacing is set to large

By applying the 3x margins on "large" spacing to both horizontal and vertical
margins,
we're also compressing the icon to be too small by triggering a condition in
the
minimum size check. With this commit, switching to "large" while the panel is
at 38px
shouldn't change the size of the icon anymore.
FIXED-IN: 5.27


(cherry picked from commit 0ed0ae8a90e44f34d67495e650d520965352c21c)

M  +2-2applets/taskmanager/package/contents/ui/code/layout.js

https://invent.kde.org/plasma/plasma-desktop/commit/2b03cd33ea7e9149b995985a5e029552ace5a7db

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2023-02-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=462097

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.27
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/commit/0e
   ||d0ae8a90e44f34d67495e650d52
   ||0965352c21c
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Nate Graham  ---
Git commit 0ed0ae8a90e44f34d67495e650d520965352c21c by Nate Graham, on behalf
of Niccolò Venerandi.
Committed on 01/02/2023 at 15:59.
Pushed by ngraham into branch 'master'.

applets/taskmanager: Fix icon size when spacing is set to large

By applying the 3x margins on "large" spacing to both horizontal and vertical
margins,
we're also compressing the icon to be too small by triggering a condition in
the
minimum size check. With this commit, switching to "large" while the panel is
at 38px
shouldn't change the size of the icon anymore.
FIXED-IN: 5.27

M  +2-2applets/taskmanager/package/contents/ui/code/layout.js

https://invent.kde.org/plasma/plasma-desktop/commit/0ed0ae8a90e44f34d67495e650d520965352c21c

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2023-01-27 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=462097

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1362

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2022-12-29 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=462097

Fushan Wen  changed:

   What|Removed |Added

   Keywords|regression  |
 CC||qydwhotm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2022-11-22 Thread subhuman2222
https://bugs.kde.org/show_bug.cgi?id=462097

--- Comment #4 from subhuman  ---
(In reply to veggero from comment #3)
> I'm afraid the bug is 2, not 1.  Sorry

well i just hope it will look like it looked all these years

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2022-11-22 Thread veggero
https://bugs.kde.org/show_bug.cgi?id=462097

--- Comment #3 from veggero  ---
I'm afraid the bug is 2, not 1.  Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2022-11-21 Thread subhuman2222
https://bugs.kde.org/show_bug.cgi?id=462097

--- Comment #2 from subhuman  ---
(In reply to Nate Graham from comment #1)
> Can confirm.
> 
> Not sure what the true bug is here, though:
> 1. The fact that the icons *don't* switch to the next largest size with a
> 38px oanel
> 2. The fact that the icons *do* switch to the next largest size at 38px
> panel when you're using the large spacing setting
> 
> Definitely at least one of those should be fixed.

well, the icons did switch to the next largest size before, so (i wish) number
1 should be fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2022-11-21 Thread veggero
https://bugs.kde.org/show_bug.cgi?id=462097

veggero  changed:

   What|Removed |Added

 CC||niccolo.venera...@gmail.com
   Assignee|plasma-b...@kde.org |niccolo.venera...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 462097] Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings

2022-11-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=462097

Nate Graham  changed:

   What|Removed |Added

Summary|Taskbar icons weird size at |Task Manager icons are too
   |38 height   |small with a 38px panel,
   ||but only when using the
   ||Small or Normal spacing
   ||settings
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.