[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-04-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #28 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/qt/qt/qtdeclarative/-/merge_requests/40

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-03-18 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #27 from Fushan Wen  ---
Git commit b23951ee1b37bd781c6b64105e28b411c9c488f8 by Fushan Wen.
Committed on 18/03/2023 at 10:46.
Pushed by fusionfuture into branch 'master'.

klipper: test bug 465225


(cherry picked from commit 5b0563362494ab5717655f054ccd2627ad3d51e2)

M  +5-0klipper/autotests/CMakeLists.txt
A  +---klipper/autotests/data/bug465225.lst
A  +102  -0klipper/autotests/klippertest.cpp [License: GPL(v2.0+)]

https://invent.kde.org/plasma/plasma-workspace/commit/b23951ee1b37bd781c6b64105e28b411c9c488f8

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-03-18 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #26 from Fushan Wen  ---
Git commit 5b0563362494ab5717655f054ccd2627ad3d51e2 by Fushan Wen.
Committed on 18/03/2023 at 08:40.
Pushed by fusionfuture into branch 'Plasma/5.27'.

klipper: test bug 465225

M  +5-0klipper/autotests/CMakeLists.txt
A  +---klipper/autotests/data/bug465225.lst
A  +102  -0klipper/autotests/klippertest.cpp [License: GPL(v2.0+)]

https://invent.kde.org/plasma/plasma-workspace/commit/5b0563362494ab5717655f054ccd2627ad3d51e2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-03-14 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #25 from Fushan Wen  ---
Git commit b34c60956fe858f123dcdde7ee6322b986a795f6 by Fushan Wen.
Committed on 14/03/2023 at 13:44.
Pushed by fusionfuture into branch 'Plasma/5.27'.

klipper: remove duplicate items when loading from history

Due to a catastrophic bug existing in 5.27 beta and 5.27.0, there could
be duplicate items in klipper's history file, so filter them out here.

The popup menu will try to read `item->next_uuid()` in a loop to fill the menu,
hence it's possible to create an infinite loop when there are duplicate items.
Related: bug 466236
FIXED-IN: 5.27.4

M  +9-0klipper/klipper.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/b34c60956fe858f123dcdde7ee6322b986a795f6

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-03-10 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #24 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2731

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-03-10 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #23 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2730

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-15 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

 CC||laubblae...@live.com

--- Comment #22 from Fushan Wen  ---
*** Bug 465724 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-14 Thread Oded Arbel
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #21 from Oded Arbel  ---
(In reply to Oded Arbel from comment #19)
> I have to note that with the current setup, after the update, while
> previously clipboard management was part of the plasmashell process, it is
> no longer accessible

OK, NM that - my setup was messed up after building and installing a
plasma-workspace copy into ~/.local, the cmake uninstall process leaves empty
directories wherever it installed something, then when the system's plasmashell
loads it sees directories for bundled applets under
.local/share/plasma/plasmoids/ and tries to load the applets from there - but
there are no actual implementations installed so it just fails silently.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #20 from Nate Graham  ---
Makes sense given the changes that were merged recently!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-14 Thread Oded Arbel
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #19 from Oded Arbel  ---
After updating to current unstable, I can no longer reproduce this issue.

I have to note that with the current setup, after the update, while previously
clipboard management was part of the plasmashell process, it is no longer
accessible: the org.kde.klipper DBus service is not available when starting
plasma. I can run the /usr/bin/klipper program, which gives me access to the
org.kde.klipper DBus service and with which I can fail to repro the problem -
but it doesn't have my previous clipboard manager non-default shortcut
configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465225

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.27.1  |5.27

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #18 from Fushan Wen  ---
Git commit 365bd94bc6b4de910249f566b01a22bacfb55353 by Fushan Wen.
Committed on 13/02/2023 at 16:34.
Pushed by fusionfuture into branch 'master'.

klipper: lock mutex before `indexOf` in `insert`
Related: bug 465326

M  +2-1klipper/historymodel.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/365bd94bc6b4de910249f566b01a22bacfb55353

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

 CC||td21rz...@mozmail.com

--- Comment #17 from Fushan Wen  ---
*** Bug 465603 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #16 from Fushan Wen  ---
*** Bug 464828 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

 CC||o...@geek.co.il

--- Comment #15 from Fushan Wen  ---
*** Bug 465326 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-13 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

   Version Fixed In|5.27|5.27.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-12 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |41ac399c39a653cac1d63b3f191 |89d1f0e07955427a083cbc5af34
   |3ed4eb2f0d2c3   |e0ae9fdcdaad4

--- Comment #14 from Fushan Wen  ---
Git commit 89d1f0e07955427a083cbc5af34e0ae9fdcdaad4 by Fushan Wen.
Committed on 13/02/2023 at 00:46.
Pushed by fusionfuture into branch 'Plasma/5.27'.

klipper: store QImage and construct QPixmap only when necessary

The mime data from Wayland clipboard is not the exact same image, so two
image items are listed (first time restarting plasmashell). But after
images are saved to local, they have the same uuid again. So klipper
starts to become confused after the second time restarting plasmashell.

This is caused by QPixmap::from(QImage).toImage() erasing metadata in the
image, and Wayland clipboard is async, so another identical image is added
to clipboard.
Related: bug 465326, bug 464828, bug 465603
FIXED-IN: 5.27


(cherry picked from commit 4649594aa95d601ac6449c9e8baf8201b28602c5)

M  +5-5klipper/historyimageitem.cpp
M  +2-2klipper/historyimageitem.h
M  +3-4klipper/historyitem.h

https://invent.kde.org/plasma/plasma-workspace/commit/89d1f0e07955427a083cbc5af34e0ae9fdcdaad4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-12 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
   |4649594aa95d601ac6449c9e8ba |41ac399c39a653cac1d63b3f191
   |f8201b28602c5   |3ed4eb2f0d2c3

--- Comment #13 from Fushan Wen  ---
Git commit 41ac399c39a653cac1d63b3f1913ed4eb2f0d2c3 by Fushan Wen.
Committed on 13/02/2023 at 00:29.
Pushed by fusionfuture into branch 'cherry-pick-4649594a'.

klipper: store QImage and construct QPixmap only when necessary

The mime data from Wayland clipboard is not the exact same image, so two
image items are listed (first time restarting plasmashell). But after
images are saved to local, they have the same uuid again. So klipper
starts to become confused after the second time restarting plasmashell.

This is caused by QPixmap::from(QImage).toImage() erasing metadata in the
image, and KSystemClipboard will emit changed signal on Wayland, so
another identical image is added to clipboard.
Related: bug 465326, bug 464828, bug 465603
FIXED-IN: 5.27


(cherry picked from commit 4649594aa95d601ac6449c9e8baf8201b28602c5)

M  +5-5klipper/historyimageitem.cpp
M  +2-2klipper/historyimageitem.h
M  +3-4klipper/historyitem.h

https://invent.kde.org/plasma/plasma-workspace/commit/41ac399c39a653cac1d63b3f1913ed4eb2f0d2c3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-12 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||4649594aa95d601ac6449c9e8ba
   ||f8201b28602c5
   Version Fixed In||5.27
 Resolution|--- |FIXED

--- Comment #12 from Fushan Wen  ---
Git commit 4649594aa95d601ac6449c9e8baf8201b28602c5 by Fushan Wen.
Committed on 12/02/2023 at 15:38.
Pushed by fusionfuture into branch 'master'.

klipper: store QImage and construct QPixmap only when necessary

The mime data from Wayland clipboard is not the exact same image, so two
image items are listed (first time restarting plasmashell). But after
images are saved to local, they have the same uuid again. So klipper
starts to become confused after the second time restarting plasmashell.

This is caused by QPixmap::from(QImage).toImage() erasing metadata in the
image, and KSystemClipboard will emit changed signal on Wayland, so
another identical image is added to clipboard.
Related: bug 465326, bug 464828, bug 465603
FIXED-IN: 5.27

M  +5-5klipper/historyimageitem.cpp
M  +2-2klipper/historyimageitem.h
M  +3-4klipper/historyitem.h

https://invent.kde.org/plasma/plasma-workspace/commit/4649594aa95d601ac6449c9e8baf8201b28602c5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-12 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2612

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465225

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-11 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2609

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-11 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=465603

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-11 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |ASSIGNED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #9 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2608

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-10 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=464828

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-10 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=465326

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-10 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2607

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-10 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #7 from Fushan Wen  ---
Thanks. Marked as WAITINGFORINFO to remind later.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-08 Thread Pawel
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #6 from Pawel  ---
OK, I have since cleared the clipboard history and haven't had the crash since.
I will monitor for the next week or so and report back.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-07 Thread Pawel
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #5 from Pawel  ---
by clipboard I mean clipboard history in the tray widget.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-07 Thread Pawel
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #4 from Pawel  ---
I can repro consistently now. I will record a video to show when the hang and
crash happens but it's related to the clipboard.

I use a pdf file I have on my desktop. I copy it and inspect the clipboard - it
will either show in the clipboard and the desktop continues operating normally
or the session freezes for a few minutes before it crashes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-07 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #3 from David Redondo  ---
I don't think the thread with clipboard crashed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-07 Thread Pawel
https://bugs.kde.org/show_bug.cgi?id=465225

--- Comment #2 from Pawel  ---
(In reply to Fushan Wen from comment #1)
> Have you updated all packages?

yes, I am pretty sure I have. Which one do you think might be outdated?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-06 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=465225

Fushan Wen  changed:

   What|Removed |Added

 CC||qydwhotm...@gmail.com

--- Comment #1 from Fushan Wen  ---
Have you updated all packages?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 465225] plasmashell crashed in Klipper::saveClipboardHistory() and failed to recover

2023-02-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465225

Nate Graham  changed:

   What|Removed |Added

 CC||k...@david-redondo.de,
   ||n...@kde.org
Summary|plasma shell cash and blank |plasmashell crashed in
   |screen  |Klipper::saveClipboardHisto
   ||ry() and failed to recover
  Component|general |Clipboard

-- 
You are receiving this mail because:
You are watching all bug changes.