[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2024-04-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=472378

Nate Graham  changed:

   What|Removed |Added

 CC||francoisdp...@gmail.com

--- Comment #7 from Nate Graham  ---
*** Bug 460327 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2024-04-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=472378

Nate Graham  changed:

   What|Removed |Added

 CC||paulstans...@gmail.com

--- Comment #6 from Nate Graham  ---
*** Bug 483917 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2024-04-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=472378

Nate Graham  changed:

   What|Removed |Added

 CC||zurielsot...@gmail.com

--- Comment #5 from Nate Graham  ---
*** Bug 412822 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2023-07-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=472378

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.27.7
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2023-07-24 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=472378

Fushan Wen  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
   |t/9d9f80149096a04d34cbfdd43 |t/6309a138092016b05bee00c76
   |10d15e279f32bc3 |401a199324c8c71

--- Comment #4 from Fushan Wen  ---
Git commit 6309a138092016b05bee00c76401a199324c8c71 by Fushan Wen, on behalf of
Will Horne.
Committed on 25/07/2023 at 08:54.
Pushed by fusionfuture into branch 'master'.

Fix crash in LauncherTasksModel::Private::requestRemoveLauncherFromActivities

Change the 'launcher' variable from a reference to an
implicit shared copy to avoid a use-after-free error

Add a regression test to launchertasksmodeltest.cpp


(cherry picked from commit 9d9f80149096a04d34cbfdd4310d15e279f32bc3)

M  +29   -0libtaskmanager/autotests/launchertasksmodeltest.cpp
M  +1-1libtaskmanager/launchertasksmodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/6309a138092016b05bee00c76401a199324c8c71

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2023-07-24 Thread Will
https://bugs.kde.org/show_bug.cgi?id=472378

Will  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/-/commi
   ||t/9d9f80149096a04d34cbfdd43
   ||10d15e279f32bc3
 Resolution|--- |FIXED

--- Comment #3 from Will  ---
Git commit 9d9f80149096a04d34cbfdd4310d15e279f32bc3 by Will Horne.
Committed on 25/07/2023 at 08:17.
Pushed by fusionfuture into branch 'Plasma/5.27'.

Fix crash in LauncherTasksModel::Private::requestRemoveLauncherFromActivities

Change the 'launcher' variable from a reference to an
implicit shared copy to avoid a use-after-free error

Add a regression test to launchertasksmodeltest.cpp

M  +29   -0libtaskmanager/autotests/launchertasksmodeltest.cpp
M  +1-1libtaskmanager/launchertasksmodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/9d9f80149096a04d34cbfdd4310d15e279f32bc3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2023-07-24 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=472378

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3105

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2023-07-24 Thread Will
https://bugs.kde.org/show_bug.cgi?id=472378

Will  changed:

   What|Removed |Added

   Assignee|plasma-b...@kde.org |tcosproje...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Will  ---
I've created a test case to reliably reproduce this issue and am preparing a
merge request with the fix

As a launcher is removed by url, the ref count decreases until it is
deallocated, but the url can be used after free when attempting a remove from
appCacheData. 

The issue occurs at launchertasksmodel.cpp:257

launchersOrder.removeAt(row); // Removes one reference, this is the same as
'launcher'
activitiesForLauncher.remove(url); // Can remove last reference if url ==
launcher and it is not present in appDataCache
appDataCache.remove(launcher); // Uses free'd launcher and crashes

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 472378] Plasma Shell crash when unpinning taskbar shortcut

2023-07-21 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=472378

Fushan Wen  changed:

   What|Removed |Added

 CC||qydwhotm...@gmail.com
  Component|general |Task Manager and Icons-Only
   ||Task Manager

-- 
You are receiving this mail because:
You are watching all bug changes.