[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 --- Comment #9 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3899 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 --- Comment #10 from Nate Graham --- Git commit 8fa333fbac71c6e6068173198f8ccd92d2ba6df9 by Nate Graham. Committed on 14/02/2024 at 15:03. Pushed by ngraham into branch 'master'. Revert "lookandfeel: Explicitely set isMask of ActionButton" This reverts commit 2d46de674ced4062c53799772339ad152ffcbc69. This change made sense to fix bug 474377 back when these icons came from the Plasma style. However subsequently that feature was removed. As a result, icons from the desktop icon theme are now shown here, and we can't guarantee their visual style. As such, forcing them to be a mask is now incorrect and obliterates the icon if it's using the full-color style. Related: bug 477995 FIXED-IN: 6.0 M +0-1lookandfeel/components/ActionButton.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/8fa333fbac71c6e6068173198f8ccd92d2ba6df9 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 --- Comment #11 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3904 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 --- Comment #12 from Nate Graham --- Git commit e442160ea44c4aff05b53228e045a43f16907201 by Nate Graham. Committed on 14/02/2024 at 15:38. Pushed by ngraham into branch 'Plasma/6.0'. Revert "lookandfeel: Explicitely set isMask of ActionButton" This reverts commit 2d46de674ced4062c53799772339ad152ffcbc69. This change made sense to fix bug 474377 back when these icons came from the Plasma style. However subsequently that feature was removed. As a result, icons from the desktop icon theme are now shown here, and we can't guarantee their visual style. As such, forcing them to be a mask is now incorrect and obliterates the icon if it's using the full-color style. Related: bug 477995 FIXED-IN: 6.0 (cherry picked from commit 8fa333fbac71c6e6068173198f8ccd92d2ba6df9) M +0-1lookandfeel/components/ActionButton.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/e442160ea44c4aff05b53228e045a43f16907201 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 Nate Graham changed: What|Removed |Added Target Milestone|--- |1.0 Product|Breeze |plasmashell Component|general |Theme - Breeze CC||visual-des...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 David Redondo changed: What|Removed |Added CC||k...@david-redondo.de --- Comment #2 from David Redondo --- It's only sddm, looks correct in kscreenlocker -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 David Redondo changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 --- Comment #3 from David Redondo --- This is because the greeter does not use the org.kde.desktop style and does not get the corresponding Kirigami theme plugin, and as such has only Kirigami BasicTheme and not recolorable icons. Forcing desktop style via sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/ --style org.kde.desktop has the icons colored correctly. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3281 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 David Redondo changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/-/commi ||t/2d46de674ced4062c53799772 ||339ad152ffcbc69 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #5 from David Redondo --- Git commit 2d46de674ced4062c53799772339ad152ffcbc69 by David Redondo. Committed on 13/09/2023 at 08:41. Pushed by davidre into branch 'master'. lookandfeel: Explicitely set isMask of ActionButton The sddm greeter is not using desktop style and consequently the dekstop style Kirigami Theme but the default basic theme. BasicTheme does not support recoloring of icons, however we can force recoloring by setting isMask to true. M +1-0lookandfeel/org.kde.breeze/contents/components/ActionButton.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/2d46de674ced4062c53799772339ad152ffcbc69 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 --- Comment #6 from Patrick Silva --- Battery and virtual keyboard icons are still buggy after this fix. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 David Redondo changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #7 from David Redondo --- I didn't notice these at all! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 David Redondo changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi |t/2d46de674ced4062c53799772 |t/10d58e309fac21f19b0fd5ce1 |339ad152ffcbc69 |6f8aaa445143ec6 --- Comment #8 from David Redondo --- Git commit 10d58e309fac21f19b0fd5ce16f8aaa445143ec6 by David Redondo. Committed on 07/11/2023 at 09:08. Pushed by davidre into branch 'master'. Enforce Plasma Kirigami Them when importing Breeze lnf components This gives us the hook to have icon recoloring in the sddm theme. M +3-2lookandfeel/CMakeLists.txt M +1-1lookandfeel/org.kde.breeze/components/UserDelegate.qml M +1-1lookandfeel/org.kde.breeze/components/WallpaperFader.qml A +20 -0lookandfeel/org.kde.breeze/components/componentsplugin.cpp * The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://invent.kde.org/plasma/plasma-workspace/-/commit/10d58e309fac21f19b0fd5ce16f8aaa445143ec6 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 474377] Wrongly colored icons on the login screen
https://bugs.kde.org/show_bug.cgi?id=474377 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=476668 -- You are receiving this mail because: You are watching all bug changes.
