[plasmashell] [Bug 476364] Incorrectly styled font selector
https://bugs.kde.org/show_bug.cgi?id=476364 Roke Julian Lockhart Beedell <4wy78...@rokejulianlockhart.addy.io> changed: What|Removed |Added CC||4wy78uwh@rokejulianlockhart ||.addy.io -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 476364] Incorrectly styled font selector
https://bugs.kde.org/show_bug.cgi?id=476364 Nicolas Fella changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-integration/-/com ||mit/53cfae46b00f7844718bb75 ||c469cfcf6efcb070d Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #5 from Nicolas Fella --- Git commit 53cfae46b00f7844718bb75c469cfcf6efcb070d by Nicolas Fella. Committed on 04/11/2023 at 23:19. Pushed by nicolasfella into branch 'master'. Implement Font dialogs QML FontDialog first queries the platform theme for an implementation. Since we don't provide one we get the default one, which is less than stellar. In Qt5 we would get a widgets-based one that works fine. We can get the Qt5 behavior back by asking for a QFontDialog (and passing DontUseNativeDialog to avoid endless recursion) M +1-0qt6/autotests/CMakeLists.txt M +1-0qt6/src/platformtheme/CMakeLists.txt A +64 -0qt6/src/platformtheme/kdeplatformfontdialoghelper.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.0)] A +32 -0qt6/src/platformtheme/kdeplatformfontdialoghelper.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.0)] M +3-1qt6/src/platformtheme/kdeplatformtheme.cpp https://invent.kde.org/plasma/plasma-integration/-/commit/53cfae46b00f7844718bb75c469cfcf6efcb070d -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 476364] Incorrectly styled font selector
https://bugs.kde.org/show_bug.cgi?id=476364 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-integration/-/merge_requests/115 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 476364] Incorrectly styled font selector
https://bugs.kde.org/show_bug.cgi?id=476364 --- Comment #3 from Nate Graham --- Ah right, and in Qt 6, the QML one no longer falls back to the Widgets one, right? Do we need to style it ourselves in plasma-integration or something? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 476364] Incorrectly styled font selector
https://bugs.kde.org/show_bug.cgi?id=476364 --- Comment #2 from Nicolas Fella --- (In reply to Nate Graham from comment #1) > Can reproduce. It's quite horrible now. We must be doing something wrong in > the Digital Clock code, as it works correctly in the Fonts KCM. Nothing wrong per se. The difference is that the clock code uses the QML font dialog, which has this horrible default implementation. The KCM uses KFontChooserDialog, which is widgets-based -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 476364] Incorrectly styled font selector
https://bugs.kde.org/show_bug.cgi?id=476364 Nate Graham changed: What|Removed |Added CC||k...@privat.broulik.de, ||n...@kde.org, ||nicolas.fe...@gmx.de Component|general |Digital Clock Ever confirmed|0 |1 Target Milestone|--- |1.0 Status|REPORTED|CONFIRMED Assignee|unassigned-b...@kde.org |plasma-b...@kde.org Version|unspecified |master Product|kde |plasmashell --- Comment #1 from Nate Graham --- Can reproduce. It's quite horrible now. We must be doing something wrong in the Digital Clock code, as it works correctly in the Fonts KCM. -- You are receiving this mail because: You are watching all bug changes.
