[plasmashell] [Bug 476719] "Add to Favorites" menu item missing in context menu of search result delegates

2023-11-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=476719

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/-/commi
   ||t/6b499a743cadc0bae97509a97
   ||cf4aaef69cced82

--- Comment #5 from Nate Graham  ---
Git commit 6b499a743cadc0bae97509a97cf4aaef69cced82 by Nate Graham, on behalf
of Kai Uwe Broulik.
Committed on 30/11/2023 at 17:16.
Pushed by ngraham into branch 'master'.

kicker: Forward favoritesModel to RunnerMatchesModel

Kickoff uses the model's favoritesModel in the delegate to add/remove
favorites. RunnerModel has it but the individual RunnerMatchesModel
it displays did not, breaking the favorites functionality in
Kickoff's search.

M  +13   -0applets/kicker/plugin/runnermatchesmodel.cpp
M  +9-0applets/kicker/plugin/runnermatchesmodel.h
M  +8-1applets/kicker/plugin/runnermodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/6b499a743cadc0bae97509a97cf4aaef69cced82

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 476719] "Add to Favorites" menu item missing in context menu of search result delegates

2023-11-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=476719

--- Comment #4 from Nate Graham  ---
Git commit f295d43d4af47d89ebf1a74c06bf74405f6ae428 by Nate Graham, on behalf
of Bharadwaj Raju.
Committed on 30/11/2023 at 16:58.
Pushed by ngraham into branch 'master'.

applets/kicker: Handle `undefined` values of favoritesModel/favoriteId
correctly

Prevents spurious "Add to Favorites" items from showing up in the context menus
of things that can't actually be favorited.

To be applied with
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3559.

M  +1-1applets/kicker/package/contents/ui/code/tools.js

https://invent.kde.org/plasma/plasma-desktop/-/commit/f295d43d4af47d89ebf1a74c06bf74405f6ae428

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 476719] "Add to Favorites" menu item missing in context menu of search result delegates

2023-11-21 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=476719

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1859

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 476719] "Add to Favorites" menu item missing in context menu of search result delegates

2023-11-21 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=476719

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3579

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 476719] "Add to Favorites" menu item missing in context menu of search result delegates

2023-11-20 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=476719

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 476719] "Add to Favorites" menu item missing in context menu of search result delegates

2023-11-20 Thread Andreas G
https://bugs.kde.org/show_bug.cgi?id=476719

Andreas G  changed:

   What|Removed |Added

 CC||uri...@posteo.de

--- Comment #1 from Andreas G  ---
*** Bug 477300 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.