[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-27 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #23 from Nicolas Fella  ---
The breeze icons for printer and power management look correct here.

This looks like the third-party icon theme is not using the right color roles
for some icons. Please report this to the theme author.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-26 Thread Patrick Van Rinsvelt
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #22 from Patrick Van Rinsvelt  ---
Created attachment 167830
  --> https://bugs.kde.org/attachment.cgi?id=167830=edit
Icons in System Tray look OK but a couple of them are very dim

As mentioned in ticket comment

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-26 Thread Patrick Van Rinsvelt
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #21 from Patrick Van Rinsvelt  ---
Not sure if you want feedback from a user but here it is. I package update
every day and have been seeing the icons in the system tray and expanded tray
all displaying properly now and for the past few days. This is using the
Breeze, Breeze Dark as well as contributor icons as well. The only thing I
would comment on is that the Printer and Weather icons in the system tray are
pretty dim.

See attachment userSystemTraySnapshot_20240327

Let me know if I should not be commenting here

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #20 from Nicolas Fella  ---
Git commit d73c6c4bb938bbd252c5bd69cc93862cba554e32 by Nicolas Fella.
Committed on 11/03/2024 at 17:06.
Pushed by nicolasfella into branch 'Plasma/6.0'.

[applets/systemtray] Load icons with Plasma palette

When using Breeze Twilight, i.e. dark Plasma and lights apps, we need to color
the icons with the Plasma colors

To achieve this always set the current palette on the icon loader, which means
always creating a custom loader

For the icons in the context menu we want the application palette, so create a
separate loader for that
Related: bug 482645

M  +56   -24   applets/systemtray/statusnotifieritemsource.cpp
M  +2-0applets/systemtray/statusnotifieritemsource.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/d73c6c4bb938bbd252c5bd69cc93862cba554e32

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #19 from Nicolas Fella  ---
Git commit 257ccabc526ab7f4d5ca12758c1e29af35b048ca by Nicolas Fella.
Committed on 11/03/2024 at 17:01.
Pushed by nicolasfella into branch 'master'.

[applets/systemtray] Load icons with Plasma palette

When using Breeze Twilight, i.e. dark Plasma and lights apps, we need to color
the icons with the Plasma colors
Related: bug 482645

M  +24   -6applets/systemtray/statusnotifieritemsource.cpp
M  +1-0applets/systemtray/statusnotifieritemsource.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/257ccabc526ab7f4d5ca12758c1e29af35b048ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-11 Thread Mufeed Ali
https://bugs.kde.org/show_bug.cgi?id=479712

Mufeed Ali  changed:

   What|Removed |Added

 CC|kdebugs.undead@kumo.contact |

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-10 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #18 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4039

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-10 Thread Matthias
https://bugs.kde.org/show_bug.cgi?id=479712

Matthias  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Matthias  ---
Sorry, we failed. That issue here is indeed solved and we encountered an
independent problem in Qbittorrent. Closing

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-10 Thread Nicolas
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas  changed:

   What|Removed |Added

 CC||nico...@hoeft.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-10 Thread Matthias
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #16 from Matthias  ---
Created attachment 166894
  --> https://bugs.kde.org/attachment.cgi?id=166894=edit
missing icon in 6.0.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-10 Thread Matthias
https://bugs.kde.org/show_bug.cgi?id=479712

Matthias  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 CC||shaloksha...@protonmail.ch

--- Comment #15 from Matthias  ---
At least two people on 6.0.1 confirm that this bug is still active. 
Tested with QBittorrent. 

NixOS and Arch Linux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-10 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas Fella  changed:

   What|Removed |Added

 CC||mmboss...@gmail.com

--- Comment #14 from Nicolas Fella  ---
*** Bug 483049 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-09 Thread Arka Bhuiyan
https://bugs.kde.org/show_bug.cgi?id=479712

Arka Bhuiyan  changed:

   What|Removed |Added

 CC||arkabhuiyancs...@gmail.com

--- Comment #13 from Arka Bhuiyan  ---
I am using Nobara Linux and the plasma version is 6.0.1. Unfortunately, I am
seeing the fix yet. Is there something we need to do to fix the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-09 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas Fella  changed:

   What|Removed |Added

 CC||paul...@gmail.com

--- Comment #12 from Nicolas Fella  ---
*** Bug 482962 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-09 Thread firewalker
https://bugs.kde.org/show_bug.cgi?id=479712

firewalker  changed:

   What|Removed |Added

 CC||firew4l...@gmail.com

--- Comment #11 from firewalker  ---
I have also noticed missing icons (oxygen theme) in the tray. No Bluetooth,
Notifications, Vault, Brightness and Color icons. Those icons seems to be
missing from everywhere (eg System Settings). Is it the same bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=479712

monsoon...@gmail.com changed:

   What|Removed |Added

 CC||monsoon...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-07 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas Fella  changed:

   What|Removed |Added

 CC||anon.imm...@gmail.com

--- Comment #10 from Nicolas Fella  ---
*** Bug 482610 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-06 Thread serfreeman1337
https://bugs.kde.org/show_bug.cgi?id=479712

serfreeman1337  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=482645

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-06 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas Fella  changed:

   What|Removed |Added

 CC||valaqua...@gmail.com

--- Comment #9 from Nicolas Fella  ---
*** Bug 482522 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-05 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4004

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479712

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
   |t/a713f2351ad7f9ea3b43d2ec4 |t/976575921d2a1bbd2551afba3
   |36ff1f20d6c036a |35be08ebf0f2a25

--- Comment #7 from Nate Graham  ---
Git commit 976575921d2a1bbd2551afba335be08ebf0f2a25 by Nate Graham, on behalf
of Nicolas Fella.
Committed on 04/03/2024 at 23:39.
Pushed by ngraham into branch 'Plasma/6.0'.

applets/systemtray: Prefer Icon over IconName

The systemtray has a custom KIconLoader in order to make the SNI's
IconThemePath work.

When passing an icon name to Kirigami.Icon we skip that. Instead prefer the
Icon role
from the model, which goes through the custom loader

This restores the logic to how it was before
d31b985b6ba3d68b2ac018839864b305b6780574.
FIXED-IN: 6.0.1


(cherry picked from commit a713f2351ad7f9ea3b43d2ec436ff1f20d6c036a)

34efcc14 [applets/systemtray] Prefer Icon over IconName

M  +1-1   
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/976575921d2a1bbd2551afba335be08ebf0f2a25

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Ilya Bizyaev
https://bugs.kde.org/show_bug.cgi?id=479712

--- Comment #6 from Ilya Bizyaev  ---
The commit fixes this issue, but reintroduces coloring problems for monochrome
icons

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479712

Nate Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/-/commi
   ||t/a713f2351ad7f9ea3b43d2ec4
   ||36ff1f20d6c036a
   Version Fixed In||6.0.1
 Resolution|--- |FIXED

--- Comment #5 from Nate Graham  ---
Git commit a713f2351ad7f9ea3b43d2ec436ff1f20d6c036a by Nate Graham, on behalf
of Nicolas Fella.
Committed on 04/03/2024 at 23:34.
Pushed by ngraham into branch 'master'.

applets/systemtray: Prefer Icon over IconName

The systemtray has a custom KIconLoader in order to make the SNI's
IconThemePath work.

When passing an icon name to Kirigami.Icon we skip that. Instead prefer the
Icon role
from the model, which goes through the custom loader

This restores the logic to how it was before
d31b985b6ba3d68b2ac018839864b305b6780574.
FIXED-IN: 6.0.1

M  +1-1   
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/a713f2351ad7f9ea3b43d2ec436ff1f20d6c036a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479712

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479712

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4002

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas Fella  changed:

   What|Removed |Added

 CC||sighun...@gmx.de

--- Comment #3 from Nicolas Fella  ---
*** Bug 481999 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-03-04 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479712

Nicolas Fella  changed:

   What|Removed |Added

 CC||pa...@sizzlesites.com

--- Comment #2 from Nicolas Fella  ---
*** Bug 482201 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-02-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479712

Nate Graham  changed:

   What|Removed |Added

 CC||kdebugs.undead@kumo.contact

--- Comment #1 from Nate Graham  ---
*** Bug 481682 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-02-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479712

Nate Graham  changed:

   What|Removed |Added

 CC||isma...@gmail.com,
   ||n...@kde.org,
   ||nicolas.fe...@gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-02-21 Thread Fushan Wen
https://bugs.kde.org/show_bug.cgi?id=479712

Fushan Wen  changed:

   What|Removed |Added

 CC||qydwhotm...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 479712] Plasma 6's SNI implementation doesn't respect the IconThemePath property

2024-01-12 Thread Ilya Bizyaev
https://bugs.kde.org/show_bug.cgi?id=479712

Ilya Bizyaev  changed:

   What|Removed |Added

   Keywords||qt6, regression

-- 
You are receiving this mail because:
You are watching all bug changes.