[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 Nate Graham changed: What|Removed |Added Keywords||usability Severity|normal |minor Ever confirmed|0 |1 Summary|"Add to Panel (Widget)" is |"Add to Panel (Widget)" is |still shown on the context |still shown on the context |menu for apps in the|menu for apps in the |Favorites view |Favorites view that are ||also pinned to the Task ||Manager Status|REPORTED|CONFIRMED CC||n...@kde.org --- Comment #2 from Nate Graham --- Yeah, can reproduce but only for apps that are also pinned to the Task Manager. This is fairly silly IMO since for these apps there's even less of a reason to add them to the panel as a launcher. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 --- Comment #3 from Nate Graham --- I think the problem is that ContainmentInterface::mayAddLauncher() returns false here since the app is already pinned. What we probably want is a function that returns whether it's *theoretically* possible to pin the app to a Task Manager, not whether it's *currently* possible to do it. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2000 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3819 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 --- Comment #6 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3826 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 Marco Martin changed: What|Removed |Added Version Fixed In||6.0 Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/plasma-desktop/-/commit/ ||709dbb816d39cb0c6fbeb162031 ||d6d6fc14e89ef Resolution|--- |FIXED --- Comment #7 from Marco Martin --- Git commit 709dbb816d39cb0c6fbeb162031d6d6fc14e89ef by Marco Martin. Committed on 26/01/2024 at 16:48. Pushed by mart into branch 'master'. Api to know whether an applet supportslaunchers Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 Depends on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3819 or https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3826 FIXED-IN: 6.0 M +8-0applets/taskmanager/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/709dbb816d39cb0c6fbeb162031d6d6fc14e89ef -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 Marco Martin changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/-/commit/ |ma/plasma-workspace/-/commi |709dbb816d39cb0c6fbeb162031 |t/7405d2c871f31a238036db560 |d6d6fc14e89ef |863be9a664355b0 --- Comment #8 from Marco Martin --- Git commit 7405d2c871f31a238036db560863be9a664355b0 by Marco Martin. Committed on 26/01/2024 at 16:48. Pushed by mart into branch 'master'. Hide pin to taskmanager when already pinned Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 M +5-2applets/kicker/plugin/actionlist.cpp M +39 -3applets/kicker/plugin/containmentinterface.cpp M +2-0applets/kicker/plugin/containmentinterface.h https://invent.kde.org/plasma/plasma-workspace/-/commit/7405d2c871f31a238036db560863be9a664355b0 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 Marco Martin changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi |t/7405d2c871f31a238036db560 |t/8fceb1e8f5fafd6689f6fc569 |863be9a664355b0 |97904cd3c441860 --- Comment #9 from Marco Martin --- Git commit 8fceb1e8f5fafd6689f6fc56997904cd3c441860 by Marco Martin. Committed on 26/01/2024 at 16:55. Pushed by mart into branch 'Plasma/6.0'. Hide pin to taskmanager when already pinned Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 M +5-2applets/kicker/plugin/actionlist.cpp M +39 -3applets/kicker/plugin/containmentinterface.cpp M +2-0applets/kicker/plugin/containmentinterface.h https://invent.kde.org/plasma/plasma-workspace/-/commit/8fceb1e8f5fafd6689f6fc56997904cd3c441860 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 480198] "Add to Panel (Widget)" is still shown on the context menu for apps in the Favorites view that are also pinned to the Task Manager
https://bugs.kde.org/show_bug.cgi?id=480198 Marco Martin changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-desktop/-/commit/ |t/8fceb1e8f5fafd6689f6fc569 |75c6a35a48fd112068209983507 |97904cd3c441860 |714484d3fa7a3 --- Comment #10 from Marco Martin --- Git commit 75c6a35a48fd112068209983507714484d3fa7a3 by Marco Martin. Committed on 26/01/2024 at 16:56. Pushed by mart into branch 'Plasma/6.0'. Api to know whether an applet supportslaunchers Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 Depends on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3819 or https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3826 FIXED-IN: 6.0 M +8-0applets/taskmanager/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/75c6a35a48fd112068209983507714484d3fa7a3 -- You are receiving this mail because: You are watching all bug changes.
