[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 Jakob Petsovits changed: What|Removed |Added CC||jpe...@petsovits.com Version Fixed In||6.1.1 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 Jakob Petsovits changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/powerdevil/-/commit/0338 |ma/powerdevil/-/commit/1017 |25d2217ec3c91af5af1fc0a6fbb |585fe5ef2263e02e6dc6f5227de |66f91fdbd |15fb3ba5d --- Comment #6 from Jakob Petsovits --- Git commit 1017585fe5ef2263e02e6dc6f5227de15fb3ba5d by Jakob Petsovits. Committed on 22/06/2024 at 12:16. Pushed by jpetso into branch 'Plasma/6.1'. daemon: Limit KAuth backlighthelper calls to only one at a time KAuth invocations are slower than users can move a slider. So we get many brightness change requests, and KAuth can't keep up. As a result, high-frequency brightness change requests for BacklightBrightness (i.e. laptop displays) would feel very laggy and get worse over time if not given a break to catch up. This commit fixes the lagginess. Conceptually it's easy: Don't start a new KAuth helper job until the current one has reported a result. At that point, check if a different brightness level was requested in the meantime, and start another job only then. BacklightHelper can deal fine with interrupting a running animation and starting a new one from the current brightness level. Hence, there is no need to wait until the end of the brightness animation to start a new KAuth job - this would only increase latency. Starting the new job right after receiving a result is perfectly fine. In the same go, we make two related improvements. Firstly, the udev-powered brightness observer will not only ignore events when the animation timer is running, but also in between setBrightness() and the KAuth result handler where the timer is started. Secondly, the condition involving m_brightnessAnimationThreshold is changed to something sensible. It makes no sense to simply check the current brightness against a constant number (100) to determine whether the brightness change should be animated. What I think this meant to do is to ensure that there are enough brightness steps available to animate. So following this commit, we will now animate when the difference between the current and the requested brightness is 100 or more integer steps. Taken together, laptop brightness slider UX now seems decent. Related: bug 470106 (cherry picked from commit 033825d2217ec3c91af5af1fc0a6fbb66f91fdbd) M +38 -13 daemon/controllers/backlightbrightness.cpp M +3-0daemon/controllers/backlightbrightness.h https://invent.kde.org/plasma/powerdevil/-/commit/1017585fe5ef2263e02e6dc6f5227de15fb3ba5d -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 Jakob Petsovits changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/powerdevil/-/commit/0338 ||25d2217ec3c91af5af1fc0a6fbb ||66f91fdbd --- Comment #5 from Jakob Petsovits --- Git commit 033825d2217ec3c91af5af1fc0a6fbb66f91fdbd by Jakob Petsovits. Committed on 22/06/2024 at 11:46. Pushed by jpetso into branch 'master'. daemon: Limit KAuth backlighthelper calls to only one at a time KAuth invocations are slower than users can move a slider. So we get many brightness change requests, and KAuth can't keep up. As a result, high-frequency brightness change requests for BacklightBrightness (i.e. laptop displays) would feel very laggy and get worse over time if not given a break to catch up. This commit fixes the lagginess. Conceptually it's easy: Don't start a new KAuth helper job until the current one has reported a result. At that point, check if a different brightness level was requested in the meantime, and start another job only then. BacklightHelper can deal fine with interrupting a running animation and starting a new one from the current brightness level. Hence, there is no need to wait until the end of the brightness animation to start a new KAuth job - this would only increase latency. Starting the new job right after receiving a result is perfectly fine. In the same go, we make two related improvements. Firstly, the udev-powered brightness observer will not only ignore events when the animation timer is running, but also in between setBrightness() and the KAuth result handler where the timer is started. Secondly, the condition involving m_brightnessAnimationThreshold is changed to something sensible. It makes no sense to simply check the current brightness against a constant number (100) to determine whether the brightness change should be animated. What I think this meant to do is to ensure that there are enough brightness steps available to animate. So following this commit, we will now animate when the difference between the current and the requested brightness is 100 or more integer steps. Taken together, laptop brightness slider UX now seems decent. Related: bug 470106 M +38 -13 daemon/controllers/backlightbrightness.cpp M +3-0daemon/controllers/backlightbrightness.h https://invent.kde.org/plasma/powerdevil/-/commit/033825d2217ec3c91af5af1fc0a6fbb66f91fdbd -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 Nate Graham changed: What|Removed |Added CC||benhutchy123...@gmail.com --- Comment #4 from Nate Graham --- *** Bug 484254 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/342 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 duha.b...@gmail.com changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #2 from duha.b...@gmail.com --- Can confirm (on a Desktop): Operating System: Arch Linux KDE Plasma Version: 6.0.80 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.1 Kernel Version: 6.7.4-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 32 × AMD Ryzen 9 7950X 16-Core Processor Memory: 30,6 GiB of RAM Graphics Processor: AMD Radeon RX 7900 XTX The slider is very sluggish and sometimes does not update or updates random values. Additionally after the screen turns off it gets darker (latest test from 55% to 16% after the screen turned off and on again). I didn't even have this option a few weeks ( or months) before, could also be a downstream bug. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 duha.b...@gmail.com changed: What|Removed |Added CC||duha.b...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 --- Comment #1 from fanzhuyi...@gmail.com --- Can't reproduce on wayland, git master -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 481003] display brightness applet laggy and sometimes does not react to input
https://bugs.kde.org/show_bug.cgi?id=481003 fanzhuyi...@gmail.com changed: What|Removed |Added Summary|Applet being very buggy |display brightness applet ||laggy and sometimes does ||not react to input CC||fanzhuyi...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
