[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307 Fushan Wen changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi |t/3fc0ef5ef629c17ae354a |t/175b6b6ce3affec08c0325b9e |333446ce2eaf1c9 |793513491eb380e --- Comment #7 from Fushan Wen --- Git commit 175b6b6ce3affec08c0325b9e793513491eb380e by Fushan Wen. Committed on 13/06/2024 at 07:07. Pushed by fusionfuture into branch 'Plasma/6.1'. [widgetsexplorer] Prefer applet id as icon name again We have special icons with the applet id as name bd4f0684e089f2585264fd9e46d245c20fd05004 changed the logic to prefer the icon name from the metadata again, but we want to use those special icons instead (cherry picked from commit 3fc0ef5ef629c17ae354a333446ce2eaf1c9) Co-authored-by: Nicolas Fella M +4-6components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/175b6b6ce3affec08c0325b9e793513491eb380e -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307 Fushan Wen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/-/commi ||t/3fc0ef5ef629c17ae354a ||333446ce2eaf1c9 Status|ASSIGNED|RESOLVED --- Comment #6 from Fushan Wen --- Git commit 3fc0ef5ef629c17ae354a333446ce2eaf1c9 by Fushan Wen, on behalf of Nicolas Fella. Committed on 13/06/2024 at 07:06. Pushed by fusionfuture into branch 'master'. [widgetsexplorer] Prefer applet id as icon name again We have special icons with the applet id as name bd4f0684e089f2585264fd9e46d245c20fd05004 changed the logic to prefer the icon name from the metadata again, but we want to use those special icons instead M +4-6components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/3fc0ef5ef629c17ae354a333446ce2eaf1c9 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4442 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307
--- Comment #4 from Nicolas Fella ---
Okay, I see where the change comes from. It's the inversion of the
if (QIcon::hasThemeIcon(info.pluginId())) {
setIcon(QIcon::fromTheme(info.pluginId()));
} else if (!m_info.iconName().isEmpty()) {
setIcon(QIcon::fromTheme(info.iconName()));
}
check. Now the Icon= value from the metadata is perferred over the plugin id as
icon name
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307 --- Comment #3 from Nate Graham --- In Widget explorer, only the Activity Pager and Folder View widgets show their widget-specific icons. All the others don't get shown. You can open up Icon Explorer and search for "org.kde.plasma." to see all the other icons that should be shown there but aren't. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307 --- Comment #2 from Nicolas Fella --- "Almost all" seems a bit of an overstatement. As far as I can tell it affects only the three launcher icons? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488307] Widget-specific icons are mostly no longer seen (e.g. in Widget Explorer and Alternatives dialog)
https://bugs.kde.org/show_bug.cgi?id=488307 --- Comment #1 from Nate Graham --- Created attachment 170345 --> https://bugs.kde.org/attachment.cgi?id=170345&action=edit Mostly missing in Widget Explorer -- You are receiving this mail because: You are watching all bug changes.
