[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 --- Comment #8 from Nate Graham --- Git commit 9cc78130ca833bac58b3039ef65f2236679349fa by Nate Graham, on behalf of Niccolò Venerandi. Committed on 24/06/2024 at 19:05. Pushed by ngraham into branch 'Plasma/6.1'. Do not hide panel edit mode dialog when Widget Explorer is closed If you: 1. Right click on the panel and click Add widgets 2. Click on the panel to enter panel edit mode Then your click would enter panel edit mode, but the Widget Explorer would send another "configure" event to the panel, which would then close panel edit mode, which would close panel edit mode entirely. We need to make sure that closing the Widget Explorer will never also close the panel edit mode. (cherry picked from commit 01b62897061e1d29538d6e76bbe1665f916c4d0e) M +3-1desktoppackage/contents/views/Desktop.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/9cc78130ca833bac58b3039ef65f2236679349fa -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/-/commit/ |ma/plasma-desktop/-/commit/ |2206aa80565e7112a96771d5272 |6b7a54ba8434e0872c5b7a045a6 |9a85b8d4f1a84 |ae4f7847e1f22 --- Comment #7 from Nate Graham --- Git commit 6b7a54ba8434e0872c5b7a045a6ae4f7847e1f22 by Nate Graham. Committed on 24/06/2024 at 19:01. Pushed by ngraham into branch 'Plasma/6.1'. Widget Explorer: ask for focus after drag and drop Since the Widget Explorer only closes when it loses focus, but there's an exception during a drag and drop, it might get stuck open. Immediately reclaiming focus will make sure it closes. Example to test with: - Right click on a panel, click "add widgets" - open panel edit mode - sidebar closes! But: - Right click on a panel, click "add widgets" - drag and drop a widget to the panel - open panel edit mode - sidebar does not close :-( With this MR it closes. FIXED-IN: 6.1.1 (cherry picked from commit 2206aa80565e7112a96771d52729a85b8d4f1a84) eb778401 Make add widgets sidebar ask for focus after drag and drop Co-authored-by: Niccolò Venerandi M +11 -0desktoppackage/contents/explorer/WidgetExplorer.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/6b7a54ba8434e0872c5b7a045a6ae4f7847e1f22 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 Nate Graham changed: What|Removed |Added Status|REPORTED|RESOLVED Version Fixed In||6.1.1 Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/plasma-desktop/-/commit/ ||2206aa80565e7112a96771d5272 ||9a85b8d4f1a84 --- Comment #6 from Nate Graham --- Git commit 2206aa80565e7112a96771d52729a85b8d4f1a84 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 24/06/2024 at 19:00. Pushed by ngraham into branch 'master'. Widget Explorer: ask for focus after drag and drop Since the Widget Explorer only closes when it loses focus, but there's an exception during a drag and drop, it might get stuck open. Immediately reclaiming focus will make sure it closes. Example to test with: - Right click on a panel, click "add widgets" - open panel edit mode - sidebar closes! But: - Right click on a panel, click "add widgets" - drag and drop a widget to the panel - open panel edit mode - sidebar does not close :-( With this MR it closes. FIXED-IN: 6.1.1 M +11 -0desktoppackage/contents/explorer/WidgetExplorer.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/2206aa80565e7112a96771d52729a85b8d4f1a84 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 --- Comment #5 from Nate Graham --- Git commit 01b62897061e1d29538d6e76bbe1665f916c4d0e by Nate Graham, on behalf of Niccolò Venerandi. Committed on 24/06/2024 at 18:54. Pushed by ngraham into branch 'master'. Do not hide panel edit mode dialog when Widget Explorer is closed If you: 1. Right click on the panel and click Add widgets 2. Click on the panel to enter panel edit mode Then your click would enter panel edit mode, but the Widget Explorer would send another "configure" event to the panel, which would then close panel edit mode, which would close panel edit mode entirely. We need to make sure that closing the Widget Explorer will never also close the panel edit mode. M +3-1desktoppackage/contents/views/Desktop.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/01b62897061e1d29538d6e76bbe1665f916c4d0e -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2336 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2329 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 --- Comment #2 from cwo --- Another slightly different case; I'll put it here as it seems somewhat similar: STEPS TO REPRODUCE 1. Right click the panel, click "Add Widgets..." 2. Take a screenshot by pressing the PrintScreen key. (Launching spectacle from the menu and taking a screenshot with delay also triggers the issue). OBSERVED RESULT Spectacle appears and is hidden, Widget Explorer closes, Panel Configuration mode launches for some reason (???) EXPECTED RESULT Panel Configuration mode should not launch. (I'm not quite sure what the correct behavior for the other parts should be; both keeping Widget Explorer open/hiding Spectacle and closing Widget Explorer/showing Spectacle seem defensible. If you do this with the Desktop Widget Explorer open (i.e. through right click on the desktop, Open Edit Mode, Add Widgets... Button), the current result is that Spectacle opens and Widget Explorer closes, and I do think both should behave the same way. And for good measure: 1. Right click the desktop, "Enter Edit Mode", click "Add Widgets". 2. Drag Analog Clock to a panel 3. Take a screenshot. This way, both spectacle and Widget Explorer are visible at the same time; instead *Edit Mode* closes (with Widget Explorer still active). If you take another screenshot, however, Widget Explorer closes again. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 488571] Showing panel settings dialog while widget explorer is already open does the wrong thing
https://bugs.kde.org/show_bug.cgi?id=488571 Nate Graham changed: What|Removed |Added Summary|"Show Panel Configuration" |Showing panel settings |does not work while "Add|dialog while widget |Widget" is active, |explorer is already open |depending on how the user |does the wrong thing |interacted with the "Add| |Widget" interface | CC||n...@kde.org, ||notm...@gmail.com Keywords||usability --- Comment #1 from Nate Graham --- Can confirm all weird variants. The common denominator seems to be showing the panel configuration dialog while the widget explorer sidebar is already open -- You are receiving this mail because: You are watching all bug changes.
