[plasmashell] [Bug 488619] With 17-6-2024 git master everything, all notification pop-ups are positioned in top-left corner

2024-06-27 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=488619

Marco Martin  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/-/commi
   ||t/9c872a54287a1ea84326a7100
   ||1386e4040b7c5a4
   Version Fixed In||6.2

--- Comment #4 from Marco Martin  ---
Git commit 9c872a54287a1ea84326a71001386e4040b7c5a4 by Marco Martin.
Committed on 27/06/2024 at 07:50.
Pushed by mart into branch 'master'.

applets/systemtray: Fix shortcut activation for hidden applets

The systray applet was opened by a connection to activated in the
PlasmoidItem container element. This element is a delegate, of a Repeater
for active applets, and for the internal GridView in the popup for the passive
applets.

Being a Delegate we can't be guaranteed it will be instantiated at startup,
in particular it won't be unless the first time the gridview is visible,
so the connections to the activated signal won't work until the first time the
applet is open. Also, if there would ever be enough icons in the popup to
cause a scrollbar, it will destroy the PopupItems out of view.

Move the connection to the activate signal that will cause the popup to open
inside an Instantiator in the main qml file: with an Instantiator we will
always
be guaranteed every delegate (which is just a Connections)
will always be instantiated all the time

Depends on https://invent.kde.org/plasma/libplasma/-/merge_requests/1145
Related: bug 480173
FIXED-IN: 6.2

M  +1-8applets/systemtray/package/contents/ui/HiddenItemsView.qml
M  +0-1applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
M  +59   -8applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/9c872a54287a1ea84326a71001386e4040b7c5a4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 488619] With 17-6-2024 git master everything, all notification pop-ups are positioned in top-left corner

2024-06-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=488619

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nate Graham  ---
That commit was reverted, so this is fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 488619] With 17-6-2024 git master everything, all notification pop-ups are positioned in top-left corner

2024-06-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=488619

Nate Graham  changed:

   What|Removed |Added

   Assignee|plasma-b...@kde.org |notm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 488619] With 17-6-2024 git master everything, all notification pop-ups are positioned in top-left corner

2024-06-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=488619

--- Comment #2 from Nate Graham  ---
This is caused by
https://invent.kde.org/plasma/plasma-workspace/-/commit/009136c8c4f02d19f1a1ba40b28c5d8960235487;
reverting that fixes the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 488619] With 17-6-2024 git master everything, all notification pop-ups are positioned in top-left corner

2024-06-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=488619

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
   Priority|NOR |VHI

--- Comment #1 from Nate Graham  ---
Others can reproduce it too; marking as CONFIRMED and bumping priority.

-- 
You are receiving this mail because:
You are watching all bug changes.