[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663
Nate Graham changed:
What|Removed |Added
Version Fixed In||5.12.8
Latest Commit||https://commits.kde.org/pla
||sma-desktop/26fb5ec20af6068
||2561c7a9678506199966ef2c1
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Nate Graham ---
Git commit 26fb5ec20af60682561c7a9678506199966ef2c1 by Nate Graham.
Committed on 27/11/2018 at 03:01.
Pushed by ngraham into branch 'Plasma/5.12'.
[Componentchooser KCM] Make default browser app choice work even when combobox
is not used
Summary:
FIXED-IN: 5.12.8
When choosing a default browser app using the app list combobox, the choice was
only being saved after the combobox was used, because its signal was connected
to an inline function that saved the choice, while the radio button that
enabled the combobox was not. As a result, if you clicked on that radio button
and didn't need to use the combobox because it was already showing your
preferred browser, that action was not actually getting saved.
This patch fixes the situation my moving the inline function into a real
explicit slot function and connecting the radio button to it as well.
Test Plan:
- Go to the component chooser KCM's default browser module
- Reset to defaults, then leave the KCM and open it again
- Click the {nav in the following application} radio button
- Do NOT touch the combobox
- Click {nav Apply}
- Leave the KCM and come back
With this patch, the radio button's state is preserved and the correct browser
is selected in the combobox.
Reviewers: #plasma, cfeck, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17181
M +10 -7kcms/componentchooser/componentchooserbrowser.cpp
M +1-0kcms/componentchooser/componentchooserbrowser.h
https://commits.kde.org/plasma-desktop/26fb5ec20af60682561c7a9678506199966ef2c1
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 Nate Graham changed: What|Removed |Added Keywords||usability Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #8 from Nate Graham --- This turned out to be a fairly easy fix. Here's a patch: https://phabricator.kde.org/D17181 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 Kayra Akman changed: What|Removed |Added CC||ckak...@gmail.com --- Comment #7 from Kayra Akman --- (In reply to HD from comment #5) > Not sure if this is connected, but I have the issue of not being able to > change the default browser in "Default Applications" at all. When I change > it and press apply or ok, it reverts back to "in an application based on the > contents of the URL". > > My reason for changing it was that I get the error "KDEInit could not launch > '/usr/lib/firefox/firefox'", and I can't figure out how to solve that or why > it would even look for firefox there. > > I'm on debian stretch with plasma 5.8.4. I was about the report this issue. Selecting "in the following application" item was not enough. A browser in the drop-down must be selected, even if there is only one, so that the setting change is applied and saved. Kubuntu 18.04, Plasma 5.12.4, Falkon as the only available web browser. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 Anguo changed: What|Removed |Added CC||kde_b...@overshoot.tv --- Comment #6 from Anguo --- Bug 380133 - Cannot see/change default browser settings https://bugs.kde.org/show_bug.cgi?id=380133 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 HD changed: What|Removed |Added CC||haako...@ifi.uio.no --- Comment #5 from HD --- Not sure if this is connected, but I have the issue of not being able to change the default browser in "Default Applications" at all. When I change it and press apply or ok, it reverts back to "in an application based on the contents of the URL". My reason for changing it was that I get the error "KDEInit could not launch '/usr/lib/firefox/firefox'", and I can't figure out how to solve that or why it would even look for firefox there. I'm on debian stretch with plasma 5.8.4. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 Christoph Feck changed: What|Removed |Added CC||robledo...@yahoo.com --- Comment #4 from Christoph Feck --- *** Bug 370201 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page
https://bugs.kde.org/show_bug.cgi?id=350663 Christoph Feck changed: What|Removed |Added CC||ad1r...@hotmail.fr --- Comment #3 from Christoph Feck --- *** Bug 367845 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
