[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107 Nate Graham changed: What|Removed |Added CC||gabrielfer...@gmail.com --- Comment #4 from Nate Graham --- *** Bug 413296 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107 --- Comment #3 from sombrag...@sombragris.org --- Thank you! That was fast! Way to go guys! -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107 Nate Graham changed: What|Removed |Added Version Fixed In||5.17.3 CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107
Nate Graham changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/kde
||-gtk-config/308342b16f0a1af
||0437e1a7d7049b59d30a81952
Status|ASSIGNED|RESOLVED
--- Comment #2 from Nate Graham ---
Git commit 308342b16f0a1af0437e1a7d7049b59d30a81952 by Nate Graham, on behalf
of Mikhail Zolotukhin.
Committed on 07/11/2019 at 17:55.
Pushed by ngraham into branch 'Plasma/5.17'.
Remove gtkrc-2.0 legacy settings
Summary:
Previously GTK KCM wrote to gtkrc redundant settings lines:
# `include "path to chosen gtk2 theme"`
#
```
style "user-font"
{
font-name="whatever font was chosen"
}
widget_style "*" style "user-font"
```
Now GTK KCM does not write those lines to configuration file,
but ones that was kept from previous versions of KCM
are causing various glitches, when applying gtk2
configuration, for theme and font configs respectively.
This patch fixes these issues removing these lines from gtkrc
by force, after applying any configuration from GTK KCM.
Related: bug 413678
Test Plan:
# Open ~/gtkrc-2.0 and add those lines (theme and font name are arbitrary):
```
include "/usr/share/themes/Adwaita-dark/gtk-2.0/gtkrc"
style "user-font"
{
font_name="Noto Sans Regular"
}
widget_class "*" style "user-font"
```
# Open GTK KCM and apply any configuration
# Reopen ~/gtkrc-2.0 file and check, that those lines were removed
Reviewers: cblack, #plasma, apol, ngraham
Reviewed By: cblack, ngraham
Subscribers: ervin, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25147
M +22 -0src/appearancegtk2.cpp
M +1-0src/appearancegtk2.h
https://commits.kde.org/kde-gtk-config/308342b16f0a1af0437e1a7d7049b59d30a81952
--
You are receiving this mail because:
You are watching all bug changes.
[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107 Mikhail Zolotukhin changed: What|Removed |Added Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107 Mikhail Zolotukhin changed: What|Removed |Added CC||zom...@protonmail.com Assignee|aleix...@gmail.com |zom...@protonmail.com -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 413107] kde-config-gtk improper theming; ~/.gtkrc-2.0 issue
https://bugs.kde.org/show_bug.cgi?id=413107 Nate Graham changed: What|Removed |Added Assignee|manutortosa@chakra-project. |aleix...@gmail.com |org | Component|general |kcm_gtk Product|kde-gtk-config |systemsettings -- You are receiving this mail because: You are watching all bug changes.
