[systemsettings] [Bug 413183] Ugly and incorrect monochrome icon used to indicate that a KCM needs auth

2019-11-05 Thread Filip Fila
https://bugs.kde.org/show_bug.cgi?id=413183

Filip Fila  changed:

   What|Removed |Added

   Version Fixed In||5.17.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 413183] Ugly and incorrect monochrome icon used to indicate that a KCM needs auth

2019-11-05 Thread Filip Fila
https://bugs.kde.org/show_bug.cgi?id=413183

Filip Fila  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/sys
   ||temsettings/efb35162be7f21f
   ||28d0c293fb0c024d9ad9c0f90

--- Comment #7 from Filip Fila  ---
Git commit efb35162be7f21f28d0c293fb0c024d9ad9c0f90 by Filip Fila.
Committed on 05/11/2019 at 10:54.
Pushed by filipf into branch 'Plasma/5.17'.

[Icon View] Don't use dialog-warning emblem on icon when KCM requires
authentication

Summary:
Icon view currently sets a dialog-warning emblem on the sidebar icons for KCMs
that require root authentication (SDDM, KDE Wallet).

This overlay is both confusing and unnecessary given that we already spell it
out in big letters in the KCM header that we'll be asking for authentication.

This patch removes the icon overlay.

Test Plan:
Before:
{F7737211}

After:
{F7737213}

Reviewers: #vdg, ngraham, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25150

M  +0-1core/ModuleView.cpp

https://commits.kde.org/systemsettings/efb35162be7f21f28d0c293fb0c024d9ad9c0f90

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 413183] Ugly and incorrect monochrome icon used to indicate that a KCM needs auth

2019-11-04 Thread Filip Fila
https://bugs.kde.org/show_bug.cgi?id=413183

Filip Fila  changed:

   What|Removed |Added

Summary|Warning emblem in icon  |Ugly and incorrect
   |view's sidebar is confusing |monochrome icon used to
   ||indicate that a KCM needs
   ||auth

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 413183] Ugly and incorrect monochrome icon used to indicate that a KCM needs auth

2019-11-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=413183

Nate Graham  changed:

   What|Removed |Added

   Assignee|k...@davidedmundson.co.uk|plasma-b...@kde.org
Summary|Use a   |Ugly and incorrect
   |KMessageWidget/InlineMessag |monochrome icon used to
   |e to indicate when the SDDM |indicate that a KCM needs
   |KCM can't be used   |auth
  Component|kcm_sddm|iconview

-- 
You are receiving this mail because:
You are watching all bug changes.