[systemsettings] [Bug 417923] Rules list should be immediately updated after we create a rule while "Window rules" kcm is open

2021-05-01 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=417923

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/928

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417923] Rules list should be immediately updated after we create a rule while "Window rules" kcm is open

2021-03-18 Thread Ismael Asensio
https://bugs.kde.org/show_bug.cgi?id=417923

--- Comment #4 from Ismael Asensio  ---
Git commit a82be242ea207fb5c7384d2be7703456b368a414 by Ismael Asensio.
Committed on 19/03/2021 at 03:16.
Pushed by iasensio into branch 'master'.

[kwinrules] Launch full KCM when editing from window menu

When rules configuration is invoked from window `Alt+F3` menu,
we call a custom binary `kwin_rules_dialog` which currently provides
only the rule edition dialog by embedding `RulesEditor.qml` within a
QQuickView.

This MR changes that behavior to call the full KCM from the menu.
The code to match previous rules, or compose a new one based on window
properties has been ported to the KCM from the dialog, so the overall
interaction is similar.

It has several advantages:
 - uses only one entry-point to the code
 - adds discoverability to the full KCM (I guess many users know how to
   create a rule, but not where to delete it later)

And a drawback:
 - only one instance of the KCM can be called at a time, so it will show an
   error when calling it from two different windows, or if the KCM is open
   in System Settings

This drawback can be solved after adding argument passing via dBus in KCM
infraestructure.
Related: bug 433837

M  +4-2src/kcmkwin/kwinrules/CMakeLists.txt
M  +162  -3src/kcmkwin/kwinrules/kcmrules.cpp
M  +7-0src/kcmkwin/kwinrules/kcmrules.h
M  +29   -211  src/kcmkwin/kwinrules/main.cpp
M  +7-9src/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
M  +86   -0src/kcmkwin/kwinrules/rulebookmodel.cpp
M  +2-0src/kcmkwin/kwinrules/rulebookmodel.h
D  +0-74   src/kcmkwin/kwinrules/rulesdialog.cpp
D  +0-41   src/kcmkwin/kwinrules/rulesdialog.h

https://invent.kde.org/plasma/kwin/commit/a82be242ea207fb5c7384d2be7703456b368a414

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417923] Rules list should be immediately updated after we create a rule while "Window rules" kcm is open

2020-10-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417923

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
  Component|rules   |kcm_kwinrules
Product|kwin|systemsettings
 CC||isma...@gmail.com,
   ||plasma-b...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417923] Rules list should be immediately updated after we create a rule while "Window rules" kcm is open

2020-12-26 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=417923

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/566

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417923] Rules list should be immediately updated after we create a rule while "Window rules" kcm is open

2020-02-20 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=417923

--- Comment #1 from Patrick Silva  ---
better step 2:
right click on the window decoration of any app, hover over "More actions",
choose "Configure special window/application settings...", set any rule and
click on "Ok" button

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 417923] Rules list should be immediately updated after we create a rule while "Window rules" kcm is open

2020-02-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=417923

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.