[systemsettings] [Bug 439297] "Apply" button of Application Style KCM is unnecessarily activated after change in application style settings
https://bugs.kde.org/show_bug.cgi?id=439297 Nate Graham changed: What|Removed |Added Version Fixed In||5.23.5 Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439297] "Apply" button of Application Style KCM is unnecessarily activated after change in application style settings
https://bugs.kde.org/show_bug.cgi?id=439297 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/ |bdebc4d246698b43e4182b0ebe9 |46fde8e84cbeb0a4cf7c1ee65f9 |a94b7d6780d60 |81e8ef8a4e046 --- Comment #4 from Nate Graham --- Git commit 46fde8e84cbeb0a4cf7c1ee65f981e8ef8a4e046 by Nate Graham, on behalf of Nicolas Fella. Committed on 24/12/2021 at 21:55. Pushed by ngraham into branch 'Plasma/5.23'. [kcms/style] Don't call setNeedsSave when style config changes The style config is saved already when the dialog closes so enabling the KCM apply button doesn't make sense The comment suggests that this is done for a reason, but the style preview seems to refresh correctly even with this patch (cherry picked from commit bdebc4d246698b43e4182b0ebe9a94b7d6780d60) M +0-3kcms/style/kcmstyle.cpp https://invent.kde.org/plasma/plasma-workspace/commit/46fde8e84cbeb0a4cf7c1ee65f981e8ef8a4e046 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439297] "Apply" button of Application Style KCM is unnecessarily activated after change in application style settings
https://bugs.kde.org/show_bug.cgi?id=439297 Nate Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/plasma-workspace/commit/ ||bdebc4d246698b43e4182b0ebe9 ||a94b7d6780d60 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #3 from Nate Graham --- Git commit bdebc4d246698b43e4182b0ebe9a94b7d6780d60 by Nate Graham, on behalf of Nicolas Fella. Committed on 24/12/2021 at 21:43. Pushed by ngraham into branch 'master'. [kcms/style] Don't call setNeedsSave when style config changes The style config is saved already when the dialog closes so enabling the KCM apply button doesn't make sense The comment suggests that this is done for a reason, but the style preview seems to refresh correctly even with this patch M +0-3kcms/style/kcmstyle.cpp https://invent.kde.org/plasma/plasma-workspace/commit/bdebc4d246698b43e4182b0ebe9a94b7d6780d60 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439297] "Apply" button of Application Style KCM is unnecessarily activated after change in application style settings
https://bugs.kde.org/show_bug.cgi?id=439297 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #2 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1285 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439297] "Apply" button of Application Style KCM is unnecessarily activated after change in application style settings
https://bugs.kde.org/show_bug.cgi?id=439297 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 439297] "Apply" button of Application Style KCM is unnecessarily activated after change in application style settings
https://bugs.kde.org/show_bug.cgi?id=439297 Paul Worrall changed: What|Removed |Added Ever confirmed|0 |1 CC||p.r.worr...@gmail.com Status|REPORTED|CONFIRMED --- Comment #1 from Paul Worrall --- I can reproduce. Also the "Reset" button is activated (and doesn't reset the change) Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.2 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.3 Kernel Version: 5.8.0-59-generic (64-bit) Graphics Platform: Wayland Processors: 2 × AMD A6-6400K APU with Radeon(tm) HD Graphics Memory: 7.7 GiB of RAM Graphics Processor: AMD CEDAR -- You are receiving this mail because: You are watching all bug changes.
