[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 --- Comment #6 from ratijas --- Git commit c108ef2b53918265d113d2d97721f88a3f9ed486 by ivan tkachenko. Committed on 02/03/2023 at 01:57. Pushed by ratijas into branch 'Plasma/5.27'. Fix inappropriately localized permission name "per-app-dev-shm" Which corresponds to FLATPAK_CONTEXT_FEATURE_PER_APP_DEV_SHM value from FlatpakContextFeatures enum in Flatpak internals. Amends 3d2a355aec552f49394975550aa36d3e3634302c. FIXED-IN: 5.27.3 (cherry picked from commit 7cf1da69d30cdd8efbb563070e0bdaf303ef118a) M +1-1flatpakpermission.cpp https://invent.kde.org/plasma/flatpak-kcm/commit/c108ef2b53918265d113d2d97721f88a3f9ed486 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 --- Comment #5 from ratijas --- Git commit 7cf1da69d30cdd8efbb563070e0bdaf303ef118a by ivan tkachenko. Committed on 02/03/2023 at 01:56. Pushed by ratijas into branch 'master'. Fix inappropriately localized permission name "per-app-dev-shm" Which corresponds to FLATPAK_CONTEXT_FEATURE_PER_APP_DEV_SHM value from FlatpakContextFeatures enum in Flatpak internals. Amends 3d2a355aec552f49394975550aa36d3e3634302c. FIXED-IN: 5.27.3 M +1-1flatpakpermission.cpp https://invent.kde.org/plasma/flatpak-kcm/commit/7cf1da69d30cdd8efbb563070e0bdaf303ef118a -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 Harald Sitter changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/flatpak-kcm/commit/3d2a3 |ma/flatpak-kcm/commit/5d6a1 |55aec552f49394975550aa36d3e |c0536da8114f1f9ba9d341e3b41 |3634302c|9839d4e3 --- Comment #4 from Harald Sitter --- Git commit 5d6a1c0536da8114f1f9ba9d341e3b419839d4e3 by Harald Sitter. Committed on 17/02/2023 at 13:44. Pushed by sitter into branch 'Plasma/5.27'. always use frontend strings but convert to backend strings when saving this resolves various localization problems where we got confused between frontend strings (localized) and backend strings (english-y config file strings). in an attempt to keep this change fairly conservatively the entire code base now should assume that Value instances inside the Permission object are localized and must be delocalized for writing to file. for filesystem entries that was kind of working already and has been extended to cover (hopefully) all branches where writeouts occur. for dbus entries this is now also the behavior and assisted by back and forth conversion helper functions. dbus entries also had their config file manipulation adjusted to be a tad easier to read and a lot more reliable further refactoring is advised: ideally there'd be a sensible split between frontend and backend strings so the backend code only ever deals with backend strings and the conversion for displaying happens separately from that. also the config file writing/management seems overly fragile at a glance. the config file management possibly should get split out of the model so it is easier to comprehensively unit test it. there should just never be a case where the config breaks because of us :| FIXED-IN: 5.27.1 (cherry picked from commit 3d2a355aec552f49394975550aa36d3e3634302c) M +90 -49 flatpakpermission.cpp https://invent.kde.org/plasma/flatpak-kcm/commit/5d6a1c0536da8114f1f9ba9d341e3b419839d4e3 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 Harald Sitter changed: What|Removed |Added Version Fixed In||5.27.1 Latest Commit||https://invent.kde.org/plas ||ma/flatpak-kcm/commit/3d2a3 ||55aec552f49394975550aa36d3e ||3634302c Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #3 from Harald Sitter --- Git commit 3d2a355aec552f49394975550aa36d3e3634302c by Harald Sitter. Committed on 17/02/2023 at 13:09. Pushed by sitter into branch 'master'. always use frontend strings but convert to backend strings when saving this resolves various localization problems where we got confused between frontend strings (localized) and backend strings (english-y config file strings). in an attempt to keep this change fairly conservatively the entire code base now should assume that Value instances inside the Permission object are localized and must be delocalized for writing to file. for filesystem entries that was kind of working already and has been extended to cover (hopefully) all branches where writeouts occur. for dbus entries this is now also the behavior and assisted by back and forth conversion helper functions. dbus entries also had their config file manipulation adjusted to be a tad easier to read and a lot more reliable further refactoring is advised: ideally there'd be a sensible split between frontend and backend strings so the backend code only ever deals with backend strings and the conversion for displaying happens separately from that. also the config file writing/management seems overly fragile at a glance. the config file management possibly should get split out of the model so it is easier to comprehensively unit test it. there should just never be a case where the config breaks because of us :| FIXED-IN: 5.27.1 M +90 -49 flatpakpermission.cpp https://invent.kde.org/plasma/flatpak-kcm/commit/3d2a355aec552f49394975550aa36d3e3634302c -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 --- Comment #2 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/flatpak-kcm/-/merge_requests/40 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 Harald Sitter changed: What|Removed |Added Status|CONFIRMED |ASSIGNED CC||sit...@kde.org Assignee|plasma-b...@kde.org |sit...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 465818] Flatpak KCM doesn't create proper overrides because of translations
https://bugs.kde.org/show_bug.cgi?id=465818 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||n...@kde.org Priority|NOR |VHI --- Comment #1 from Nate Graham --- Oops. Can reproduce. -- You are receiving this mail because: You are watching all bug changes.
