[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Ismael Asensio changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/-/commit/3572e6f0e7 |ma/kwin/-/commit/7bd9fe6827 |73eb82008b6799faac8278e009a |7b2d9eaab64ab7a3056c0cdc3e4 |e5a |666 --- Comment #9 from Ismael Asensio --- Git commit 7bd9fe68277b2d9eaab64ab7a3056c0cdc3e4666 by Ismael Asensio. Committed on 13/01/2024 at 16:07. Pushed by iasensio into branch 'Plasma/6.0'. kcms/tabbox: Add mock-up object for KWin.DesktopBackground The window switcher previews don't use the actual quick components the KWin plugin provides, but mock-up objects of those. Add a mock-up component for `KWin.DesktopBackground`, which is just a thumbnail of the desktop default image but stretched to cover the whole parent size. This fixes the previews for flip window switchers. FIXED-IN: 5.93.0 (cherry picked from commit 3572e6f0e773eb82008b6799faac8278e009ae5a) M +23 -0src/kcms/tabbox/layoutpreview.cpp M +20 -0src/kcms/tabbox/layoutpreview.h https://invent.kde.org/plasma/kwin/-/commit/7bd9fe68277b2d9eaab64ab7a3056c0cdc3e4666 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Ismael Asensio changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/kwin/-/commit/3572e6f0e7 ||73eb82008b6799faac8278e009a ||e5a Version Fixed In||5.93.0 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from Ismael Asensio --- Git commit 3572e6f0e773eb82008b6799faac8278e009ae5a by Ismael Asensio. Committed on 13/01/2024 at 15:26. Pushed by iasensio into branch 'master'. kcms/tabbox: Add mock-up object for KWin.DesktopBackground The window switcher previews don't use the actual quick components the KWin plugin provides, but mock-up objects of those. Add a mock-up component for `KWin.DesktopBackground`, which is just a thumbnail of the desktop default image but stretched to cover the whole parent size. This fixes the previews for flip window switchers. FIXED-IN: 5.93.0 M +23 -0src/kcms/tabbox/layoutpreview.cpp M +20 -0src/kcms/tabbox/layoutpreview.h https://invent.kde.org/plasma/kwin/-/commit/3572e6f0e773eb82008b6799faac8278e009ae5a -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4910 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 --- Comment #6 from Ismael Asensio --- > Could the preview button just bring up a simple image or animated clip, > without referencing the actual windows from the user's session? Oh, this is what we are doing right now. :) We're constructing an animation but using the actual effect code (which is helpful also for other 3rd party switchers), but not the real windows nor thumbnails. The fact that it looks like the actual windows means it is a nice trick. :D >> Could be a screenshot or short clip This is not a bad idea at all. It could simplify things, specially in the future. This means also some important changes. Unfortunately this KCM's code is getting a bit old and adding clips/screenshots is not as easy as in the newer ones. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 --- Comment #5 from Doug --- (In reply to Ismael Asensio from comment #4) > Can confirm too. Thanks for submitting! > > This is happening on Plasma5 too. The preview code mocks up `TabBoxSwitcher` > and `Thumbnail` items, without using the actual tabbox code or linking to > kwin, so it cannot access the KWin plugin that provides the background. > This is enough for simpler switchers but fails for those who access specific > KWin API. > > I cannot think of a simple fix. A proper one would require some refactoring: > - Plasma provides the background as part of a `FullScreenPlasmaWindow` > component. > - We refactor the tabbox code into a small individual library, so it's kwin > who provides a "fake" model but actual items for the preview (larger scope, > but might be part on something I've been planning to do eventually). > - Also mocking-up the DesktopBackground component, using a "fake" one, (but > it may fail for other 3rd party switchers which rely on different KWin API > that is not mocked up) > > (In reply to Doug from comment #1) > > Created attachment 164765 [details] > > Task switcher previews piling up > > > > Can reproduce. Also, task switcher previews don't go away, even after > > exiting System Settings. Should I submit a separate bug for that? > > Yes please, that's a different issue and it helps keeping thinks separated. Could the preview button just bring up a simple image or animated clip, without referencing the actual windows from the user's session? Could be a screenshot or short clip, or something more diagrammatic like the Panel Settings popup. I would think that people just need to see what is meant by "Cover Switch" or "Flip Switch" to know if they want to try it out. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 --- Comment #4 from Ismael Asensio --- Can confirm too. Thanks for submitting! This is happening on Plasma5 too. The preview code mocks up `TabBoxSwitcher` and `Thumbnail` items, without using the actual tabbox code or linking to kwin, so it cannot access the KWin plugin that provides the background. This is enough for simpler switchers but fails for those who access specific KWin API. I cannot think of a simple fix. A proper one would require some refactoring: - Plasma provides the background as part of a `FullScreenPlasmaWindow` component. - We refactor the tabbox code into a small individual library, so it's kwin who provides a "fake" model but actual items for the preview (larger scope, but might be part on something I've been planning to do eventually). - Also mocking-up the DesktopBackground component, using a "fake" one, (but it may fail for other 3rd party switchers which rely on different KWin API that is not mocked up) (In reply to Doug from comment #1) > Created attachment 164765 [details] > Task switcher previews piling up > > Can reproduce. Also, task switcher previews don't go away, even after > exiting System Settings. Should I submit a separate bug for that? Yes please, that's a different issue and it helps keeping thinks separated. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Doug changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #3 from Doug --- (In reply to iodreamify from comment #2) > (In reply to Doug from comment #1) > > Created attachment 164765 [details] > > Task switcher previews piling up > > > > Can reproduce. Also, task switcher previews don't go away, even after > > exiting System Settings. Should I submit a separate bug for that? > > Feel free to do so, I also see this behavior. The only reason i didn't > report it was because i saw similar reports from years ago. > > https://bugs.kde.org/show_bug.cgi?id=462076 > https://bugs.kde.org/show_bug.cgi?id=374971 > > But perhaps they're not fully related and the situation with wayland has > changed a lot since then. OK, I updated both of those to note that they are still problems in Plasma 6 Beta 2 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 --- Comment #2 from iodream...@gmail.com --- (In reply to Doug from comment #1) > Created attachment 164765 [details] > Task switcher previews piling up > > Can reproduce. Also, task switcher previews don't go away, even after > exiting System Settings. Should I submit a separate bug for that? Feel free to do so, I also see this behavior. The only reason i didn't report it was because i saw similar reports from years ago. https://bugs.kde.org/show_bug.cgi?id=462076 https://bugs.kde.org/show_bug.cgi?id=374971 But perhaps they're not fully related and the situation with wayland has changed a lot since then. -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Doug changed: What|Removed |Added CC||dougsha...@protonmail.com --- Comment #1 from Doug --- Created attachment 164765 --> https://bugs.kde.org/attachment.cgi?id=164765=edit Task switcher previews piling up Can reproduce. Also, task switcher previews don't go away, even after exiting System Settings. Should I submit a separate bug for that? -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Nicolas Fella changed: What|Removed |Added CC||isma...@gmail.com, ||nicolas.fe...@gmx.de -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 479552] Cover Switch and Flip switch preview buttons don't work
https://bugs.kde.org/show_bug.cgi?id=479552 Bug Janitor Service changed: What|Removed |Added Keywords||qt6 -- You are receiving this mail because: You are watching all bug changes.
