[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 Ralf Habacker changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/umbr ||ello/27687f8a180685a8472982 ||3ce7f84a668c0a3da1 Status|ASSIGNED|RESOLVED Version Fixed In||2.20.1 (KDE Applications ||16.08.1) --- Comment #10 from Ralf Habacker --- Git commit 27687f8a180685a84729823ce7f84a668c0a3da1 by Ralf Habacker. Committed on 27/08/2016 at 06:56. Pushed by habacker into branch 'Applications/16.08'. Fix 'Import from java code don't read abstract classes'. Bug is caused by reseting UMLObject::m_isAbstract in UMLClassifier::setBaseType(). A similar bug in C# import is also fixed with this commit. FIXED-IN:2.20.1 (KDE Applications 16.08.1) M +2-1umbrello/codeimport/csharp/csharpimport.cpp M +2-1umbrello/codeimport/javaimport.cpp http://commits.kde.org/umbrello/27687f8a180685a84729823ce7f84a668c0a3da1 -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 --- Comment #9 from Ralf Habacker --- Created attachment 100790 --> https://bugs.kde.org/attachment.cgi?id=100790&action=edit testcase -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 Ralf Habacker changed: What|Removed |Added Assignee|laysrodriguessi...@gmail.co |ralf.habac...@freenet.de |m | -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 Ralf Habacker changed: What|Removed |Added Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777
--- Comment #8 from Ralf Habacker ---
(In reply to Lays Rodrigues from comment #7)
> BTW, I think that the status isAbstract isn't being set to the UMLObject.
> javaimport.cpp 421
> if (keyword == QLatin1String("abstract")) {
> m_isAbstract = true;
> return true;
> }
> it returns to:
> nativeimportbase.cpp 479
> if (! parseStmt())
>skipStmt();
> m_comment.clear();
> But I didn't find the place that the data of javaImport is handled, and that
> I mean, where the data from JavaImport is set to UMLObject.
search for m_isAbstract. You will find several occurences in javaimport.cpp
304: m_klass->setAbstract(m_isAbstract);
549: Import_Utils::insertMethod(m_klass, op, m_currentAccess, typeName,
m_isStatic, m_isAbstract, false
/*isFriend*/,
false /*isConstructor*/, m_comment);
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777
--- Comment #7 from Lays Rodrigues ---
BTW, I think that the status isAbstract isn't being set to the UMLObject.
javaimport.cpp 421
if (keyword == QLatin1String("abstract")) {
m_isAbstract = true;
return true;
}
it returns to:
nativeimportbase.cpp 479
if (! parseStmt())
skipStmt();
m_comment.clear();
But I didn't find the place that the data of javaImport is handled, and that I
mean, where the data from JavaImport is set to UMLObject.
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 Lays Rodrigues changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 --- Comment #5 from Lays Rodrigues --- Previous comment about the confirmation of the bug. -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777
--- Comment #6 from Lays Rodrigues ---
Ralf, i'm looking to the code to try fix this bug, in the part of the code
below, i get confused. The type of comparation using QLatin1String isn't more
slow that integer comparison?
umlobject.cpp line 1000
if (element.hasAttribute(QLatin1String("abstract"))) { // for bkwd compat.
QString abstract = element.attribute(QLatin1String("abstract"),
QLatin1String("0"));
m_bAbstract = (bool)abstract.toInt();
} else {
QString isAbstract = element.attribute(QLatin1String("isAbstract"),
QLatin1String("false"));
m_bAbstract = (isAbstract == QLatin1String("true"));
}
--
You are receiving this mail because:
You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 --- Comment #4 from Lays Rodrigues --- Created attachment 98869 --> https://bugs.kde.org/attachment.cgi?id=98869&action=edit Print of the class I had confirmed the bug. The name of the class isn't appearing using *Italic* font, that is the notation of the Abstract Class in UML. This is the code that I used like example: https://paste.kde.org/pelpgwcqe -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 --- Comment #3 from Ralf Habacker --- @Lays: Please add java files showing this issue to this bug. On the internet there are examples for the usage of abstract classes. -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 --- Comment #2 from Enzo Cappa --- This bug is more than 7 years old. I don't know if it's still valid, and I'm not using umbrello anymore. I can't provide any further feedback. Feel free to close it if nobody else is interested. -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 Ralf Habacker changed: What|Removed |Added Assignee|umbrello-de...@kde.org |laysrodriguessi...@gmail.co ||m -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 173777] import from java code don't read abstract classes
https://bugs.kde.org/show_bug.cgi?id=173777 Ralf Habacker changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC||ralf.habac...@freenet.de Resolution|--- |WAITINGFORINFO --- Comment #1 from Ralf Habacker --- Please provide working java test case -- You are receiving this mail because: You are watching all bug changes.
