[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2021-02-11 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=429181

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In|2.33.80 (KDE releases   |2.33.80 (KDE releases
   |21.04.80)   |21.03.80)

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2021-02-11 Thread Ralf Habacker
https://bugs.kde.org/show_bug.cgi?id=429181

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In|2.33.80 (KDE Applications   |2.33.80 (KDE releases
   |21.04.80)   |21.04.80)

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2021-02-11 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=429181

Oliver Kellogg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
   Version Fixed In||2.33.80 (KDE Applications
   ||21.04.80)
  Latest Commit||https://invent.kde.org/sdk/
   ||umbrello/commit/97ed260f37a
   ||d4040bf9b78db1c1259a4b5d820
   ||22

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2020-11-22 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=429181

--- Comment #4 from Oliver Kellogg  ---
Git commit 97ed260f37ad4040bf9b78db1c1259a4b5d82022 by Oliver Kellogg.
Committed on 22/11/2020 at 20:15.
Pushed by okellogg into branch 'master'.

umbrello/umlscene.cpp followup to commit 87abeac fix for bug 429181
- In function clearSelected iterate over selectedItems() for calling
  WidgetBase::setSelected(false) on each item.

M  +7-0umbrello/umlscene.cpp

https://invent.kde.org/sdk/umbrello/commit/97ed260f37ad4040bf9b78db1c1259a4b5d82022

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2020-11-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=429181

--- Comment #3 from Oliver Kellogg  ---
As far as I experimented, commit
https://invent.kde.org/sdk/umbrello/commit/87abeac31e59542eb60c1f08c2a0d4abfa29237a
fixes the problem.
However, it is hard to test all possible usage scenarios of diagram object
selection.
I appreciate your verification.

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2020-11-21 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=429181

--- Comment #2 from Oliver Kellogg  ---
Git commit 87abeac31e59542eb60c1f08c2a0d4abfa29237a by Oliver Kellogg.
Committed on 21/11/2020 at 23:07.
Pushed by okellogg into branch 'master'.

umbrello/umlwidgets/umlwidget.cpp : Proposed fix for bug 429181
- In functions mousePressEvent and mouseReleaseEvent, on calling
  m_scene->selectedCount() leave argument filterText at default value
  (false).  Reason: On distinguishing single vs multi selection all
  selected FloatingTexts shall be considered.
- In function mouseReleaseEvent handling of m_resized == true call
  deselect(event).

M  +3-2umbrello/umlwidgets/umlwidget.cpp

https://invent.kde.org/sdk/umbrello/commit/87abeac31e59542eb60c1f08c2a0d4abfa29237a

-- 
You are receiving this mail because:
You are watching all bug changes.

[umbrello] [Bug 429181] In sequence diagrams, selection markers are sometimes not removed

2020-11-19 Thread Oliver Kellogg
https://bugs.kde.org/show_bug.cgi?id=429181

Oliver Kellogg  changed:

   What|Removed |Added

 CC||okellogg@users.sourceforge.
   ||net

--- Comment #1 from Oliver Kellogg  ---
As far as I experimented, the sticking markers only seem to happen on the
operation FloatingTexts of MessageWidgets.
Also when the sticking happens, QGraphicsObjectWrapper::itemChange() no longer
fires (at least not for change == ItemSelectedChange && scene());
only UMLWidget::mousePressEvent() continues to get triggered.
Could it be that we have competition between QGraphicsObjectWrapper::itemChange
and UMLWidget::mousePressEvent ?

-- 
You are receiving this mail because:
You are watching all bug changes.