[valgrind] [Bug 358213] helgrind/drd bar_bad testcase hangs with new glibc pthread barrier implementation

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358213

--- Comment #7 from Julian Seward  ---
Should we close this now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358213] helgrind/drd bar_bad testcase hangs with new glibc pthread barrier implementation

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358213

--- Comment #6 from Mark Wielaard  ---
I checked in a workaround for the hang based on the attachement as valgrind svn
r15962.

This does make sure that the tests don't hang indefenitely. But they do
introduce (more) non-determinism that occassionally causes these tests to fail
or even trigger an internal drd assert (drd_barrier.c:352
(vgDrd_barrier_pre_wait): Assertion 'p' failed.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358213] helgrind/drd bar_bad testcase hangs with new glibc pthread barrier implementation

[Ivo Raisr via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358213

Ivo Raisr  changed:

   What|Removed |Added

 CC||iv...@ivosh.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358213] helgrind/drd bar_bad testcase hangs with new glibc pthread barrier implementation

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358213

Mark Wielaard  changed:

   What|Removed |Added

  Attachment #96738|0   |1
is obsolete||

--- Comment #4 from Mark Wielaard  ---
Created attachment 96765
  --> https://bugs.kde.org/attachment.cgi?id=96765=edit
pthread_barrier-vs-newer-glibc-implementation-drd-helgrind

Simplest option to solve the drd issue is to do like in the helgrind case and
have two variants of the exp files. One of which will have
pthread_barrier_destroy hang, and so then drd will just not see that it wasn't
a barrier. Which isn't ideal, but since it is the last test in the batch it
seems it doesn't impact things too much.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358213] helgrind/drd bar_bad testcase hangs with new glibc pthread barrier implementation

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358213

Mark Wielaard  changed:

   What|Removed |Added

Summary|helgrind bar_bad testcase   |helgrind/drd bar_bad
   |hangs with new glibc|testcase hangs with new
   |pthread barrier |glibc pthread barrier
   |implementation  |implementation

--- Comment #3 from Mark Wielaard  ---
The problem fixing this for drd is that DRD_(barrier_destroy) is called after
pthread_barrier_destroy. But that call might now hang and then bar_bad invokes
a watchdog to exit the program, so the post handler is never called.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 358213] helgrind/drd bar_bad testcase hangs with new glibc pthread barrier implementation

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358213

--- Comment #5 from Mark Wielaard  ---
Note that patch is missing the drd/test/Makefile.am addition of the two extra
exp file:

diff --git a/drd/tests/Makefile.am b/drd/tests/Makefile.am
index 2885391..cfd74d0 100644
--- a/drd/tests/Makefile.am
+++ b/drd/tests/Makefile.am
@@ -81,8 +81,10 @@ EXTRA_DIST =\
atomic_var.stderr.exp   \
atomic_var.vgtest   \
bar_bad.stderr.exp  \
+   bar_bad.stderr.exp-nohang   \
bar_bad.vgtest  \
bar_bad_xml.stderr.exp  \
+   bar_bad_xml.stderr.exp-nohang   \
bar_bad_xml.vgtest  \
bar_trivial.stderr.exp  \
bar_trivial.stdout.exp  \

-- 
You are receiving this mail because:
You are watching all bug changes.