[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

Julian Seward  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Petar Jovanovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #11 from Petar Jovanovic  ---
This issue can be closed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Petar Jovanovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #10 from Petar Jovanovic  ---
(In reply to Aleksandar Rikalo from comment #6)
> Created attachment 100684 [details]
> MIPS64 version of test

The test commited as r16004.
Thank you for these changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Petar Jovanovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #9 from Petar Jovanovic  ---
(In reply to Aleksandar Rikalo from comment #5)
> Created attachment 100683 [details]
> FP32 support on MIPS64
> 
> Support for FP32 emulation on MIPS64 platforms (including
> prctl(GET/SET_FP_MODE)  syscalls).

Committed as:

VEX r3253
Valgrind r16003.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Petar Jovanovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #8 from Petar Jovanovic  ---
(In reply to Aleksandar Rikalo from comment #2)
> Created attachment 100287 [details]
> MIPS32 test for syscalls prctl(GET/SET_FP_MODE)

The test commited as r16001.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #7 from Julian Seward  ---
Petar, is it possible you could test/land the follow-on patches in
comment 5 and comment 6?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Aleksandar Rikalo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #6 from Aleksandar Rikalo  ---
Created attachment 100684
  --> https://bugs.kde.org/attachment.cgi?id=100684=edit
MIPS64 version of test

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Aleksandar Rikalo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #5 from Aleksandar Rikalo  ---
Created attachment 100683
  --> https://bugs.kde.org/attachment.cgi?id=100683=edit
FP32 support on MIPS64

Support for FP32 emulation on MIPS64 platforms (including
prctl(GET/SET_FP_MODE)  syscalls).

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Petar Jovanovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #4 from Petar Jovanovic  ---
(In reply to Aleksandar Rikalo from comment #2)
> Created attachment 100287 [details]
> MIPS32 test for syscalls prctl(GET/SET_FP_MODE)

Can you make similar changes for MIPS64 for prctl(GET/SET_FP_MODE), so this
test can be correctly executed for MIPS64 as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Petar Jovanovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

Petar Jovanovic  changed:

   What|Removed |Added

 CC||mips3...@gmail.com

--- Comment #3 from Petar Jovanovic  ---
(In reply to Aleksandar Rikalo from comment #1)
> Created attachment 100286 [details]
> Support for mips32 FPXX
> 
> With this patch, MIPS32 Valgrind compiled with -mfpxx can handle all types
> (regarding FP_ABI flag) of MIPS32 ELFs.
> 
> - Functions arch_elf_pt_proc() and arch_check_elf() are added to elf reader
> according to linux/fs/binfmt_elf.c from Linux 4.1;
> - Processing .MIPS.abiflags section and initializing appropriate FPU mode
> for MIPS32 are added;
> - Emulation of prctl(GET/SET_FP_MODE) sys-calls are implemented for MIPS32.
> 
> Applying the patch:
> patch -p1 < mips_fpxx_full_support.diff
> 
> The patch is tested on MIPS32 platforms with Linux 3.13 and 4.1.
> Also, there are no regressions on MIPS64.
> 
> Regtests need to be performed on other architectures.

The patch with minor modifications committed as:

VEX r3243.
Valgrind r15934.

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Aleksandar Rikalo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

--- Comment #2 from Aleksandar Rikalo  ---
Created attachment 100287
  --> https://bugs.kde.org/attachment.cgi?id=100287=edit
MIPS32 test for syscalls prctl(GET/SET_FP_MODE)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 366079] FPXX Support for MIPS32 Valgrind

[Aleksandar Rikalo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366079

Aleksandar Rikalo  changed:

   What|Removed |Added

 CC||aleksandar.rik...@imgtec.co
   ||m

--- Comment #1 from Aleksandar Rikalo  ---
Created attachment 100286
  --> https://bugs.kde.org/attachment.cgi?id=100286=edit
Support for mips32 FPXX

With this patch, MIPS32 Valgrind compiled with -mfpxx can handle all types
(regarding FP_ABI flag) of MIPS32 ELFs.

- Functions arch_elf_pt_proc() and arch_check_elf() are added to elf reader
according to linux/fs/binfmt_elf.c from Linux 4.1;
- Processing .MIPS.abiflags section and initializing appropriate FPU mode for
MIPS32 are added;
- Emulation of prctl(GET/SET_FP_MODE) sys-calls are implemented for MIPS32.

Applying the patch:
patch -p1 < mips_fpxx_full_support.diff

The patch is tested on MIPS32 platforms with Linux 3.13 and 4.1.
Also, there are no regressions on MIPS64.

Regtests need to be performed on other architectures.

-- 
You are receiving this mail because:
You are watching all bug changes.