[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #28 from Paul Floyd --- (In reply to Peter Maydell from comment #17) > The Linux kernel documents which ID registers and which fields in those > registers it exposes here: > https://www.kernel.org/doc/Documentation/arm64/cpu-feature-registers.txt . > Does FreeBSD expose the same set, or a different set? A different set. There are 16 handled on linux but not FreeBSD 1 handled on FreeBSD but not linux and 39 handled by both -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #27 from Paul Floyd --- Created attachment 169062 --> https://bugs.kde.org/attachment.cgi?id=169062&action=edit arm64id output on linux under Valgrind -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #26 from Paul Floyd --- Created attachment 169061 --> https://bugs.kde.org/attachment.cgi?id=169061&action=edit arm64id output on linux standalone -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #25 from Paul Floyd --- Created attachment 169059 --> https://bugs.kde.org/attachment.cgi?id=169059&action=edit arm64id output on FreeBSD under Valgrind -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #24 from Paul Floyd --- Created attachment 169058 --> https://bugs.kde.org/attachment.cgi?id=169058&action=edit arm64id output on FreeBSD standalone -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #23 from Paul Floyd --- Never mind. I'm going to have to go through everything thoroughly. I asked the FreeBSD dev that worked on aarch64 and he pointed me to this github repo he used during development https://github.com/zxombie/arm64id (with macros that make my eyes bleed and some abomination use of __attribute__section to pretend that a bunch of individual structs are a single array) I'll attach the results for comparison with Linux. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added CC||mbrug...@suse.com --- Comment #22 from Matthias Brugger --- (In reply to Paul Floyd from comment #13) > Do you have any tests for this? Unfortunately after such a long time I'm not able to find the reproducer. At that time I remeber that is was some code in glibc that invoked reads of MDIR_EL1. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Paul Floyd changed: What|Removed |Added CC||stephane.ouelle...@zebra.co ||m --- Comment #21 from Paul Floyd --- *** Bug 466732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #20 from Paul Floyd --- Created attachment 168951 --> https://bugs.kde.org/attachment.cgi?id=168951&action=edit Attachment from 466732 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Paul Floyd changed: What|Removed |Added CC||jonathan.girardeau@airudit. ||com --- Comment #19 from Paul Floyd --- *** Bug 450203 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #18 from Paul Floyd --- (In reply to Peter Maydell from comment #17) > The Linux kernel documents which ID registers and which fields in those > registers it exposes here: > https://www.kernel.org/doc/Documentation/arm64/cpu-feature-registers.txt . > Does FreeBSD expose the same set, or a different set? I don't know of any such document. I expect that they are similar since FreeBSD has a linux compatibility layer and it sets possibly different HWCAPs for FreeBSD apps and for Linux apps running under the compat layer. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #17 from Peter Maydell --- The Linux kernel documents which ID registers and which fields in those registers it exposes here: https://www.kernel.org/doc/Documentation/arm64/cpu-feature-registers.txt . Does FreeBSD expose the same set, or a different set? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #16 from Paul Floyd --- And the patch seems to work, with the patch FF proceeds until it hits a SIGBUS (which is what I was looking for). I'll look at it in more detail. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Paul Floyd changed: What|Removed |Added CC||pjfl...@wanadoo.fr Assignee|jsew...@acm.org |pjfl...@wanadoo.fr --- Comment #15 from Paul Floyd --- Well it's time for me to look at this again. I just tried to run Firefox on FreeBSD under Valgrind and I got ARM64 front end: branch_etc disInstr(arm64): unhandled instruction 0xD5380609 disInstr(arm64): 1101'0101 0011'1000 '0110 '1001 ==2219== valgrind: Unrecognised instruction at address 0xdfa7880. ==2219==at 0xDFA7880: SkCpu::CacheRuntimeFeatures() (in /usr/local/lib/firefox/libxul.so) -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #14 from Matthias Brugger --- I used to have a test for this, but I lost that over the last 6 years. But under "Implementation" https://bugs.kde.org/show_bug.cgi?id=482013 gives a code snipped that can be easily used to create a test. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #13 from Paul Floyd --- Do you have any tests for this? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Paul Floyd changed: What|Removed |Added CC||adam...@gmail.com --- Comment #12 from Paul Floyd --- *** Bug 482013 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added Assignee|matthias@gmail.com |jsew...@acm.org --- Comment #11 from Matthias Brugger --- Julian, Peter, any comments on this patch? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #10 from Matthias Brugger --- any comments on that? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #9 from Matthias Brugger --- Please provide some feedback about the patch. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added Attachment #112966|0 |1 is obsolete|| --- Comment #8 from Matthias Brugger --- Created attachment 113113 --> https://bugs.kde.org/attachment.cgi?id=113113&action=edit Implement emulated system registers. Fixes #392146. Updated version of the patch. I flip the registers of the bits which are not supported in the emulation environment in the dirty helper. Following the example of amd's cpuid. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added Assignee|jsew...@acm.org |matthias@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added Attachment #111541|0 |1 is obsolete|| --- Comment #7 from Matthias Brugger --- Created attachment 112966 --> https://bugs.kde.org/attachment.cgi?id=112966&action=edit implementation of system register emulation Emulate all system register accesses. Return only the bits that are supported by the emulation environment. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #6 from Tom Hughes --- I think you were already told on IRC when you asked that it should provide results which reflect the capabilities of the emulated environment, which in at least some cases is likely to mean not passing on host values. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #5 from Matthias Brugger --- the following system registers are emulated by the kernel: MIDR_EL1 MPIDR_EL1 REVIDR_EL1 ID_AA64PFR0_EL1 ID_AA64PFR1_EL1 ID_AA64ZFR0_EL1 ID_AA64DFR0_EL1 ID_AA64DFR1_EL1 ID_AA64AFR0_EL1 ID_AA64AFR1_EL1 ID_AA64ISAR0_EL1 ID_AA64ISAR1_EL1 ID_AA64MMFR0_EL1 ID_AA64MMFR1_EL1 ID_AA64MMFR2_EL1 I have a patch which just puts faked values into the registers in guest_arm64_toIR.c But I wonder if we would need to actually provide the real values, as this may have influence on the program flow of the code under inspection. The registers give information about the underlying HW, like manufacturer, but also about which HW enhancements are present. Is my assumption correct, that we will need to provide the host values of this registers? Can anyone give guidance in which file/data structure this should be done. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #4 from Matthias Brugger --- (In reply to Peter Maydell from comment #3) > Hi; your patch consistently typos the register name -- it is MIDR_EL1 (for > Main ID Register). > Uups, thanks for noting. > This register is only accessible at EL1 in hardware, though -- I guess your > host kernel is emulating accesses to it? Are there other ID register > accesses that also now need to be emulated in valgrind because the kernel > passes them through to userspace? I'll have to investigate further on this. I'll update the after I can confirm that we only need MIDR access, or I'll add the necessary parts as well. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Peter Maydell changed: What|Removed |Added CC||peter.mayd...@linaro.org --- Comment #3 from Peter Maydell --- Hi; your patch consistently typos the register name -- it is MIDR_EL1 (for Main ID Register). This register is only accessible at EL1 in hardware, though -- I guess your host kernel is emulating accesses to it? Are there other ID register accesses that also now need to be emulated in valgrind because the kernel passes them through to userspace? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added Assignee|matthias@gmail.com |jsew...@acm.org -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 --- Comment #2 from Matthias Brugger --- Created attachment 111541 --> https://bugs.kde.org/attachment.cgi?id=111541&action=edit Iplements "mrs , mdir_el1" for VEX aarch64 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added CC||matthias@gmail.com Ever confirmed|1 |0 Status|CONFIRMED |UNCONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added CC||t...@compton.nu -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added CC||jsew...@acm.org -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 392146] aarch64: unhandled instruction 0xD5380001 (MRS rT, mdir_el1)
https://bugs.kde.org/show_bug.cgi?id=392146 Matthias Brugger changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 Assignee|jsew...@acm.org |matthias@gmail.com --- Comment #1 from Matthias Brugger --- I will provide a patch -- You are receiving this mail because: You are watching all bug changes.
