[valgrind] [Bug 402327] Warning: DWARF2 CFI reader: unhandled DW_OP_ opcode 0x13 (DW_OP_drop)

2018-12-19 Thread Mark Wielaard
https://bugs.kde.org/show_bug.cgi?id=402327

Mark Wielaard  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Wielaard  ---
Thanks for testing. Lets just push this:

commit e4dde1327e1ca1868aabf2b89bc818d37864e3cc
Author: Mark Wielaard 
Date:   Wed Dec 19 20:14:03 2018 +0100

PR402327 Warning: DWARF2 CFI reader: unhandled DW_OP_ opcode 0x13
DW_OP_drop

readdwarf.c (dwarfexpr_to_dag) didn't handle DW_OP_drop.
Implement it by simply popping the last element on the stack.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 402327] Warning: DWARF2 CFI reader: unhandled DW_OP_ opcode 0x13 (DW_OP_drop)

2018-12-19 Thread Nikos Chantziaras
https://bugs.kde.org/show_bug.cgi?id=402327

--- Comment #2 from Nikos Chantziaras  ---
That does indeed help. Warning is gone.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 402327] Warning: DWARF2 CFI reader: unhandled DW_OP_ opcode 0x13 (DW_OP_drop)

2018-12-19 Thread Mark Wielaard
https://bugs.kde.org/show_bug.cgi?id=402327

Mark Wielaard  changed:

   What|Removed |Added

 CC||m...@klomp.org
Summary|Warning: DWARF2 CFI reader: |Warning: DWARF2 CFI reader:
   |unhandled DW_OP_ opcode |unhandled DW_OP_ opcode
   |0x13|0x13 (DW_OP_drop)

--- Comment #1 from Mark Wielaard  ---
That is DW_OP_drop which indeed isn't implemented. But should be trivial to:

diff --git a/coregrind/m_debuginfo/readdwarf.c
b/coregrind/m_debuginfo/readdwarf.c
index 70ab16d67..3b7449a5b 100644
--- a/coregrind/m_debuginfo/readdwarf.c
+++ b/coregrind/m_debuginfo/readdwarf.c
@@ -2853,6 +2853,12 @@ static Int dwarfexpr_to_dag ( const UnwindContext* ctx,
VG_(printf)("DW_OP_deref");
 break;

+ case DW_OP_drop:
+POP( ix );
+if (ddump_frames)
+   VG_(printf)("DW_OP_drop");
+break;
+
  default:
 if (!VG_(clo_xml))
VG_(message)(Vg_DebugMsg, 

Does that help?

-- 
You are receiving this mail because:
You are watching all bug changes.