https://bugs.kde.org/show_bug.cgi?id=444836
--- Comment #3 from Carl Love ---
The two patches in the attachments have been committed.
commit 3950c5d661ee09526cddcf24daf5fc22bc83f70c (HEAD -> master, origin/master,
origin/HEAD)
Author: Carl Love
Date: Mon Nov 1 11:18:32 2021 -0500
Valgrind Add powerpc R=1 tests
Contributed by Will Schmidt
This includes updates and adjustments as suggested by Carl.
Add tests that exercise PCRelative instructions.
These instructions are encoded with R==1, which indicate that
the memory accessed by the instruction is at a location
relative to the currently executing instruction.
These tests are built using -Wl,-text and -Wl,-bss
options to ensure the location of the target array is at a
location with a specific offset from the currently
executing instruction.
The write instructions are aimed at a large buffer in
the bss section; which is checked for updates at the
completion of each test.
In order to ensure consistent output across assorted
systems, the tests have been padded with ori, nop instructions
and align directives.
Detailed changes:
* Makefile.am: Add test_isa_3_1_R1_RT and test_isa_3_1_R1_XT tests.
* isa_3_1_helpers.h: Add identify_instruction_by_func_name() helper
function
to indicate if the test is for R==1.
Add helpers to initialize and print changes to the
pcrelative_write_target
array.
Add #define to help pad code with a series of eyecatcher ORI
instructions.
* test_isa_3_1_R1_RT.c: New test.
* test_isa_3_1_R1_XT.c: New test.
* test_isa_3_1_R1_XT.stdout.exp: New expected output.
* test_isa_3_1_R1_XT.stdout.exp: New expected output.
* test_isa_3_1_R1_RT.stderr.exp: New expected output.
* test_isa_3_1_R1_RT.stderr.exp: New expected output.
* test_isa_3_1_R1_RT.vgtest: New test handler.
* test_isa_3_1_common.c: Add indicators
(updates_byte,updates_halfword,
updates_word) indicators to control the output from the R==1 tests.
Add helper check for "_R1" to indicate if instruction is coded with
R==1.
Add init and print helpers for the pcrelative_write_target array.
commit ae8c6de01417023e78763de145b1c0e6ddd87277
Author: Carl Love
Date: Wed Oct 20 20:40:13 2021 +
Fix for the prefixed stq instruction in PC relative mode.
The pstq instruction for R=1, was not using the correct effective address.
The EA_hi and EA_lo should have been based on the value of EA as calculated
by the function calculate_prefix_EA. Unfortuanely, the EA_hi and EA_lo
addresses were still using the previous code (not PC relative) to calculate
the address from the contants of RA plus the offset.
--
You are receiving this mail because:
You are watching all bug changes.
