[krita] [Bug 452854] Glitches when transforming images
https://bugs.kde.org/show_bug.cgi?id=452854 --- Comment #3 from Dmitry Kazakov --- Hi, acc4commissions! I'm not sure I fully understand what the "glitch" is, is this transparent rectangle appear only temporarily and heals itself or you need to do some specific action to make is disappear? I don't fully undersatnd from the video... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457784] Filter layers generate incorrect preview when bounds change.
https://bugs.kde.org/show_bug.cgi?id=457784 Dmitry Kazakov changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/716923cad ||309ae93ec41d58b6ab44ec46b43 ||4589 --- Comment #1 from Dmitry Kazakov --- Git commit 716923cad309ae93ec41d58b6ab44ec46b434589 by Dmitry Kazakov. Committed on 12/08/2022 at 14:25. Pushed by dkazakov into branch 'master'. Fix update artifacts when trying to transform an adjustment layer M +6-1libs/image/kis_full_refresh_walker.h https://invent.kde.org/graphics/krita/commit/716923cad309ae93ec41d58b6ab44ec46b434589 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456470] Crash in undo stack when doing undo
https://bugs.kde.org/show_bug.cgi?id=456470 --- Comment #15 from Dmitry Kazakov --- Git commit be648b265d825405a5de5219813fae9b73524e4e by Dmitry Kazakov. Committed on 12/08/2022 at 14:25. Pushed by dkazakov into branch 'master'. Make sure that suspend stroke does not reset redo state M +1-0libs/image/kis_suspend_projection_updates_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/be648b265d825405a5de5219813fae9b73524e4e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457784] Filter layers generate incorrect preview when bounds change.
https://bugs.kde.org/show_bug.cgi?id=457784 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/716923cad |hics/krita/commit/820155446 |309ae93ec41d58b6ab44ec46b43 |e947977d2f0ac6cf7b394f56d0f |4589|dd87 --- Comment #2 from Dmitry Kazakov --- Git commit 820155446e947977d2f0ac6cf7b394f56d0fdd87 by Dmitry Kazakov. Committed on 12/08/2022 at 14:26. Pushed by dkazakov into branch 'krita/5.1'. Fix update artifacts when trying to transform an adjustment layer M +6-1libs/image/kis_full_refresh_walker.h https://invent.kde.org/graphics/krita/commit/820155446e947977d2f0ac6cf7b394f56d0fdd87 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456470] Crash in undo stack when doing undo
https://bugs.kde.org/show_bug.cgi?id=456470 --- Comment #16 from Dmitry Kazakov --- Git commit 23e186e2d6fdaa426d8ee6f2c7e731efe9f24973 by Dmitry Kazakov. Committed on 12/08/2022 at 14:26. Pushed by dkazakov into branch 'krita/5.1'. Make sure that suspend stroke does not reset redo state M +1-0libs/image/kis_suspend_projection_updates_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/23e186e2d6fdaa426d8ee6f2c7e731efe9f24973 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447338] Cancel a Filter with Instant Preview won't quit "low resolution preview" until refresh canvas blocks
https://bugs.kde.org/show_bug.cgi?id=447338 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447338] Cancel a Filter with Instant Preview won't quit "low resolution preview" until refresh canvas blocks
https://bugs.kde.org/show_bug.cgi?id=447338 --- Comment #4 from Dmitry Kazakov --- The same issue happens with Move Tool, btw. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455541] A brush preset made with the 5.2.0-prealpha causes a crash in 5.0.6
https://bugs.kde.org/show_bug.cgi?id=455541 --- Comment #8 from Dmitry Kazakov --- Git commit f409ceb9faf236d302a13d5866aae3907bc5e036 by Dmitry Kazakov, on behalf of Agata Cacko. Committed on 15/08/2022 at 10:55. Pushed by dkazakov into branch 'krita/5.1'. Fix crash on incorrect brush preset metadata Before this commit, if you tried to open a brush preset that had incorrect brush metadata (for example any brush saved in Krita 5.1 beta 1, with < changed to < etc.), Krita would crash. This commit ensures it will not crash in that case. It's not an ideal solution, because there is no way to propagate the information about the issue and the safe assert around line 370 in KisBrushBasedPaintOpSettings::regenerateResourceCache() would still be fired. However it's less disruptive for the user. M +6-0plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp https://invent.kde.org/graphics/krita/commit/f409ceb9faf236d302a13d5866aae3907bc5e036 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455541] A brush preset made with the 5.2.0-prealpha causes a crash in 5.0.6
https://bugs.kde.org/show_bug.cgi?id=455541 --- Comment #9 from Dmitry Kazakov --- Git commit 78cca8fbaea96ac37687b8d8ef2c94d8eedb46cd by Dmitry Kazakov, on behalf of Agata Cacko. Committed on 15/08/2022 at 10:55. Pushed by dkazakov into branch 'master'. Fix crash on incorrect brush preset metadata Before this commit, if you tried to open a brush preset that had incorrect brush metadata (for example any brush saved in Krita 5.1 beta 1, with < changed to < etc.), Krita would crash. This commit ensures it will not crash in that case. It's not an ideal solution, because there is no way to propagate the information about the issue and the safe assert around line 370 in KisBrushBasedPaintOpSettings::regenerateResourceCache() would still be fired. However it's less disruptive for the user. M +6-0plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp https://invent.kde.org/graphics/krita/commit/78cca8fbaea96ac37687b8d8ef2c94d8eedb46cd -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447338] Cancel a Filter with Instant Preview won't quit "low resolution preview" until refresh canvas blocks
https://bugs.kde.org/show_bug.cgi?id=447338 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/7cbc18eaf ||16bb5653c1bfc44fc99085a36d4 ||8b94 --- Comment #5 from Dmitry Kazakov --- Git commit 7cbc18eaf16bb5653c1bfc44fc99085a36d48b94 by Dmitry Kazakov. Committed on 17/08/2022 at 07:43. Pushed by dkazakov into branch 'master'. Fix Canvas being stuck in lo-res mode after cancelling Move or Filter action Now when the update scheduler sees that a Lod0 stroke has been cancelled, it notifies the Resume stroke (via its filter) that the GUI should refetch image data for the Lod0 planes inside tiles. M +24 -0libs/image/kis_image.cc M +25 -0libs/image/kis_strokes_queue.cpp M +1-0libs/image/kis_strokes_queue.h M +15 -1libs/image/kis_suspend_projection_updates_stroke_strategy.cpp M +6-3libs/image/kis_suspend_projection_updates_stroke_strategy.h M +5-0libs/image/kis_update_scheduler.cpp M +10 -0libs/image/kis_update_scheduler.h https://invent.kde.org/graphics/krita/commit/7cbc18eaf16bb5653c1bfc44fc99085a36d48b94 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457997] New: Crash when deleting the currently active brush preset
https://bugs.kde.org/show_bug.cgi?id=457997
Bug ID: 457997
Summary: Crash when deleting the currently active brush preset
Product: krita
Version: git master (please specify the git hash!)
Platform: Other
OS: Linux
Status: REPORTED
Severity: crash
Priority: NOR
Component: Resource Management
Assignee: krita-bugs-n...@kde.org
Reporter: dimul...@gmail.com
Target Milestone: ---
STEPS TO REPRODUCE
1. Activate 'Basic-5 Size' preset
2. Open Resource Manager
3. Delete 'Basic-5 Size' preset (from "default4" bundle)
4. Close the resource manager
5. Press "Reload Preset" button
ASSERT: "d->resourceCache[key] == resource" in file
/home/appimage/persistent/krita/libs/resources/KisResourceLocator.cpp, line 739
Thread 1 (Thread 0x7fffe6bbaf40 (LWP 12904) "krita"):
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
set = {__val = {0, 5928219613469820227, 0, 0, 0, 0, 0, 0, 0, 0,
36029346784149647, 52355144541405326, 0, 0, 4619567317775286272, 0}}
pid =
tid =
ret =
#1 0x73fde7f1 in __GI_abort () at abort.c:79
save_stage = 1
act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0},
sa_mask = {__val = {0 , 2}}, sa_flags = -11976, sa_restorer =
0x7fffd138}
sigs = {__val = {32, 0 }}
__cnt =
__set =
__cnt =
__set =
#2 0x74a39fab in QMessageLogger::fatal(char const*, ...) const () from
/home/appimage/appimage-workspace/deps/usr/lib/libQt5Core.so.5
No symbol table info available.
#3 0x74a397a1 in qt_assert(char const*, char const*, int) () from
/home/appimage/appimage-workspace/deps/usr/lib/libQt5Core.so.5
No symbol table info available.
#4 0x760efe8b in KisResourceLocator::reloadResource (this=, resourceType=..., resource=...) at
/home/appimage/persistent/krita/libs/resources/KisResourceLocator.cpp:739
storageLocation = {d = 0x6373d020}
__PRETTY_FUNCTION__ = "bool KisResourceLocator::reloadResource(const
QString&, KoResourceSP)"
storage = {value = 0x595b0c10, d = 0x595b0c00}
key = {first = {d = 0x6373d020}, second = {d = 0x63d84a20}}
#5 0x76143505 in KisAllResourcesModel::reloadResource
(this=0x596db710, resource=...) at
/home/appimage/persistent/krita/libs/resources/KisResourceModel.cpp:501
__PRETTY_FUNCTION__ = "virtual bool
KisAllResourcesModel::reloadResource(KoResourceSP)"
index = {r = 1578834496, c = 21845, i = 93825139415600, m =
0x596db720}
#6 0x76142b7a in KisResourceModel::reloadResource (this=, resource=...) at
/home/appimage/persistent/krita/libs/resources/KisResourceModel.cpp:904
source =
#7 0x7751f581 in KoResourceServer::reloadResource
(this=this@entry=0x596c30b0, resource=...) at
/home/appimage/persistent/krita/libs/resources/KoResourceServer.h:271
__PRETTY_FUNCTION__ = "bool
KoResourceServer::reloadResource(QSharedPointer) [with T =
KisPaintOpPreset]"
#8 0x7751370a in KisPaintopBox::slotReloadPreset (this=0x59277710)
at /home/appimage/persistent/krita/libs/ui/kis_paintop_box.cc:1356
result =
blocker = {m_objects = {d = 0x63ff1a10}}
rserver = 0x596c30b0
preset = {value = 0x5e1b1a40, d = 0x5e1b1a30}
#9 0x74c78575 in QMetaObject::activate(QObject*, int, int, void**) ()
from /home/appimage/appimage-workspace/deps/usr/lib/libQt5Core.so.5
No symbol table info available.
#10 0x756b9712 in QAction::triggered(bool) () from
/home/appimage/appimage-workspace/deps/usr/lib/libQt5Widgets.so.5
No symbol table info available.
#11 0x756bbd3c in QAction::activate(QAction::ActionEvent) () from
/home/appimage/appimage-workspace/deps/usr/lib/libQt5Widgets.so.5
No symbol table info available.
#12 0x757a96fb in ?? () from
/home/appimage/appimage-workspace/deps/usr/lib/libQt5Widgets.so.5
No symbol table info available.
#13 0x757a996d in QAbstractButton::mouseReleaseEvent(QMouseEvent*) ()
from /home/appimage/appimage-workspace/deps/usr/lib/libQt5Widgets.so.5
No symbol table info available.
#14 0x7589951a in QToolButton::mouseReleaseEvent(QMouseEvent*) () from
/home/appimage/appimage-workspace/deps/usr/lib/libQt5Widgets.so.5
No symbol table info available.
[... cut...]
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 445206] MYPAINT: bugs of mypaint brush engine‘s “eraser” option
https://bugs.kde.org/show_bug.cgi?id=445206 Dmitry Kazakov changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/93bf757c4 ||e4e2bfd9e53eb6b31c8117cd983 ||03cf Resolution|--- |FIXED --- Comment #4 from Dmitry Kazakov --- Git commit 93bf757c4e4e2bfd9e53eb6b31c8117cd98303cf by Dmitry Kazakov, on behalf of Carsten Hartenfels. Committed on 05/09/2022 at 12:15. Pushed by dkazakov into branch 'master'. Make MyPaint eraser use the proper brush settings When enabling eraser mode, Krita will use the default MyPaint brush settings instead of the ones the user has actually selected. This is unlike MyPaint, GIMP and Drawpile do it, which use the selected brush to erase. This is due to a setting that enables this odd behavior, which is not actually exposed in the user interface, meaning there's no way to turn it off. This commit outright removes that setting and makes Krita behave properly: use the brush that's selected and erase with it, don't switch to something else behind the scenes. M +1-8plugins/paintops/mypaint/MyPaintPaintOp.cpp M +0-3plugins/paintops/mypaint/MyPaintPaintOpOption.h M +0-1plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp https://invent.kde.org/graphics/krita/commit/93bf757c4e4e2bfd9e53eb6b31c8117cd98303cf -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445206] MYPAINT: bugs of mypaint brush engine‘s “eraser” option
https://bugs.kde.org/show_bug.cgi?id=445206 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/93bf757c4 |hics/krita/commit/77026701d |e4e2bfd9e53eb6b31c8117cd983 |2dee602aceef4e5e9ae7e72056f |03cf|b54b --- Comment #5 from Dmitry Kazakov --- Git commit 77026701d2dee602aceef4e5e9ae7e72056fb54b by Dmitry Kazakov, on behalf of Carsten Hartenfels. Committed on 05/09/2022 at 12:16. Pushed by dkazakov into branch 'cherry-pick-93bf757c'. Make MyPaint eraser use the proper brush settings When enabling eraser mode, Krita will use the default MyPaint brush settings instead of the ones the user has actually selected. This is unlike MyPaint, GIMP and Drawpile do it, which use the selected brush to erase. This is due to a setting that enables this odd behavior, which is not actually exposed in the user interface, meaning there's no way to turn it off. This commit outright removes that setting and makes Krita behave properly: use the brush that's selected and erase with it, don't switch to something else behind the scenes. (cherry picked from commit 93bf757c4e4e2bfd9e53eb6b31c8117cd98303cf) M +1-8plugins/paintops/mypaint/MyPaintPaintOp.cpp M +0-3plugins/paintops/mypaint/MyPaintPaintOpOption.h M +0-1plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp https://invent.kde.org/graphics/krita/commit/77026701d2dee602aceef4e5e9ae7e72056fb54b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445206] MYPAINT: bugs of mypaint brush engine‘s “eraser” option
https://bugs.kde.org/show_bug.cgi?id=445206 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/77026701d |hics/krita/commit/fe72fd221 |2dee602aceef4e5e9ae7e72056f |c8315b15a203022402a64cc64f8 |b54b|5343 --- Comment #6 from Dmitry Kazakov --- Git commit fe72fd221c8315b15a203022402a64cc64f85343 by Dmitry Kazakov, on behalf of Carsten Hartenfels. Committed on 05/09/2022 at 12:17. Pushed by dkazakov into branch 'krita/5.1'. Make MyPaint eraser use the proper brush settings When enabling eraser mode, Krita will use the default MyPaint brush settings instead of the ones the user has actually selected. This is unlike MyPaint, GIMP and Drawpile do it, which use the selected brush to erase. This is due to a setting that enables this odd behavior, which is not actually exposed in the user interface, meaning there's no way to turn it off. This commit outright removes that setting and makes Krita behave properly: use the brush that's selected and erase with it, don't switch to something else behind the scenes. (cherry picked from commit 93bf757c4e4e2bfd9e53eb6b31c8117cd98303cf) M +1-8plugins/paintops/mypaint/MyPaintPaintOp.cpp M +0-3plugins/paintops/mypaint/MyPaintPaintOpOption.h M +0-1plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp https://invent.kde.org/graphics/krita/commit/fe72fd221c8315b15a203022402a64cc64f85343 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458546] Crash when selecting a third layer in the layerbox
https://bugs.kde.org/show_bug.cgi?id=458546 --- Comment #6 from Dmitry Kazakov --- Git commit a1c960421e0cc26c815bc9d50ed1d2db7dabd4f9 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 05/09/2022 at 13:09. Pushed by dkazakov into branch 'master'. KisTransaction: fix dud assertions Bug 458546 should've been caught by any of the assertions, but since they depend on a debug version of Qt, the exception slips past... M +19 -15 libs/image/kis_transaction.h https://invent.kde.org/graphics/krita/commit/a1c960421e0cc26c815bc9d50ed1d2db7dabd4f9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458546] Crash when selecting a third layer in the layerbox
https://bugs.kde.org/show_bug.cgi?id=458546 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/cc87eb078 ||dc30ef1e3b0b411d6da628339a5 ||4d0a --- Comment #7 from Dmitry Kazakov --- Git commit cc87eb078dc30ef1e3b0b411d6da628339a54d0a by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 05/09/2022 at 13:09. Pushed by dkazakov into branch 'master'. MoveStrokeStrategy: fix false recursion in stroke finalization The nested recursion over m_nodes means that the strategies will be executed at least twice for each node. This is inconsistent with the rest of commit 4a427ee619a507c80e3f5599221591e802a38a54, so let's fix that. CCMAIL: dimul...@gmail.com M +6-7libs/ui/tool/strokes/move_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/cc87eb078dc30ef1e3b0b411d6da628339a54d0a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458211] Highlighted session item in session manager is sometimes replaced with text input prompt
https://bugs.kde.org/show_bug.cgi?id=458211 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/e9ac0ac4e ||0d7b4b4541fa355d445d53b69f1 ||5365 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #3 from Dmitry Kazakov --- Git commit e9ac0ac4e0d7b4b4541fa355d445d53b69f15365 by Dmitry Kazakov, on behalf of Freya Lupen. Committed on 05/09/2022 at 14:26. Pushed by dkazakov into branch 'master'. Don't allow text edit in Sessions list Also check if new Session has a name before adding. M +2-0libs/ui/dialogs/KisSessionManagerDialog.cpp https://invent.kde.org/graphics/krita/commit/e9ac0ac4e0d7b4b4541fa355d445d53b69f15365 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458211] Highlighted session item in session manager is sometimes replaced with text input prompt
https://bugs.kde.org/show_bug.cgi?id=458211 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/e9ac0ac4e |hics/krita/commit/166fa488d |0d7b4b4541fa355d445d53b69f1 |89cb9dfd9e92ec4c515a5149be9 |5365|3ae5 --- Comment #4 from Dmitry Kazakov --- Git commit 166fa488d89cb9dfd9e92ec4c515a5149be93ae5 by Dmitry Kazakov, on behalf of Freya Lupen. Committed on 05/09/2022 at 14:28. Pushed by dkazakov into branch 'krita/5.1'. Don't allow text edit in Sessions list Also check if new Session has a name before adding. (cherry picked from commit e9ac0ac4e0d7b4b4541fa355d445d53b69f15365) M +2-0libs/ui/dialogs/KisSessionManagerDialog.cpp https://invent.kde.org/graphics/krita/commit/166fa488d89cb9dfd9e92ec4c515a5149be93ae5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 401940] More than one Assistant Tool causes black rectangle to appear
https://bugs.kde.org/show_bug.cgi?id=401940 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/01514224c |hics/krita/commit/5b52e5495 |c4558d94c67eb2b8e9feeabec8a |2280f49d89476d2711a746005a6 |b89c|7462 Resolution|--- |FIXED --- Comment #36 from Dmitry Kazakov --- Git commit 5b52e54952280f49d89476d2711a746005a67462 by Dmitry Kazakov, on behalf of Sharaf Zaman. Committed on 05/09/2022 at 14:54. Pushed by dkazakov into branch 'master'. Make the OpenGL workaround available for all platforms M +10 -0libs/ui/dialogs/kis_dlg_preferences.cc M +65 -49 libs/ui/forms/wdgdisplaysettings.ui M +3-5libs/ui/opengl/kis_opengl.cpp https://invent.kde.org/graphics/krita/commit/5b52e54952280f49d89476d2711a746005a67462 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458647] Typo in Japanese Animation template
https://bugs.kde.org/show_bug.cgi?id=458647 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/772c41e64 |hics/krita/commit/982caf9ca |16afe49a5954c765c8a7ce676ce |377ef0f81b344fefd6d4cfa19ae |87f4|a31e --- Comment #3 from Dmitry Kazakov --- Git commit 982caf9ca377ef0f81b344fefd6d4cfa19aea31e by Dmitry Kazakov, on behalf of Freya Lupen. Committed on 06/09/2022 at 08:09. Pushed by dkazakov into branch 'krita/5.1'. Fix typo in Japanese Animation template 'Blaack' to 'Black'. Also make use of fullwidth characters consistent; use fullwidth in JP, halfwidth in EN. Also remove extraneous spaces which are assumed to be unintentional. (cherry picked from commit 772c41e6416afe49a5954c765c8a7ce676ce87f4) M +---krita/data/templates/animation/Anim-Jp-EN.kra M +---krita/data/templates/animation/Anim-Jp-JP.kra https://invent.kde.org/graphics/krita/commit/982caf9ca377ef0f81b344fefd6d4cfa19aea31e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458546] Crash when selecting a third layer in the layerbox
https://bugs.kde.org/show_bug.cgi?id=458546 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/cc87eb078 |hics/krita/commit/82d48e2bc |dc30ef1e3b0b411d6da628339a5 |badb4c69cecd86e82950b7fbe5b |4d0a|ff37 --- Comment #8 from Dmitry Kazakov --- Git commit 82d48e2bcbadb4c69cecd86e82950b7fbe5bff37 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 06/09/2022 at 09:51. Pushed by dkazakov into branch 'krita/5.1'. MoveStrokeStrategy: fix false recursion in stroke finalization The nested recursion over m_nodes means that the strategies will be executed at least twice for each node. This is inconsistent with the rest of commit 4a427ee619a507c80e3f5599221591e802a38a54, so let's fix that. CCMAIL: dimul...@gmail.com (cherry picked from commit cc87eb078dc30ef1e3b0b411d6da628339a54d0a) M +6-7libs/ui/tool/strokes/move_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/82d48e2bcbadb4c69cecd86e82950b7fbe5bff37 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458546] Crash when selecting a third layer in the layerbox
https://bugs.kde.org/show_bug.cgi?id=458546 --- Comment #9 from Dmitry Kazakov --- Git commit f22b8c182dd623d423eed3996af7a2050ac22cc7 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 06/09/2022 at 09:51. Pushed by dkazakov into branch 'krita/5.1'. KisTransaction: fix dud assertions Bug 458546 should've been caught by any of the assertions, but since they depend on a debug version of Qt, the exception slips past... (cherry picked from commit a1c960421e0cc26c815bc9d50ed1d2db7dabd4f9) M +19 -15 libs/image/kis_transaction.h https://invent.kde.org/graphics/krita/commit/f22b8c182dd623d423eed3996af7a2050ac22cc7 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445206] MYPAINT: bugs of mypaint brush engine‘s “eraser” option
https://bugs.kde.org/show_bug.cgi?id=445206 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/fe72fd221 |hics/krita/commit/1576bf60a |c8315b15a203022402a64cc64f8 |e59947c2bb7131bd2e6c07be242 |5343|7d56 --- Comment #7 from Dmitry Kazakov --- Git commit 1576bf60ae59947c2bb7131bd2e6c07be2427d56 by Dmitry Kazakov, on behalf of Carsten Hartenfels. Committed on 06/09/2022 at 11:12. Pushed by dkazakov into branch 'master'. Fix disabling blend mode combo for MyPaint brushes MyPaint brushes don't support custom blend modes, they always use what MyPaint calls "Normal and Erase". The code already made an attempt to disable the blend mode combo box to represent that, but switching tools caused it to re-enable itself, despite having no effect. This commit fixes that: the brush blend mode combo box gets disabled upon switching tools if a MyPaint brush preset is selected. It also adds a comment explaining the reason behind that rather non-obvious special case. M +8-1libs/ui/kis_paintop_box.cc https://invent.kde.org/graphics/krita/commit/1576bf60ae59947c2bb7131bd2e6c07be2427d56 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445206] MYPAINT: bugs of mypaint brush engine‘s “eraser” option
https://bugs.kde.org/show_bug.cgi?id=445206 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/1576bf60a |hics/krita/commit/896ddd0c0 |e59947c2bb7131bd2e6c07be242 |933bf3dc07b996962c61331220c |7d56|7a01 --- Comment #8 from Dmitry Kazakov --- Git commit 896ddd0c0933bf3dc07b996962c61331220c7a01 by Dmitry Kazakov, on behalf of Carsten Hartenfels. Committed on 06/09/2022 at 11:14. Pushed by dkazakov into branch 'krita/5.1'. Fix disabling blend mode combo for MyPaint brushes MyPaint brushes don't support custom blend modes, they always use what MyPaint calls "Normal and Erase". The code already made an attempt to disable the blend mode combo box to represent that, but switching tools caused it to re-enable itself, despite having no effect. This commit fixes that: the brush blend mode combo box gets disabled upon switching tools if a MyPaint brush preset is selected. It also adds a comment explaining the reason behind that rather non-obvious special case. (cherry picked from commit 1576bf60ae59947c2bb7131bd2e6c07be2427d56) M +8-1libs/ui/kis_paintop_box.cc https://invent.kde.org/graphics/krita/commit/896ddd0c0933bf3dc07b996962c61331220c7a01 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458756] Default brush outline shape produces artifacts on canvas when canvas is accelerated with OpenGL
https://bugs.kde.org/show_bug.cgi?id=458756 Dmitry Kazakov changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441935] When brush editor is moved to secondary monitor, closedm and opened again, it returns to default position.
https://bugs.kde.org/show_bug.cgi?id=441935 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/f9476b105 ||f37702b73e24ae7d2026b3c7ea8 ||b127 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #2 from Dmitry Kazakov --- Git commit f9476b105f37702b73e24ae7d2026b3c7ea8b127 by Dmitry Kazakov, on behalf of Alvin Wong. Committed on 05/09/2021 at 10:37. Pushed by dkazakov into branch 'master'. Use QScreen from QWindow to handle KisPopupButton positioning This fixes two issues: - Explicitly setting screen before showing to ensure the correct devicePixelRatio scaling. - For detached brush editor, use the screen it was previously moved to instead of forcing it to be shown on the same screen the main window is displayed. M +27 -4libs/widgetutils/KisPopupButton.cpp https://invent.kde.org/graphics/krita/commit/f9476b105f37702b73e24ae7d2026b3c7ea8b127 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441687] WinTab: Stylus input triggers single touch panning gesture
https://bugs.kde.org/show_bug.cgi?id=441687 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/99cb9adf7 ||857a0b1411b7f95309da7db92a2 ||0bec --- Comment #6 from Dmitry Kazakov --- Git commit 99cb9adf7857a0b1411b7f95309da7db92a20bec by Dmitry Kazakov, on behalf of Alvin Wong. Committed on 08/09/2021 at 12:43. Pushed by dkazakov into branch 'master'. Impl. touch blocking during tablet stroke 1. In WinTab mode some drivers still send Windows Ink events which Windows synthesizes into touch events and triggers the pan touch gesture. 2. In Windows Ink mode, even when the pen is being used, it is still possible to activate touch gestures with the touchscreen, which interrupts the current stroke. M +2-0libs/ui/input/kis_input_manager.cpp M +37 -0libs/ui/input/kis_input_manager_p.cpp M +8-0libs/ui/input/kis_input_manager_p.h https://invent.kde.org/graphics/krita/commit/99cb9adf7857a0b1411b7f95309da7db92a20bec -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 435056] Safe asserts both when undoing and redoing a selection mask after copying contents
https://bugs.kde.org/show_bug.cgi?id=435056 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #12 from Dmitry Kazakov --- The assert should have been fixed in a87dced5f88f26e282dfc86d18a3c32ecf68fa96 Though I cannot check if the patch is included into the reporter's version -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 425124] On the scratchpad, brush presets utilizing the speed sensor often aren't drawn accurately
https://bugs.kde.org/show_bug.cgi?id=425124 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/2a73cb69e ||7c87bed459cf0dac655e960a447 ||3a98 Status|CONFIRMED |RESOLVED --- Comment #3 from Dmitry Kazakov --- Git commit 2a73cb69e7c87bed459cf0dac655e960a4473a98 by Dmitry Kazakov. Committed on 08/09/2021 at 12:07. Pushed by dkazakov into branch 'master'. Fix scaling of the speed sensor in the scratch pad The speed sensor is calcualted in the "view" pixels, therefore KisPaintingInformationBuilder should know about that. M +22 -1libs/ui/widgets/kis_scratch_pad.cpp M +2-0libs/ui/widgets/kis_scratch_pad.h https://invent.kde.org/graphics/krita/commit/2a73cb69e7c87bed459cf0dac655e960a4473a98 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 425124] On the scratchpad, brush presets utilizing the speed sensor often aren't drawn accurately
https://bugs.kde.org/show_bug.cgi?id=425124 --- Comment #4 from Dmitry Kazakov --- Git commit ab86de9eae5605ae065c42cd250d480b03b40ec2 by Dmitry Kazakov. Committed on 08/09/2021 at 12:07. Pushed by dkazakov into branch 'master'. Fix artifacts in speed sensor in the Scratch Pad There is still some scaling issue, the values in the scratchpad are much higher than on the canvas. M +5-0libs/ui/tool/kis_painting_information_builder.cpp M +2-0libs/ui/tool/kis_painting_information_builder.h M +1-0libs/ui/tool/kis_tool_freehand_helper.cpp https://invent.kde.org/graphics/krita/commit/ab86de9eae5605ae065c42cd250d480b03b40ec2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 421098] Speed control of brush properties has an impractically large 'Fast' value.
https://bugs.kde.org/show_bug.cgi?id=421098 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED CC||dimul...@gmail.com Resolution|--- |FIXED --- Comment #3 from Dmitry Kazakov --- The aforementioned merge request has been merged! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 419277] krita-4.2.9: CMake Error at cmake/modules/FindOpenEXR.cmake:43, 49, 55: string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to command
https://bugs.kde.org/show_bug.cgi?id=419277 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/7699e8a1c ||b0d18751ad02fb786c0d15562a7 ||6e51 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #26 from Dmitry Kazakov --- Git commit 7699e8a1cb0d18751ad02fb786c0d15562a76e51 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 19/09/2021 at 10:49. Pushed by dkazakov into branch 'master'. OpenEXR: upgrade our Find module Currently, we use Pixar's find module to manage OpenEXR 2, which cannot find either v2.3 and lower or v3. The suggestion in the bug report was to use ECM, which in turn has the following issues: * It completely ignores the versioned suffix that OpenEXR applies to its libraries; this implies that it's relying on Linux's symlinks to point it to the correct library. This is a blocker for any level of support for Windows. * Secondly, but also less serious, it doesn't cover the IexMath and IlmImfUtil subcomponents. This commit replaces our Find module with ECM's, and makes the following modifications. 1. Find and use any CMake config module that OpenEXR provides. 2. Failing that, construct the library suffix, and manually look up each component. 3. Add IexMath and IlmImfUtil to the list of libraries. 4. Add support for OpenEXR v3 and its list of components. Additionally, I've cleaned up our find and linking logic. CCMAIL: kimages...@kde.org M +6-14 CMakeLists.txt M +358 -74 cmake/modules/FindOpenEXR.cmake M +0-3libs/pigment/CMakeLists.txt M +0-3plugins/color/lcms2engine/CMakeLists.txt M +0-4plugins/impex/exr/CMakeLists.txt M +0-3plugins/impex/raw/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/7699e8a1cb0d18751ad02fb786c0d15562a76e51 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441755] Smudge brushes have buggy interaction with Value option on 16-bit float and above color depths
https://bugs.kde.org/show_bug.cgi?id=441755 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 442796] Wraparound mode not updating other rows in real time
https://bugs.kde.org/show_bug.cgi?id=442796 --- Comment #1 from Dmitry Kazakov --- Git commit f5255d4e73d0a92e5e48f823a89e17436d286394 by Dmitry Kazakov. Committed on 22/09/2021 at 12:32. Pushed by dkazakov into branch 'master'. Fix artifacts on the canvas when the display scaling is set to 110% The problem is that we do "cropping" of the painted area twice during one frame. Firstly, we enable stencil test to avoid too much pixels to be rendered. And secondly, we limit the number of tiles that are rendered on screen. And these two limit must agree in how they do rounding. M +26 -6libs/ui/opengl/kis_opengl_canvas2.cpp M +3-2libs/ui/opengl/kis_opengl_canvas2.h https://invent.kde.org/graphics/krita/commit/f5255d4e73d0a92e5e48f823a89e17436d286394 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441649] random lines appear on canvas and scratchpad while moving the cursor
https://bugs.kde.org/show_bug.cgi?id=441649 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED CC||dimul...@gmail.com Status|CONFIRMED |RESOLVED --- Comment #10 from Dmitry Kazakov --- The bug should be fixed in this commit: https://invent.kde.org/graphics/krita/-/commit/f5255d4e73d0a92e5e48f823a89e17436d286394 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 441649] random lines appear on canvas and scratchpad while moving the cursor
https://bugs.kde.org/show_bug.cgi?id=441649 Dmitry Kazakov changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REPORTED Ever confirmed|1 |0 --- Comment #11 from Dmitry Kazakov --- Okay, QPainter canvas and Scratchpad are still affected -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 440938] Krita crashes after resizing brush in a specific way
https://bugs.kde.org/show_bug.cgi?id=440938 --- Comment #3 from Dmitry Kazakov --- Hi, Leonardo and Ahab! Could you please test this Linux package? https://disk.yandex.ru/d/VysHHg2fMedaKg It is built against this MR: https://invent.kde.org/graphics/krita/-/merge_requests/1069 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 440938] Krita crashes after resizing brush in a specific way
https://bugs.kde.org/show_bug.cgi?id=440938 --- Comment #5 from Dmitry Kazakov --- Hi, Ahab! Thanks a lot for testing! I'll merge the patch then! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 440938] Krita crashes after resizing brush in a specific way
https://bugs.kde.org/show_bug.cgi?id=440938 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Dmitry Kazakov --- The bug is closed by https://invent.kde.org/graphics/krita/-/merge_requests/1069 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 442796] Wraparound mode not updating other rows in real time
https://bugs.kde.org/show_bug.cgi?id=442796 --- Comment #2 from Dmitry Kazakov --- Git commit c2957b2d0822afeef27d165713757fdf8bced2c8 by Dmitry Kazakov. Committed on 28/09/2021 at 06:42. Pushed by dkazakov into branch 'krita/5.0'. Fix artifacts on the canvas when the display scaling is set to 110% The problem is that we do "cropping" of the painted area twice during one frame. Firstly, we enable stencil test to avoid too much pixels to be rendered. And secondly, we limit the number of tiles that are rendered on screen. And these two limit must agree in how they do rounding. M +26 -6libs/ui/opengl/kis_opengl_canvas2.cpp M +3-2libs/ui/opengl/kis_opengl_canvas2.h https://invent.kde.org/graphics/krita/commit/c2957b2d0822afeef27d165713757fdf8bced2c8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 --- Comment #5 from Dmitry Kazakov --- Git commit 016cca213259e0be610c3bed2b91337dd2697ab2 by Dmitry Kazakov. Committed on 28/09/2021 at 11:41. Pushed by dkazakov into branch 'master'. Fix too many copies of KisQImagePyramid on every start of the stroke We should generate the pyramid only once, before making clones. Otherwise, it can delay the stroke quite a bit on bigger brushes. M +4-0libs/brush/kis_auto_brush.cpp M +2-1libs/brush/kis_auto_brush.h M +7-0libs/brush/kis_brush.cpp M +8-0libs/brush/kis_brush.h M +6-0libs/brush/kis_brushes_pipe.h M +5-0libs/brush/kis_imagepipe_brush.cpp M +1-0libs/brush/kis_imagepipe_brush.h M +2-0plugins/paintops/defaultpaintops/brush/kis_brushop.cpp M +10 -3plugins/paintops/libpaintop/kis_brush_based_paintop.cpp https://invent.kde.org/graphics/krita/commit/016cca213259e0be610c3bed2b91337dd2697ab2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/e7d22031d ||abb8785f3dbeb37a8c3e14f551d ||b9dc --- Comment #6 from Dmitry Kazakov --- Git commit e7d22031dabb8785f3dbeb37a8c3e14f551db9dc by Dmitry Kazakov. Committed on 29/09/2021 at 10:56. Pushed by dkazakov into branch 'master'. Fix delays on the stroke start when the brush is too big This patch implements two things: 1) Makes sure that KisBrushBasedPaintOpSettings::m_savedBrush is actually passed by into the stroke (with cloning of course). Cloning of brushes is cheap due to lazy copying mechanism of QImage. 2) Implements a special manager class (KisPresetShadowUpdater) that regenerates brush'es heavy data structures (such as brush outline and image pyramid) in background (with a 1500 ms delay after the brush change). It means that the brush on the server will always store the correct data cached. When the user starts the stroke, this data is just cloned and passed to the stroke without extra recalculation (which may take up to 1000 ms for heavy brush tips). ** POSSIBLE REGRESSIONS ** 1) It may happen that the brush outline will be outdated after some of the brush settings are changed. 2) It may happen that the changes in the brush settings will not be visible in the actual stroke right aftert that. I haven't seen these regressions in real life, but, theoretically, they can happen. M +0-1libs/brush/CMakeLists.txt D +0-50 libs/brush/KisSharedQImagePyramid.cpp D +0-49 libs/brush/KisSharedQImagePyramid.h M +14 -3libs/brush/kis_auto_brush.cpp M +3-0libs/brush/kis_auto_brush.h M +53 -36 libs/brush/kis_brush.cpp M +8-5libs/brush/kis_brush.h M +1-1libs/brush/kis_gbr_brush.cpp M +29 -2libs/brush/kis_imagepipe_brush.cpp M +4-1libs/brush/kis_imagepipe_brush.h M +1-1libs/brush/kis_text_brush.cpp M +4-3libs/brush/tests/kis_gbr_brush_test.cpp M +1-1libs/brush/tests/kis_imagepipe_brush_test.cpp A +85 -0libs/global/KisLazySharedCacheStorage.h [License: GPL(v2.0+)] M +12 -1libs/image/brushengine/kis_paintop_preset.cpp M +17 -2libs/image/brushengine/kis_paintop_preset.h M +10 -0libs/image/brushengine/kis_paintop_settings.cpp M +5-0libs/image/brushengine/kis_paintop_settings.h M +1-0libs/ui/CMakeLists.txt A +121 -0libs/ui/KisPresetShadowUpdater.cpp [License: GPL(v2.0+)] A +32 -0libs/ui/KisPresetShadowUpdater.h [License: GPL(v2.0+)] M +6-1libs/ui/kis_canvas_resource_provider.cpp M +2-0libs/ui/kis_canvas_resource_provider.h M +22 -2plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp M +3-0plugins/paintops/libpaintop/kis_brush_based_paintop_settings.h https://invent.kde.org/graphics/krita/commit/e7d22031dabb8785f3dbeb37a8c3e14f551db9dc -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443111] Create from Clipboard not working as intended
https://bugs.kde.org/show_bug.cgi?id=443111 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 Dmitry Kazakov changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #7 from Dmitry Kazakov --- Okay, the brush is still valid when you create a masking brush with 3000px cache. This brush doesn't seem to be cached anywhere and constructing it in the beginnin g of the stroke is expensive :( -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/e7d22031d |hics/krita/commit/a094d19e7 |abb8785f3dbeb37a8c3e14f551d |147db6204ea54eef4467c1592c3 |b9dc|fb55 Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #8 from Dmitry Kazakov --- Git commit a094d19e7147db6204ea54eef4467c1592c3fb55 by Dmitry Kazakov. Committed on 30/09/2021 at 11:12. Pushed by dkazakov into branch 'master'. Implement a cache for masked brushes by KisPresetShadowUpdater Masked brushes are initialized in two steps: 1) KisPresetShadowUpdater calls KisPaintOpPreset::coldInitInForeground() to create the cache of the masking preset in the GUI thread (to be able to fetch resources needed by the masking preset) 2) KisPresetShadowUpdater calls KisPaintOpPreset::coldInitInBackground() to regenerate caches of the masking preset, like outline and pyramid. M +44 -7libs/image/brushengine/kis_paintop_preset.cpp M +6-0libs/image/brushengine/kis_paintop_preset.h M +12 -8libs/ui/KisPresetShadowUpdater.cpp https://invent.kde.org/graphics/krita/commit/a094d19e7147db6204ea54eef4467c1592c3fb55 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 437950] Huge pattern size slows down the whole brush editor
https://bugs.kde.org/show_bug.cgi?id=437950 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 437950] Huge pattern size slows down the whole brush editor
https://bugs.kde.org/show_bug.cgi?id=437950 --- Comment #4 from Dmitry Kazakov --- Hi, Tiar! Could you please test the bug in the today's master with my start-slowdown fixes? I cannot reproduce the bug here... https://invent.kde.org/graphics/krita/commit/cebb525047f5e51cb5ff6290e4ad0f81f3816c13 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 428090] Pattern feature produce lag in brush editor when parameters are adjusted
https://bugs.kde.org/show_bug.cgi?id=428090 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Resolution|--- |DUPLICATE Status|CONFIRMED |RESOLVED --- Comment #2 from Dmitry Kazakov --- *** This bug has been marked as a duplicate of bug 437950 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 437950] Huge pattern size slows down the whole brush editor
https://bugs.kde.org/show_bug.cgi?id=437950 Dmitry Kazakov changed: What|Removed |Added CC||mirandagrap...@gmail.com --- Comment #5 from Dmitry Kazakov --- *** Bug 428090 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443161] Canvas doesn't refresh and clear vector after deletion objects if the layer is moved with a move tool
https://bugs.kde.org/show_bug.cgi?id=443161 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 --- Comment #9 from Dmitry Kazakov --- Git commit 6839165795970fa27afa77001b015cdd3fd4a43a by Dmitry Kazakov. Committed on 30/09/2021 at 12:17. Pushed by dkazakov into branch 'krita/5.0'. Fix too many copies of KisQImagePyramid on every start of the stroke We should generate the pyramid only once, before making clones. Otherwise, it can delay the stroke quite a bit on bigger brushes. M +4-0libs/brush/kis_auto_brush.cpp M +2-1libs/brush/kis_auto_brush.h M +7-0libs/brush/kis_brush.cpp M +8-0libs/brush/kis_brush.h M +6-0libs/brush/kis_brushes_pipe.h M +5-0libs/brush/kis_imagepipe_brush.cpp M +1-0libs/brush/kis_imagepipe_brush.h M +2-0plugins/paintops/defaultpaintops/brush/kis_brushop.cpp M +10 -3plugins/paintops/libpaintop/kis_brush_based_paintop.cpp https://invent.kde.org/graphics/krita/commit/6839165795970fa27afa77001b015cdd3fd4a43a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/a094d19e7 |hics/krita/commit/ab3365ff7 |147db6204ea54eef4467c1592c3 |6bdd5dfbc9e83e22b108531ae00 |fb55|41c2 --- Comment #10 from Dmitry Kazakov --- Git commit ab3365ff76bdd5dfbc9e83e22b108531ae0041c2 by Dmitry Kazakov. Committed on 30/09/2021 at 12:17. Pushed by dkazakov into branch 'krita/5.0'. Fix delays on the stroke start when the brush is too big This patch implements two things: 1) Makes sure that KisBrushBasedPaintOpSettings::m_savedBrush is actually passed by into the stroke (with cloning of course). Cloning of brushes is cheap due to lazy copying mechanism of QImage. 2) Implements a special manager class (KisPresetShadowUpdater) that regenerates brush'es heavy data structures (such as brush outline and image pyramid) in background (with a 1500 ms delay after the brush change). It means that the brush on the server will always store the correct data cached. When the user starts the stroke, this data is just cloned and passed to the stroke without extra recalculation (which may take up to 1000 ms for heavy brush tips). ** POSSIBLE REGRESSIONS ** 1) It may happen that the brush outline will be outdated after some of the brush settings are changed. 2) It may happen that the changes in the brush settings will not be visible in the actual stroke right aftert that. I haven't seen these regressions in real life, but, theoretically, they can happen. M +0-1libs/brush/CMakeLists.txt D +0-50 libs/brush/KisSharedQImagePyramid.cpp D +0-49 libs/brush/KisSharedQImagePyramid.h M +14 -3libs/brush/kis_auto_brush.cpp M +3-0libs/brush/kis_auto_brush.h M +53 -36 libs/brush/kis_brush.cpp M +8-5libs/brush/kis_brush.h M +1-1libs/brush/kis_gbr_brush.cpp M +29 -2libs/brush/kis_imagepipe_brush.cpp M +4-1libs/brush/kis_imagepipe_brush.h M +1-1libs/brush/kis_text_brush.cpp M +4-3libs/brush/tests/kis_gbr_brush_test.cpp M +1-1libs/brush/tests/kis_imagepipe_brush_test.cpp A +85 -0libs/global/KisLazySharedCacheStorage.h [License: GPL(v2.0+)] M +12 -1libs/image/brushengine/kis_paintop_preset.cpp M +17 -2libs/image/brushengine/kis_paintop_preset.h M +10 -0libs/image/brushengine/kis_paintop_settings.cpp M +5-0libs/image/brushengine/kis_paintop_settings.h M +1-0libs/ui/CMakeLists.txt A +121 -0libs/ui/KisPresetShadowUpdater.cpp [License: GPL(v2.0+)] A +32 -0libs/ui/KisPresetShadowUpdater.h [License: GPL(v2.0+)] M +6-1libs/ui/kis_canvas_resource_provider.cpp M +2-0libs/ui/kis_canvas_resource_provider.h M +22 -2plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp M +3-0plugins/paintops/libpaintop/kis_brush_based_paintop_settings.h https://invent.kde.org/graphics/krita/commit/ab3365ff76bdd5dfbc9e83e22b108531ae0041c2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436731] Huge brush tip images unnecessarily slow down Krita on every start of the stroke
https://bugs.kde.org/show_bug.cgi?id=436731 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/ab3365ff7 |hics/krita/commit/323805d23 |6bdd5dfbc9e83e22b108531ae00 |cb950d5f7d6bb67fadf6c4b8e21 |41c2|94b4 --- Comment #11 from Dmitry Kazakov --- Git commit 323805d23cb950d5f7d6bb67fadf6c4b8e2194b4 by Dmitry Kazakov. Committed on 30/09/2021 at 12:17. Pushed by dkazakov into branch 'krita/5.0'. Implement a cache for masked brushes by KisPresetShadowUpdater Masked brushes are initialized in two steps: 1) KisPresetShadowUpdater calls KisPaintOpPreset::coldInitInForeground() to create the cache of the masking preset in the GUI thread (to be able to fetch resources needed by the masking preset) 2) KisPresetShadowUpdater calls KisPaintOpPreset::coldInitInBackground() to regenerate caches of the masking preset, like outline and pyramid. M +44 -7libs/image/brushengine/kis_paintop_preset.cpp M +6-0libs/image/brushengine/kis_paintop_preset.h M +12 -8libs/ui/KisPresetShadowUpdater.cpp https://invent.kde.org/graphics/krita/commit/323805d23cb950d5f7d6bb67fadf6c4b8e2194b4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443161] Canvas doesn't refresh and clear vector after deletion objects if the layer is moved with a move tool
https://bugs.kde.org/show_bug.cgi?id=443161 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/cd07452f8 ||e6f4fa4f2ec4a84062318cc6e33 ||1240 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #1 from Dmitry Kazakov --- Git commit cd07452f8e6f4fa4f2ec4a84062318cc6e331240 by Dmitry Kazakov. Committed on 30/09/2021 at 13:06. Pushed by dkazakov into branch 'master'. Fix updates of shapes belonging to a transformed group shapeInterface()->removeShape(this) must be called before we reset the parent of the shape, because it calls shapeToBeRemovedFromHierarchy() which issues updates for the shape removal. The latter call should have access to the absolute transformation for these updates. M +4-5libs/flake/KoShape.cpp https://invent.kde.org/graphics/krita/commit/cd07452f8e6f4fa4f2ec4a84062318cc6e331240 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443161] Canvas doesn't refresh and clear vector after deletion objects if the layer is moved with a move tool
https://bugs.kde.org/show_bug.cgi?id=443161 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/cd07452f8 |hics/krita/commit/25f710916 |e6f4fa4f2ec4a84062318cc6e33 |1af140057b0699eda35077b0613 |1240|2879 --- Comment #2 from Dmitry Kazakov --- Git commit 25f7109161af140057b0699eda35077b06132879 by Dmitry Kazakov. Committed on 30/09/2021 at 15:50. Pushed by dkazakov into branch 'krita/5.0'. Fix updates of shapes belonging to a transformed group shapeInterface()->removeShape(this) must be called before we reset the parent of the shape, because it calls shapeToBeRemovedFromHierarchy() which issues updates for the shape removal. The latter call should have access to the absolute transformation for these updates. M +4-5libs/flake/KoShape.cpp https://invent.kde.org/graphics/krita/commit/25f7109161af140057b0699eda35077b06132879 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447985] Rare crash when painting during extended sessions
https://bugs.kde.org/show_bug.cgi?id=447985 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #5 from Dmitry Kazakov --- Hi, Dmitrii and Tomtomtom! Could you tell if you did anything of the following prior to the crash? 1) Closed the image? 2) Closed an additional view of the image? >From the backtrace by Dmitrii it looks as if Krita tries to deliver an event to an object that has just been deleted. I don't know how it could happen yet. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 449226] Krita crashes when trying to create an Animated Brush
https://bugs.kde.org/show_bug.cgi?id=449226 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/606c57747 ||95cdb32c50d08086a52f6a743ee ||1dd9 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Dmitry Kazakov --- Git commit 606c5774795cdb32c50d08086a52f6a743ee1dd9 by Dmitry Kazakov. Committed on 28/02/2022 at 13:13. Pushed by dkazakov into branch 'master'. Fix custom brush widget to not activate null brush resource when overriding Related: bug 450121 M +3-3plugins/paintops/libpaintop/kis_clipboard_brush_widget.cpp M +6-4plugins/paintops/libpaintop/kis_custom_brush_widget.cpp https://invent.kde.org/graphics/krita/commit/606c5774795cdb32c50d08086a52f6a743ee1dd9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 449226] Krita crashes when trying to create an Animated Brush
https://bugs.kde.org/show_bug.cgi?id=449226 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/606c57747 |hics/krita/commit/594db4dfc |95cdb32c50d08086a52f6a743ee |6cdf453f17d0f4f2b5cbf30e90e |1dd9|8515 --- Comment #5 from Dmitry Kazakov --- Git commit 594db4dfc6cdf453f17d0f4f2b5cbf30e90e8515 by Dmitry Kazakov. Committed on 28/02/2022 at 13:13. Pushed by dkazakov into branch 'master'. Fix predefined brush widget doesn't crash when no brush is selected To trigger the crash you need to create the brush with the same name twice. M +1-1plugins/paintops/libpaintop/kis_predefined_brush_chooser.cpp https://invent.kde.org/graphics/krita/commit/594db4dfc6cdf453f17d0f4f2b5cbf30e90e8515 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450121] Krita crashes when trying to create a brush tip with the same name as an already deleted brush tip.
https://bugs.kde.org/show_bug.cgi?id=450121 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/606c57747 ||95cdb32c50d08086a52f6a743ee ||1dd9 --- Comment #3 from Dmitry Kazakov --- Git commit 606c5774795cdb32c50d08086a52f6a743ee1dd9 by Dmitry Kazakov. Committed on 28/02/2022 at 13:13. Pushed by dkazakov into branch 'master'. Fix custom brush widget to not activate null brush resource when overriding Related: bug 449226 M +3-3plugins/paintops/libpaintop/kis_clipboard_brush_widget.cpp M +6-4plugins/paintops/libpaintop/kis_custom_brush_widget.cpp https://invent.kde.org/graphics/krita/commit/606c5774795cdb32c50d08086a52f6a743ee1dd9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450121] Krita crashes when trying to create a brush tip with the same name as an already deleted brush tip.
https://bugs.kde.org/show_bug.cgi?id=450121 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/606c57747 |hics/krita/commit/000f36f9a |95cdb32c50d08086a52f6a743ee |1dd2f512337cbfa294414cd6c6c |1dd9|c0d3 --- Comment #4 from Dmitry Kazakov --- Git commit 000f36f9a1dd2f512337cbfa294414cd6c6cc0d3 by Dmitry Kazakov. Committed on 28/02/2022 at 13:48. Pushed by dkazakov into branch 'krita/5.0'. Fix custom brush widget to not activate null brush resource when overriding Related: bug 449226 M +3-3plugins/paintops/libpaintop/kis_clipboard_brush_widget.cpp M +6-4plugins/paintops/libpaintop/kis_custom_brush_widget.cpp https://invent.kde.org/graphics/krita/commit/000f36f9a1dd2f512337cbfa294414cd6c6cc0d3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 449226] Krita crashes when trying to create an Animated Brush
https://bugs.kde.org/show_bug.cgi?id=449226 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/594db4dfc |hics/krita/commit/000f36f9a |6cdf453f17d0f4f2b5cbf30e90e |1dd2f512337cbfa294414cd6c6c |8515|c0d3 --- Comment #6 from Dmitry Kazakov --- Git commit 000f36f9a1dd2f512337cbfa294414cd6c6cc0d3 by Dmitry Kazakov. Committed on 28/02/2022 at 13:48. Pushed by dkazakov into branch 'krita/5.0'. Fix custom brush widget to not activate null brush resource when overriding Related: bug 450121 M +3-3plugins/paintops/libpaintop/kis_clipboard_brush_widget.cpp M +6-4plugins/paintops/libpaintop/kis_custom_brush_widget.cpp https://invent.kde.org/graphics/krita/commit/000f36f9a1dd2f512337cbfa294414cd6c6cc0d3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 449226] Krita crashes when trying to create an Animated Brush
https://bugs.kde.org/show_bug.cgi?id=449226 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/000f36f9a |hics/krita/commit/69dcc22d0 |1dd2f512337cbfa294414cd6c6c |d203c632b05d46c9d1ec7b4ef15 |c0d3|3a26 --- Comment #7 from Dmitry Kazakov --- Git commit 69dcc22d0d203c632b05d46c9d1ec7b4ef153a26 by Dmitry Kazakov. Committed on 28/02/2022 at 13:16. Pushed by dkazakov into branch 'krita/5.0'. Fix predefined brush widget doesn't crash when no brush is selected To trigger the crash you need to create the brush with the same name twice. M +1-1plugins/paintops/libpaintop/kis_predefined_brush_chooser.cpp https://invent.kde.org/graphics/krita/commit/69dcc22d0d203c632b05d46c9d1ec7b4ef153a26 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445922] when I try to use layers styles, espetialy the one that give a shadow ( called ''ombre porté'' in french), krita crash. I tried it on nightly and beta builds using all the most re
https://bugs.kde.org/show_bug.cgi?id=445922 Dmitry Kazakov changed: What|Removed |Added CC||oktop...@gmail.com --- Comment #24 from Dmitry Kazakov --- *** Bug 448296 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448296] Krita crashes when opening "Layer Style..."
https://bugs.kde.org/show_bug.cgi?id=448296 Dmitry Kazakov changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Dmitry Kazakov --- This bug will be fixed in 5.0.3 release :) *** This bug has been marked as a duplicate of bug 445922 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448296] Krita crashes when opening "Layer Style..."
https://bugs.kde.org/show_bug.cgi?id=448296 Dmitry Kazakov changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #7 from Dmitry Kazakov --- Damn... I think I have closed the bug prematurely :( -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448296] Krita crashes when opening "Layer Style..."
https://bugs.kde.org/show_bug.cgi?id=448296 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/b0dc7adc0 ||789afe951b4f62d9fab4db7d6e1 ||7135 Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #8 from Dmitry Kazakov --- Git commit b0dc7adc0789afe951b4f62d9fab4db7d6e17135 by Dmitry Kazakov. Committed on 28/02/2022 at 14:11. Pushed by dkazakov into branch 'krita/5.0'. Fix a crash when the selected gradient is filtered in LS dialog M +12 -4libs/ui/dialogs/kis_dlg_layer_style.cpp M +2-2libs/ui/widgets/gradient/KisGradientChooser.cpp M +1-1libs/ui/widgets/gradient/KisGradientChooser.h M +2-2libs/ui/widgets/kis_cmb_gradient.cpp M +1-1libs/ui/widgets/kis_cmb_gradient.h https://invent.kde.org/graphics/krita/commit/b0dc7adc0789afe951b4f62d9fab4db7d6e17135 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448296] Krita crashes when opening "Layer Style..."
https://bugs.kde.org/show_bug.cgi?id=448296 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/b0dc7adc0 |hics/krita/commit/9ec4d99db |789afe951b4f62d9fab4db7d6e1 |0c6cf26c90ca9358c6b5e02bbd6 |7135|c23b --- Comment #9 from Dmitry Kazakov --- Git commit 9ec4d99db0c6cf26c90ca9358c6b5e02bbd6c23b by Dmitry Kazakov. Committed on 28/02/2022 at 14:11. Pushed by dkazakov into branch 'master'. Fix a crash when the selected gradient is filtered in LS dialog M +12 -4libs/ui/dialogs/kis_dlg_layer_style.cpp M +2-2libs/ui/widgets/gradient/KisGradientChooser.cpp M +1-1libs/ui/widgets/gradient/KisGradientChooser.h M +2-2libs/ui/widgets/kis_cmb_gradient.cpp M +1-1libs/ui/widgets/kis_cmb_gradient.h https://invent.kde.org/graphics/krita/commit/9ec4d99db0c6cf26c90ca9358c6b5e02bbd6c23b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450957] krita crashes when switching the order of layers
https://bugs.kde.org/show_bug.cgi?id=450957 Dmitry Kazakov changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||dimul...@gmail.com --- Comment #5 from Dmitry Kazakov --- I can reproduce a crash when moving a layer with a transform mask attached using Ctrl+PgUp/PgDown shortcuts. It doesn't assert here, just crashed. But that is kind of expected. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450957] krita crashes when switching the order of layers
https://bugs.kde.org/show_bug.cgi?id=450957 --- Comment #7 from Dmitry Kazakov --- Hi, wickedmic! Thank you for the test file! It makes it really easy to reproduce the bug here! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450957] krita crashes when switching the order of layers
https://bugs.kde.org/show_bug.cgi?id=450957 --- Comment #9 from Dmitry Kazakov --- Git commit 827c03d5ddd74a4f18f55ed892f49e391ec2ecc1 by Dmitry Kazakov. Committed on 10/03/2022 at 16:09. Pushed by dkazakov into branch 'master'. Make sure that actions that modify layers stack are exclusive If a layer gets removed while an update is running, the update may assert in some cases. M +16 -8libs/ui/kis_node_juggler_compressed.cpp https://invent.kde.org/graphics/krita/commit/827c03d5ddd74a4f18f55ed892f49e391ec2ecc1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450957] krita crashes when switching the order of layers
https://bugs.kde.org/show_bug.cgi?id=450957 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/2e9c60d35 ||aa02e0e4d5881ddbd6b64c94d76 ||2a35 Resolution|--- |FIXED --- Comment #8 from Dmitry Kazakov --- Git commit 2e9c60d35aa02e0e4d5881ddbd6b64c94d762a35 by Dmitry Kazakov. Committed on 10/03/2022 at 16:09. Pushed by dkazakov into branch 'master'. Fix threading issues in the scheduler when manipulating layers After several iterations of changes to KisNode::changeRect() definition, KisBaseRectsWalker::changeRect() now means **not** the rect of the canvas that is changed by the walker on any layer, but only a rect that will be changed in the end of the merge operation. It means that two merge operations may still overlap on the intermediate layers if the layer stack has nodes with weird change/needRect(). And that can cause breakage of the tile manager's invariants, because two threads would write into overlapping areas. This patch fixes it in a suboptimal approach. Now the scheduler just checks if accessRect of the walkers intersect. That means that the scheduler now also blocks walkers with overlapping **read** rects, which are totally legal. M +7-2libs/image/kis_updater_context.cpp https://invent.kde.org/graphics/krita/commit/2e9c60d35aa02e0e4d5881ddbd6b64c94d762a35 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451175] Krita deadlocks on cancelling an export or save with a configuration dialog
https://bugs.kde.org/show_bug.cgi?id=451175 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/8f335dfa4 ||61857bf32a3aebdcf65d4a6a3c1 ||03d6 --- Comment #1 from Dmitry Kazakov --- Git commit 8f335dfa461857bf32a3aebdcf65d4a6a3c103d6 by Dmitry Kazakov. Committed on 14/03/2022 at 11:55. Pushed by dkazakov into branch 'master'. Fix a deadlock when cancelling save dialog for a PSD file M +10 -5libs/widgetutils/KoProgressUpdater.cpp https://invent.kde.org/graphics/krita/commit/8f335dfa461857bf32a3aebdcf65d4a6a3c103d6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451063] Projection is (often) not updated after pasting raster data
https://bugs.kde.org/show_bug.cgi?id=451063 --- Comment #5 from Dmitry Kazakov --- I cannot reproduce the problem here locally. Perhaps it got fixes by my recent commit 827c03d5ddd74a4f18f55ed892f49e391ec2ecc1 ? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447466] pixel art brush outline showing as a regular circle instead of pixelated circle but "outline shape" setting is set to "preview outline" not "circle"
https://bugs.kde.org/show_bug.cgi?id=447466 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/467982f53 ||663227c64c305532025ee7cb1cf ||2f9a Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #1 from Dmitry Kazakov --- Git commit 467982f53663227c64c305532025ee7cb1cf2f9a by Dmitry Kazakov. Committed on 16/03/2022 at 09:00. Pushed by dkazakov into branch 'master'. Fix brush outline precision for pixel-art Our auto-brushes use simplified version of the outline for the performance reasons. That can interfere with the pipeline of pixel-art artists. This patch switches the the outline into the precise mode when the physical zoom of the image is greater than 200%. The patch also fixes a few issues with hidpi mode: the outline flickering prevention and pixel grid activatation algorithms used "virtual" zoom instead of "physical" zoom, which was not too obvious. M +2-2libs/brush/kis_auto_brush.cpp M +1-1libs/brush/kis_auto_brush.h M +3-1libs/brush/kis_brush.cpp M +1-1libs/brush/kis_brush.h M +3-1libs/brush/kis_imagepipe_brush.cpp M +1-1libs/brush/kis_imagepipe_brush.h M +2-1libs/resources/KoCanvasResourcesIds.h M +13 -0libs/ui/canvas/kis_coordinates_converter.cpp M +1-0libs/ui/canvas/kis_coordinates_converter.h M +1-0libs/ui/kis_canvas_resource_provider.cpp M +3-0libs/ui/kis_zoom_manager.cc M +1-1libs/ui/opengl/KisOpenGLCanvasRenderer.cpp M +6-1libs/ui/tool/kis_tool_freehand_helper.cpp M +1-0libs/ui/tool/kis_tool_freehand_helper.h M +1-1libs/ui/tool/kis_tool_paint.cc M +1-1plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp M +2-2plugins/tools/tool_smart_patch/kis_tool_smart_patch.cpp https://invent.kde.org/graphics/krita/commit/467982f53663227c64c305532025ee7cb1cf2f9a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447045] Brushes with kind of low Density has bad visibility on canvas
https://bugs.kde.org/show_bug.cgi?id=447045 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/ed61d9164 ||1e08bb211300f9648eb22a996b9 ||1355 Status|ASSIGNED|RESOLVED --- Comment #2 from Dmitry Kazakov --- Git commit ed61d91641e08bb211300f9648eb22a996b91355 by Dmitry Kazakov. Committed on 16/03/2022 at 09:00. Pushed by dkazakov into branch 'master'. Don't try to generate a precise brush outline for low-density brushes It generates messy outline, paiters don't like them. Though outlines will still be messy if the user sets "spikes" value higher than 2 and activates low density. M +2-2libs/brush/kis_auto_brush.cpp https://invent.kde.org/graphics/krita/commit/ed61d91641e08bb211300f9648eb22a996b91355 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450957] krita crashes when switching the order of layers
https://bugs.kde.org/show_bug.cgi?id=450957 --- Comment #10 from Dmitry Kazakov --- Git commit e465267b6b29d7ff53f1ee73b90d7b64858134f6 by Dmitry Kazakov. Committed on 16/03/2022 at 13:46. Pushed by dkazakov into branch 'master'. Fix KisRefreshSubtreeWalker to skip hidden layers when merging The test file in the referenced bug showed really slow updates because KisRefreshSubtreeWalker took the hidden transform masks into account when calculating update rect. M +1-1libs/image/kis_async_merger.cpp M +1-1libs/image/kis_refresh_subtree_walker.h https://invent.kde.org/graphics/krita/commit/e465267b6b29d7ff53f1ee73b90d7b64858134f6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450957] krita crashes when switching the order of layers
https://bugs.kde.org/show_bug.cgi?id=450957 --- Comment #11 from Dmitry Kazakov --- Git commit d39f8a675b5fe6604dd4e9d64c7c0f76d4f68724 by Dmitry Kazakov. Committed on 16/03/2022 at 13:46. Pushed by dkazakov into branch 'master'. Do not recalculate entire group when a layer is moved When we move a layer inside a group, we need to only recompose the pregenerated layers. We don't need to regenerate all the projections of all the layers inside. The other layers may have complex masks, e.g. transformation masks. M +2-2libs/image/commands/kis_image_layer_move_command.cpp M +1-0libs/image/kis_base_rects_walker.h M +8-3libs/image/kis_full_refresh_walker.h M +14 -10 libs/image/kis_image.cc M +4-4libs/image/kis_image.h M +12 -4libs/image/kis_image_interfaces.h M +2-1libs/image/kis_projection_updates_filter.cpp M +3-2libs/image/kis_projection_updates_filter.h M +25 -5libs/image/kis_refresh_subtree_walker.h M +2-1libs/image/kis_regenerate_frame_stroke_strategy.cpp M +8-0libs/image/kis_simple_update_queue.cpp M +1-0libs/image/kis_simple_update_queue.h M +36 -6libs/image/kis_suspend_projection_updates_stroke_strategy.cpp M +6-0libs/image/kis_update_scheduler.cpp M +1-0libs/image/kis_update_scheduler.h M +4-1libs/image/tests/kis_simple_update_queue_test.cpp M +2-2libs/ui/kis_node_juggler_compressed.cpp https://invent.kde.org/graphics/krita/commit/d39f8a675b5fe6604dd4e9d64c7c0f76d4f68724 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447484] Smudge engine does not work with grayscale images
https://bugs.kde.org/show_bug.cgi?id=447484 --- Comment #2 from Dmitry Kazakov --- The bug is somehow related to the conversion algorithm graya8 -> graya16. For some reason, the alpha is set to 100% during this conversion. It might be that the conversion takes the path via alpha color space :( -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446663] Brush stutters at the start of the stroke
https://bugs.kde.org/show_bug.cgi?id=446663 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/d47a33aa9 ||c7d1ba54cbe30f2d04263ca4aff ||7a92 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #7 from Dmitry Kazakov --- Git commit d47a33aa9c7d1ba54cbe30f2d04263ca4aff7a92 by Dmitry Kazakov. Committed on 23/03/2022 at 12:29. Pushed by dkazakov into branch 'master'. Fix delay on auto-brush stroke with randomness KisAutoBrush used to initialize brushTipImage() and image() with a full-size preview image, which could cause huge delay for big brushes with randomness enabled. This patch disables initialization of brushTipImage() for auto-brushes (it is not used for them anyway). M +46 -11 libs/brush/kis_auto_brush.cpp M +1-1libs/brush/kis_auto_brush.h https://invent.kde.org/graphics/krita/commit/d47a33aa9c7d1ba54cbe30f2d04263ca4aff7a92 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 431623] Change the "Use same aspect as pixels" button to make it less confusing
https://bugs.kde.org/show_bug.cgi?id=431623 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/c4dcbf904 ||7febc10e73896584998089616e9 ||43c0 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Dmitry Kazakov --- Git commit c4dcbf9047febc10e73896584998089616e943c0 by Dmitry Kazakov, on behalf of Tom Tom Tom. Committed on 23/03/2022 at 12:35. Pushed by dkazakov into branch 'master'. Reverse functionality of aspectButton M +2-1libs/ui/KisView.cpp M +2-2libs/ui/kis_zoom_manager.cc M +1-1libs/ui/tests/kis_prescaled_projection_test.cpp M +1-1libs/widgets/KoZoomAction.h M +2-2libs/widgets/KoZoomWidget.cpp M +1-1libs/widgets/KoZoomWidget.h https://invent.kde.org/graphics/krita/commit/c4dcbf9047febc10e73896584998089616e943c0 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 433285] Certain inputs while holding mirror tool dividers locks the cursor icon to a hand icon until Krita is restarted
https://bugs.kde.org/show_bug.cgi?id=433285 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/0b24bfa0a ||7c77019dfadd9e76ecbcca0f1cc ||bc14 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #4 from Dmitry Kazakov --- Git commit 0b24bfa0a7c77019dfadd9e76ecbcca0f1ccbc14 by Dmitry Kazakov, on behalf of Tom Tom Tom. Committed on 23/03/2022 at 14:12. Pushed by dkazakov into branch 'master'. Ensure original cursor is restored after using mirror tools M +6-2libs/ui/canvas/kis_mirror_axis.cpp https://invent.kde.org/graphics/krita/commit/0b24bfa0a7c77019dfadd9e76ecbcca0f1ccbc14 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 442191] Transform tool produces white artifacts around the edge of transformed result
https://bugs.kde.org/show_bug.cgi?id=442191 --- Comment #4 from Dmitry Kazakov --- I guess the bug has too independent parts: the problem in Free Transform mode and the problem in Liquify mode. The problem in Free Transform mode is, most probbably, related to some bug in KisFilterWeightsApplicator. Most probably, it does alpha channel premultiplication somehow wrongly... Or, perhaps there is some precision issue. The proof is that four-point perspective transform doesn't have this issue. Four-point transform uses mix-op directly, so it does premultiplication correctly. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 442191] Transform tool produces white artifacts around the edge of transformed result
https://bugs.kde.org/show_bug.cgi?id=442191 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/4d849b266 ||ab32593b25ad1a43d32b2b13236 ||1dae Status|CONFIRMED |RESOLVED --- Comment #5 from Dmitry Kazakov --- Git commit 4d849b266ab32593b25ad1a43d32b2b132361dae by Dmitry Kazakov. Committed on 24/03/2022 at 13:56. Pushed by dkazakov into branch 'master'. Fix bright halos in the transform tool around semi-transparent objects We had a weird and very old (from 2008) non-linearity in KoMixColorsOp, which clamped the totalAlpha channel in case it is "not sane". I have a feeling that this construct was used to just make clamp the alpha channel value into the destination color space bit depth. Though it didn't take into accound that with some filters (bicubic, lanczos) the weight may be negative, basically making this check invalid. The patch simply removes this change and clamps the alpha channel separately (since we do already have the same clamping for other channels). WARNING: think twice before porting that into 5.0 branch! The patch changes how KoMixColorsOp works, so it might lead to unexpected consequences. M +60 -0libs/image/tests/kis_filter_weights_applicator_test.cpp M +2-0libs/image/tests/kis_filter_weights_applicator_test.h M +9-8libs/pigment/KoMixColorsOpImpl.h https://invent.kde.org/graphics/krita/commit/4d849b266ab32593b25ad1a43d32b2b132361dae -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447484] Smudge engine does not work with grayscale images
https://bugs.kde.org/show_bug.cgi?id=447484 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/5b3b1de7f ||cbc033b1bf9dfbcd20a0dd53a5a ||98a3 Status|ASSIGNED|RESOLVED --- Comment #4 from Dmitry Kazakov --- Git commit 5b3b1de7fcbc033b1bf9dfbcd20a0dd53a5a98a3 by Dmitry Kazakov. Committed on 28/03/2022 at 06:19. Pushed by dkazakov into branch 'master'. Fix conversions between GRAYA8<->GRAYA16 The color conversion system had a bug, which caused the conversion to happen via ALPHA8 color space (GRAYA8<->ALPHA16<->GRAYA16). That basically dropped the alpha channel of the GRAYA color space. It was caused by the presence of custom connections in the alpha color space. The patch changes the way how connection path is searched. It implements NodeCapabilities structure, which tracks capabilities of the nodes used in the connection path. M +0-32 libs/pigment/KoColorConversionAlphaTransformation.cpp M +0-4libs/pigment/KoColorConversionAlphaTransformation.h M +13 -27 libs/pigment/KoColorConversionSystem.cpp M +0-10 libs/pigment/KoColorConversionSystem.h M +73 -50 libs/pigment/KoColorConversionSystem_p.h M +1-11 libs/pigment/KoColorConversionTransformationFactory.h M +0-8libs/pigment/KoCopyColorConversionTransformation.cpp M +0-2libs/pigment/KoCopyColorConversionTransformation.h M +103 -20 libs/pigment/tests/TestColorConversionSystem.cpp M +8-0libs/pigment/tests/TestColorConversionSystem.h M +4-0plugins/color/lcms2engine/LcmsRGBP2020PQColorSpace.h M +0-30 plugins/color/lcms2engine/LcmsRGBP2020PQColorSpaceTransformation.h https://invent.kde.org/graphics/krita/commit/5b3b1de7fcbc033b1bf9dfbcd20a0dd53a5a98a3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 442191] Transform tool produces white artifacts around the edge of transformed result
https://bugs.kde.org/show_bug.cgi?id=442191 --- Comment #9 from Dmitry Kazakov --- Ah, liquify! Yes, I've completely forgot about that, thanks! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451903] UBSan hits on a signed integer left-shift in KisFixedPoint
https://bugs.kde.org/show_bug.cgi?id=451903
Dmitry Kazakov changed:
What|Removed |Added
CC||dimul...@gmail.com
--- Comment #1 from Dmitry Kazakov ---
Hi, amyspark!
There is a comment about that in KisFixedPoint telling exctly about that:
KisFixedPoint& operator*=(const KisFixedPoint& x) {
/**
* Until C++20 `d >>= 8` is "implementation defined" for negative `d`.
* But we have a unittest that confirms that the our compiler handles
* that in an expected way
*/
d *= x.d;
d >>= 8;
return *this;
}
Since C++20 this code will become valid as it is, and it seems to be valid at
least on AMD64 in the compilers we use. Do you have an idea if we can rewrite
that in C++14 or C++17 without sacrificing performance? This code is used in
the hottest path in the transform tool, so doing extra work is not desirable.
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 451980] Brush option Fade cannot be configured by dragging the slider (instead of clicking)
https://bugs.kde.org/show_bug.cgi?id=451980 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Ever confirmed|0 |1 Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com Status|REPORTED|ASSIGNED --- Comment #1 from Dmitry Kazakov --- I think I have seen this bug recently. I will check this bug :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451874] If Weighted/Stabilizer's Distance/Sample Count are set higher than 100, they will not be remembered and will be reset to 100
https://bugs.kde.org/show_bug.cgi?id=451874 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com Status|CONFIRMED |ASSIGNED Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451875] Brush smoothing type isn't remembered, always defaults to None
https://bugs.kde.org/show_bug.cgi?id=451875 Dmitry Kazakov changed: What|Removed |Added Ever confirmed|0 |1 Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com Status|REPORTED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 442191] Transform tool produces white artifacts around the edge of transformed result
https://bugs.kde.org/show_bug.cgi?id=442191 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REOPENED|NEEDSINFO --- Comment #10 from Dmitry Kazakov --- Hi, acc4commissions and tomtomtom! I have a feeling that the liquify issue is not-a-bug. The problem happpens because, when you start a transformation, the transform tool makes a normal "Cut" operation (the same as when you do Cut/Paste). This operation cannot add-up to a solid color. To workaround the issue one needs to use "Cut (sharp)" + "Paste" and then transform. Could you tell if this approach would solve your issue? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451875] Brush smoothing type isn't remembered, always defaults to None
https://bugs.kde.org/show_bug.cgi?id=451875 --- Comment #1 from Dmitry Kazakov --- This bug is a regression from aa4212b403 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451875] Brush smoothing type isn't remembered, always defaults to None
https://bugs.kde.org/show_bug.cgi?id=451875 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/09d669373 ||2e721f7b1f3c4c03da39ab7800b ||0dc1 Status|ASSIGNED|RESOLVED --- Comment #2 from Dmitry Kazakov --- Git commit 09d6693732e721f7b1f3c4c03da39ab7800b0dc1 by Dmitry Kazakov. Committed on 29/03/2022 at 04:36. Pushed by dkazakov into branch 'master'. Revert "Add option to have separate smoothing options for the brush eraser" This reverts commit aa4212b4030d092ac6a948b3ba6e2f98a8ee63f4. # Conflicts: # libs/ui/tool/kis_tool_freehand.h # libs/ui/tool/kis_tool_freehand_helper.cpp M +0-1libs/flake/KoDerivedResourceConverter.cpp M +0-1libs/flake/KoResourceManager_p.cpp M +0-1libs/ui/kis_derived_resources.cpp M +0-13 libs/ui/tool/kis_smoothing_options.cpp M +0-4libs/ui/tool/kis_smoothing_options.h M +0-8libs/ui/tool/kis_tool_freehand.cc M +0-3libs/ui/tool/kis_tool_freehand.h M +3-46 libs/ui/tool/kis_tool_freehand_helper.cpp M +0-4libs/ui/tool/kis_tool_freehand_helper.h M +154 -205 plugins/tools/basictools/kis_tool_brush.cc M +11 -36 plugins/tools/basictools/kis_tool_brush.h https://invent.kde.org/graphics/krita/commit/09d6693732e721f7b1f3c4c03da39ab7800b0dc1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451874] If Weighted/Stabilizer's Distance/Sample Count are set higher than 100, they will not be remembered and will be reset to 100
https://bugs.kde.org/show_bug.cgi?id=451874 Dmitry Kazakov changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/ce7db693e ||2c9cb1a1f10d07b8046e52abf74 ||0bd9 --- Comment #2 from Dmitry Kazakov --- Git commit ce7db693e2c9cb1a1f10d07b8046e52abf740bd9 by Dmitry Kazakov. Committed on 29/03/2022 at 04:50. Pushed by dkazakov into branch 'master'. Fix weighted distance value being clipped by 100 That was the order of initialization order problem: the range of the slider was initialized only after the value was set. M +5-2plugins/tools/basictools/kis_tool_brush.cc https://invent.kde.org/graphics/krita/commit/ce7db693e2c9cb1a1f10d07b8046e52abf740bd9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451874] If Weighted/Stabilizer's Distance/Sample Count are set higher than 100, they will not be remembered and will be reset to 100
https://bugs.kde.org/show_bug.cgi?id=451874 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/ce7db693e |hics/krita/commit/a532ed5eb |2c9cb1a1f10d07b8046e52abf74 |7fa3805ee1dace06cb7dea6fdac |0bd9|9d13 --- Comment #3 from Dmitry Kazakov --- Git commit a532ed5eb7fa3805ee1dace06cb7dea6fdac9d13 by Dmitry Kazakov. Committed on 29/03/2022 at 04:56. Pushed by dkazakov into branch 'krita/5.0'. Fix weighted distance value being clipped by 100 That was the order of initialization order problem: the range of the slider was initialized only after the value was set. M +5-2plugins/tools/basictools/kis_tool_brush.cc https://invent.kde.org/graphics/krita/commit/a532ed5eb7fa3805ee1dace06cb7dea6fdac9d13 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451980] Brush option Fade cannot be configured by dragging the slider (instead of clicking)
https://bugs.kde.org/show_bug.cgi?id=451980 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/9a2c4189b ||bf22f68c04ee84cfefb3e8f49c7 ||451a Status|ASSIGNED|RESOLVED --- Comment #2 from Dmitry Kazakov --- Git commit 9a2c4189bbf22f68c04ee84cfefb3e8f49c7451a by Dmitry Kazakov. Committed on 29/03/2022 at 07:37. Pushed by dkazakov into branch 'master'. Fix brush preview update after dragging Fade slider When updates while dragging are disabled, we still need to emit the update signal at the end of the drag operation. M +22 -0libs/ui/kis_aspect_ratio_locker.cpp M +1-0libs/ui/kis_aspect_ratio_locker.h M +6-0libs/widgetutils/kis_slider_spin_box.h M +1-0libs/widgetutils/kis_slider_spin_box_p.h https://invent.kde.org/graphics/krita/commit/9a2c4189bbf22f68c04ee84cfefb3e8f49c7451a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451903] UBSan hits on a signed integer left-shift in KisFixedPoint
https://bugs.kde.org/show_bug.cgi?id=451903 --- Comment #3 from Dmitry Kazakov --- Git commit e3d359608b9d6038b2428e8a49b833e7a5188ba4 by Dmitry Kazakov, on behalf of L. E. Segovia. Committed on 29/03/2022 at 10:55. Pushed by dkazakov into branch 'master'. Fix Clang+UBSan build This addresses a lot of build and runtime errors flagged by Clang 13 with the UBSan sanitizer enabled. M +0-2libs/brush/kis_brush.cpp M +3-1libs/image/brushengine/KisPaintOpPresetUpdateProxy.h M +1-1libs/image/brushengine/kis_locked_properties_proxy.h M +2-1libs/image/kis_gradient_shape_strategy.h M +1-2libs/image/kis_update_job_item.h M +1-1libs/ui/KisReferenceImagesDecoration.h M +1-1libs/ui/canvas/kis_update_info.h M +1-1libs/ui/widgets/kis_paintop_presets_editor.cpp M +1-1libs/ui/widgets/kis_paintop_presets_editor.h M +1-1libs/widgetutils/xmlgui/kactioncollection.cpp https://invent.kde.org/graphics/krita/commit/e3d359608b9d6038b2428e8a49b833e7a5188ba4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451903] UBSan hits on a signed integer left-shift in KisFixedPoint
https://bugs.kde.org/show_bug.cgi?id=451903
--- Comment #4 from Dmitry Kazakov ---
Hi, amyspark!
> No, this is already UB, so the best way would be to explicitly override UBsan
> in these two codepaths with __attribute__((no_sanitize("undefined")))
Can you make a patch for it? I don't really know where to put this attribute.
Into the function header? Or somewhere else? :)
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 451629] Greyscale Layers have incorrect peak white display.
https://bugs.kde.org/show_bug.cgi?id=451629 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED CC||dimul...@gmail.com Status|REPORTED|RESOLVED --- Comment #2 from Dmitry Kazakov --- Hi, Ahab! Thank you for the report! The bug was in the version of LCMS we used. I have updated it and started new builds today. So, tomorrow's nightly builds should have this bug fixed! :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451912] Crash when smart patch tool used in EXR HDR layer
https://bugs.kde.org/show_bug.cgi?id=451912 Dmitry Kazakov changed: What|Removed |Added Ever confirmed|0 |1 CC||dimul...@gmail.com Status|REPORTED|ASSIGNED --- Comment #1 from Dmitry Kazakov --- I can reproduce the issue -- You are receiving this mail because: You are watching all bug changes.
