KDE/kdelibs/kabc/plugins/dir
SVN commit 540668 by kuemmel:
change the output name of kabc_dir_plugin to kabc_directory
this naming is inconsistent in comparison to the other plugins:
kde4_add_library(kabc_dir) but the plugin name is kabc_directory
isn't kabc_dir better?
CCMAIL:kde-buildsystem@kde.org
M +1 -1 CMakeLists.txt
--- trunk/KDE/kdelibs/kabc/plugins/dir/CMakeLists.txt #540667:540668
@@ -28,7 +28,7 @@
kde4_install_libtool_file(${PLUGIN_INSTALL_DIR} kabc_dir_plugin )
-set_target_properties(kabc_dir_plugin PROPERTIES OUTPUT_NAME kabc_dir)
+set_target_properties(kabc_dir_plugin PROPERTIES OUTPUT_NAME kabc_directory )
install_targets(${PLUGIN_INSTALL_DIR} kabc_dir_plugin )
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
msvc: kabc plugins
in kabc/plugins are libraries and plugins with the same name when compiled with msvc. gcc uses different names because of the lib prefix, (library: libkabc_file plugin: kabc_file) but this does not work with msvc which never uses a prefix. So, what should I do to fix it? Renaming the non-plugin libraries or the plugin files? Do other apps outside of kdelibs link against the non-plugin libraries, or are they only used by the plugins kdelibs? Peter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
msvc: makekdewidgets
Something for the kdewin32 TODO list:
makekdewidgets throws an assert in win/src/mmap.c:
line 117:
hfd = (HANDLE)_get_osfhandle( fd );
When the mmap call is avoided then makekdewidgets
does not crash:
Index: kdecore/kconfigbackend.cpp
===
--- kdecore/kconfigbackend.cpp (Revision 540637)
+++ kdecore/kconfigbackend.cpp (Arbeitskopie)
@@ -445,7 +445,7 @@
unsigned int ll = localeString.length();
-#ifdef HAVE_MMAP
+#if defined(HAVE_MMAP) !defined(Q_CC_MSVC)
static volatile const char *map;
map = ( const char* ) mmap(0, rFile.size(), PROT_READ, MAP_PRIVATE,
rFile.handle(), 0);
@@ -699,7 +699,7 @@
if (fileOptionImmutable)
bFileImmutable = true;
-#ifdef HAVE_MMAP
+#if defined(HAVE_MMAP) !defined(Q_CC_MSVC)
if (map)
{
munmap(( char* )map, rFile.size());
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: msvc: makekdewidgets
Peter Kümmel schrieb: Something for the kdewin32 TODO list: makekdewidgets throws an assert in win/src/mmap.c: line 117: hfd = (HANDLE)_get_osfhandle( fd ); When the mmap call is avoided then makekdewidgets does not crash: I wonder how often I have to say this - you *can't* mix debug and relase libs as you do here. Because of this I stopped msvc compilation - the kdelibs need a debug prefix like the qt libs have. Christian signature.asc Description: OpenPGP digital signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: msvc: makekdewidgets
On Sunday 14 May 2006 18:02, Christian Ehrlicher wrote: Peter Kümmel schrieb: Something for the kdewin32 TODO list: makekdewidgets throws an assert in win/src/mmap.c: line 117: hfd = (HANDLE)_get_osfhandle( fd ); When the mmap call is avoided then makekdewidgets does not crash: I wonder how often I have to say this - you *can't* mix debug and relase libs as you do here. Because of this I stopped msvc compilation - the kdelibs need a debug prefix like the qt libs have. Ok, so what exactly is required ? if (MSVC) set(DEBUG_POSTFIX _debug) endif (MSVC) and then always only use debug versions of all kde libs in debug build mode ? Bye Alex -- Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de Home: neundorf AT kde.org- http://www.kde.org alex AT neundorf.net - http://www.neundorf.net ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: msvc: makekdewidgets
Alexander Neundorf schrieb: On Sunday 14 May 2006 18:02, Christian Ehrlicher wrote: Peter Kümmel schrieb: Something for the kdewin32 TODO list: makekdewidgets throws an assert in win/src/mmap.c: line 117: hfd = (HANDLE)_get_osfhandle( fd ); When the mmap call is avoided then makekdewidgets does not crash: I wonder how often I have to say this - you *can't* mix debug and relase libs as you do here. Because of this I stopped msvc compilation - the kdelibs need a debug prefix like the qt libs have. Ok, so what exactly is required ? if (MSVC) set(DEBUG_POSTFIX _debug) endif (MSVC) and then always only use debug versions of all kde libs in debug build mode ? Something in this way. You also have to make sure to use kdewin32*d*.dll instead kdewin32.dll Christian signature.asc Description: OpenPGP digital signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: msvc: makekdewidgets
Alexander Neundorf wrote: On Sunday 14 May 2006 18:02, Christian Ehrlicher wrote: Peter Kümmel schrieb: Something for the kdewin32 TODO list: makekdewidgets throws an assert in win/src/mmap.c: line 117: hfd = (HANDLE)_get_osfhandle( fd ); When the mmap call is avoided then makekdewidgets does not crash: I wonder how often I have to say this - you *can't* mix debug and relase libs as you do here. Because of this I stopped msvc compilation - the kdelibs need a debug prefix like the qt libs have. Ok, so what exactly is required ? if (MSVC) set(DEBUG_POSTFIX _debug) endif (MSVC) and then always only use debug versions of all kde libs in debug build mode ? Bye Alex kdelibs/win already generates and installs kdewin32d.lib by default due to the cmake line set(CMAKE_DEBUG_POSTFIX d) But the problem is that the rest of kdelibs links against the release dlls of Qt: *4.dll instead of d4.dll I don't know if the gnuwin32 libraries make problems. Peter ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: msvc: makekdewidgets
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Ehrlicher schrieb: Peter Kümmel schrieb: Something for the kdewin32 TODO list: makekdewidgets throws an assert in win/src/mmap.c: line 117: hfd = (HANDLE)_get_osfhandle( fd ); When the mmap call is avoided then makekdewidgets does not crash: I wonder how often I have to say this - you *can't* mix debug and relase libs as you do here. Because of this I stopped msvc compilation - the kdelibs need a debug prefix like the qt libs have. Does this relates also the single versus multi-threaded option like mentioned in http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore/html/_core_.2f.md.2c_2f.ml.2c_2f.mt.2c_2f.ld.asp ? Ralf -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEZ3gVoHh+5t8EXncRAi0oAKCdvrQUH82jzpEkqB6bcwxNDYSNMACcC33f 263LDWsDZu46xkukvVss16k= =f75k -END PGP SIGNATURE- ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: msvc: makekdewidgets
Alexander Neundorf wrote: On Sunday 14 May 2006 18:02, Christian Ehrlicher wrote: Peter Kümmel schrieb: Something for the kdewin32 TODO list: makekdewidgets throws an assert in win/src/mmap.c: line 117: hfd = (HANDLE)_get_osfhandle( fd ); When the mmap call is avoided then makekdewidgets does not crash: I wonder how often I have to say this - you *can't* mix debug and relase libs as you do here. Because of this I stopped msvc compilation - the kdelibs need a debug prefix like the qt libs have. Ok, so what exactly is required ? if (MSVC) set(DEBUG_POSTFIX _debug) endif (MSVC) and then always only use debug versions of all kde libs in debug build mode ? Bye Alex When I delete all release versions of Qt then cmake generates makefiles which only link against the debug versions, and the makekdewidget crash is gone. So I think it couldn't be very hard to add a switch to link for msvc only against the debug version-libs of Qt. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
