Poppler-qt4

2006-06-29 Thread Laurent Montel
Hi,
There is two cmake file which allows to search poppler-qt4:
One into kdegraphics/cmake/module/FindPopplerQt4.cmake
one into playground/graphics/cmake/modules/FindPoppler.cmake

I will want to move one into kdelibs (because it duplicates)

One which is into playground search poppler-qt4 = 0.5.2 so I will add it into 
kdelibs and I will want to rename it as FindPopplerQt4.cmake because it's a 
better name for it (and renamed variable to add qt4 suffix)

Can I make it ?

Regards
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Pino Toscano
Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
 There is two cmake file which allows to search poppler-qt4:
 One into kdegraphics/cmake/module/FindPopplerQt4.cmake
 one into playground/graphics/cmake/modules/FindPoppler.cmake

I am the author of the latter, and I planned to do that merge in case of a 
moving of okular to kdegraphics.

 I will want to move one into kdelibs (because it duplicates)

 One which is into playground search poppler-qt4 = 0.5.2 so I will add it
 into kdelibs and I will want to rename it as FindPopplerQt4.cmake because
 it's a better name for it (and renamed variable to add qt4 suffix)

 Can I make it ?

Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 
(yes, I have to update it) and this dependancy could raise if there will be 
new features needed for okular, while any other application that uses 
Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no 
particular requires on its version.
And if the minimum version for okular will be raised, should we keeping the 
kdelibs one updated?

Regards,

-- 
Pino Toscano


pgpJh2pZXXraF.pgp
Description: PGP signature
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Stefan Nikolaus
On Thursday 29 June 2006 13:57, Pino Toscano wrote:
 Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
  There is two cmake file which allows to search poppler-qt4:
  One into kdegraphics/cmake/module/FindPopplerQt4.cmake
  one into playground/graphics/cmake/modules/FindPoppler.cmake

 I am the author of the latter, and I planned to do that merge in case of a
 moving of okular to kdegraphics.

If Pino will merge oKular into kdegraphics, the FindPoppler[Qt4].cmake file is 
only used there, so I object to move it to kdelibs.
In general I don't think it makes much sense to merge cmake files of 
playground/ as the code there is experimental/not released.

Regards,
Stefan


pgpofBwpYTVUX.pgp
Description: PGP signature
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Laurent Montel
On Thursday 29 June 2006 14:16, Stefan Nikolaus wrote:
 On Thursday 29 June 2006 13:57, Pino Toscano wrote:
  Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
   There is two cmake file which allows to search poppler-qt4:
   One into kdegraphics/cmake/module/FindPopplerQt4.cmake
   one into playground/graphics/cmake/modules/FindPoppler.cmake
 
  I am the author of the latter, and I planned to do that merge in case of
  a moving of okular to kdegraphics.

 If Pino will merge oKular into kdegraphics, the FindPoppler[Qt4].cmake file
 is only used there, so I object to move it to kdelibs.

Normal to not move into kdelibs if it will merge into it.

 In general I don't think it makes much sense to merge cmake files of
 playground/ as the code there is experimental/not released.

It's cmake file :) not a lib.
I don't think that cmake file can be experimental (and difference between two 
cmake file is just search poppler version.

 Regards,
 Stefan
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread David Faure
On Thursday 29 June 2006 13:57, Pino Toscano wrote:
 Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
  There is two cmake file which allows to search poppler-qt4:
  One into kdegraphics/cmake/module/FindPopplerQt4.cmake
  one into playground/graphics/cmake/modules/FindPoppler.cmake
 
 I am the author of the latter, and I planned to do that merge in case of a 
 moving of okular to kdegraphics.
 
  I will want to move one into kdelibs (because it duplicates)
 
  One which is into playground search poppler-qt4 = 0.5.2 so I will add it
  into kdelibs and I will want to rename it as FindPopplerQt4.cmake because
  it's a better name for it (and renamed variable to add qt4 suffix)
 
  Can I make it ?
 
 Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 
 (yes, I have to update it) and this dependancy could raise if there will be 
 new features needed for okular, while any other application that uses 
 Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no 
 particular requires on its version.
 And if the minimum version for okular will be raised, should we keeping the 
 kdelibs one updated?

The version difference isn't a problem if it's passed via a variable to the 
FindPopplerQt4.cmake module,
much like what's done in FindQt4.cmake.
And since the kpdf filter in koffice will use poppler one day too, moving the 
check to kdelibs
makes sense to me.

-- 
David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Wilfried Huss
Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano:
 Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
  There is two cmake file which allows to search poppler-qt4:
  One into kdegraphics/cmake/module/FindPopplerQt4.cmake
  one into playground/graphics/cmake/modules/FindPoppler.cmake
 
 I am the author of the latter, and I planned to do that merge in case of a 
 moving of okular to kdegraphics.
 
  I will want to move one into kdelibs (because it duplicates)
 
  One which is into playground search poppler-qt4 = 0.5.2 so I will add it
  into kdelibs and I will want to rename it as FindPopplerQt4.cmake because
  it's a better name for it (and renamed variable to add qt4 suffix)
 
  Can I make it ?
 
 Actually, there's a small issue: okular stricly requires Poppler-Qt4 = 0.5.3 
 (yes, I have to update it) and this dependancy could raise if there will be 
 new features needed for okular, while any other application that uses 
 Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with no 
 particular requires on its version.

kviewshell also needs the latest cvs snapshot of poppler, but the version is
not checked in the cmake file in kdegraphics.

Greetings,
Wilfried Huss.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Albert Astals Cid
A Dijous 29 Juny 2006 17:45, Wilfried Huss va escriure:
 Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano:
  Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
   There is two cmake file which allows to search poppler-qt4:
   One into kdegraphics/cmake/module/FindPopplerQt4.cmake
   one into playground/graphics/cmake/modules/FindPoppler.cmake
 
  I am the author of the latter, and I planned to do that merge in case of
  a moving of okular to kdegraphics.
 
   I will want to move one into kdelibs (because it duplicates)
  
   One which is into playground search poppler-qt4 = 0.5.2 so I will add
   it into kdelibs and I will want to rename it as FindPopplerQt4.cmake
   because it's a better name for it (and renamed variable to add qt4
   suffix)
  
   Can I make it ?
 
  Actually, there's a small issue: okular stricly requires Poppler-Qt4 =
  0.5.3 (yes, I have to update it) and this dependancy could raise if there
  will be new features needed for okular, while any other application that
  uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with
  no particular requires on its version.

 kviewshell also needs the latest cvs snapshot of poppler, but the version
 is not checked in the cmake file in kdegraphics.

But the pdf kfile-plugin does not, it would not make sense disabling its 
compilation when you have poppler 0.5 for example. Can this be done with the 
cmake framework? And if it can, how?

Anyway i obviously agree duplication is bad.

Albert


 Greetings,
 Wilfried Huss.
 ___
 Kde-buildsystem mailing list
 Kde-buildsystem@kde.org
 https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Wilfried Huss
Am Donnerstag, 29. Juni 2006 19:38 schrieb Albert Astals Cid:
 A Dijous 29 Juny 2006 17:45, Wilfried Huss va escriure:
  Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano:
   Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
There is two cmake file which allows to search poppler-qt4:
One into kdegraphics/cmake/module/FindPopplerQt4.cmake
one into playground/graphics/cmake/modules/FindPoppler.cmake
  
   I am the author of the latter, and I planned to do that merge in case of
   a moving of okular to kdegraphics.
  
I will want to move one into kdelibs (because it duplicates)
   
One which is into playground search poppler-qt4 = 0.5.2 so I will add
it into kdelibs and I will want to rename it as FindPopplerQt4.cmake
because it's a better name for it (and renamed variable to add qt4
suffix)
   
Can I make it ?
  
   Actually, there's a small issue: okular stricly requires Poppler-Qt4 =
   0.5.3 (yes, I have to update it) and this dependancy could raise if there
   will be new features needed for okular, while any other application that
   uses Poppler-Qt4 (kfile-pdf, kviewshell, krita maybe?) just want it with
   no particular requires on its version.
 
  kviewshell also needs the latest cvs snapshot of poppler, but the version
  is not checked in the cmake file in kdegraphics.
 
 But the pdf kfile-plugin does not, it would not make sense disabling its 
 compilation when you have poppler 0.5 for example. Can this be done with the 
 cmake framework? And if it can, how?

I don't think that is really an issue. Until KDE4 is released there is most 
likely
a stable poppler 0.6 or even 0.8. And anyone that wants to install KDE4 will
need to have a very uptodate base system anyway.

 Anyway i obviously agree duplication is bad.

Well, the duplication that is happening with kviewshell and okular is much worse
than having the same cmake file in two places. But this is a different topic.

Greetings,
Wilfried Huss.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Albert Astals Cid
A Dijous 29 Juny 2006 20:23, Wilfried Huss va escriure:
 Am Donnerstag, 29. Juni 2006 19:38 schrieb Albert Astals Cid:
  A Dijous 29 Juny 2006 17:45, Wilfried Huss va escriure:
   Am Donnerstag, 29. Juni 2006 13:57 schrieb Pino Toscano:
Alle 13:41, giovedì 29 giugno 2006, Laurent Montel ha scritto:
 There is two cmake file which allows to search poppler-qt4:
 One into kdegraphics/cmake/module/FindPopplerQt4.cmake
 one into playground/graphics/cmake/modules/FindPoppler.cmake
   
I am the author of the latter, and I planned to do that merge in case
of a moving of okular to kdegraphics.
   
 I will want to move one into kdelibs (because it duplicates)

 One which is into playground search poppler-qt4 = 0.5.2 so I will
 add it into kdelibs and I will want to rename it as
 FindPopplerQt4.cmake because it's a better name for it (and renamed
 variable to add qt4 suffix)

 Can I make it ?
   
Actually, there's a small issue: okular stricly requires Poppler-Qt4
= 0.5.3 (yes, I have to update it) and this dependancy could raise
if there will be new features needed for okular, while any other
application that uses Poppler-Qt4 (kfile-pdf, kviewshell, krita
maybe?) just want it with no particular requires on its version.
  
   kviewshell also needs the latest cvs snapshot of poppler, but the
   version is not checked in the cmake file in kdegraphics.
 
  But the pdf kfile-plugin does not, it would not make sense disabling its
  compilation when you have poppler 0.5 for example. Can this be done with
  the cmake framework? And if it can, how?

 I don't think that is really an issue. Until KDE4 is released there is most
 likely a stable poppler 0.6 or even 0.8. And anyone that wants to install
 KDE4 will need to have a very uptodate base system anyway.

  Anyway i obviously agree duplication is bad.

 Well, the duplication that is happening with kviewshell and okular is much
 worse than having the same cmake file in two places. But this is a
 different topic.

Yeah i think i should inmediately stop coding okular (not that i do much 
really, Pino is the master at the moment), i might even write some mails to 
tell gnome dudes to stop doing gnome because we have KDE and freebsd, netbsd, 
openbsd hackers to stop because we already have linux so who wants to have 
another kernel, dude, probably i even will send a polite mail to yahoo CEO to 
tell them to shup up their business because Google is doing better than them 
in all aspects.

BTW this is not the right mailing list to discuss that.

Albert


 Greetings,
 Wilfried Huss.
 ___
 Kde-buildsystem mailing list
 Kde-buildsystem@kde.org
 https://mail.kde.org/mailman/listinfo/kde-buildsystem
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


find_package()

2006-06-29 Thread Allen Winter
What's the best cmake command to find an installed cmake module?
find_package() is used often in our CMakeLists.txt files, but I wonder
if there isn't something better.

For example:
The kdepimlibs package installs KDEPIMLib.cmake into 
$top/share/apps/cmake/modules

Near the top of kdepim/CMakeLists.txt I have the line find_package(KDEPIMLib 
REQUIRED).
If that file is not found, cmake prints the following and exits:
  CMake Error: KDEPIMLib_DIR is not set.  It must be set to the directory 
containing\
  KDEPIMLibConfig.cmake in order to use KDEPIMLib.

What I'd rather have is a cmake command that looks in a path for a file, and if 
that file
is not found a nice error message is printed (maybe something I can specify) and
then, based on the REQUIRED option, aborts cmake.

Does something like this already exist?

-- 
Let's Keep the Political Talk Out of KDE PLEASE
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Alexander Neundorf
On Thursday 29 June 2006 19:38, Albert Astals Cid wrote:
...
 But the pdf kfile-plugin does not, it would not make sense disabling its
 compilation when you have poppler 0.5 for example. Can this be done with
 the cmake framework? And if it can, how?

Yes. 
The cmake file can use e.g. CHECK_SYMBOL_EXISTS() or something like this to 
check whether some function exists in a given header.
The result can the be used from the outside.

find_package(PopplerQt4)

if (POPPLERQT4_HAVE_FANCY_NEW_FEATURE)
...
endif (POPPLERQT4_HAVE_FANCY_NEW_FEATURE)

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org- http://www.kde.org
  alex AT neundorf.net   - http://www.neundorf.net
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: find_package()

2006-06-29 Thread Allen Winter
On Thursday 29 June 2006 16:35, Alexander Neundorf wrote:
 On Thursday 29 June 2006 21:55, Allen Winter wrote:
  What's the best cmake command to find an installed cmake module?
  find_package() is used often in our CMakeLists.txt files, but I wonder
  if there isn't something better.
 
  For example:
  The kdepimlibs package installs KDEPIMLib.cmake into
  $top/share/apps/cmake/modules
 
  Near the top of kdepim/CMakeLists.txt I have the line
  find_package(KDEPIMLib REQUIRED). If that file is not found, cmake prints
  the following and exits:
CMake Error: KDEPIMLib_DIR is not set.  It must be set to the directory
  containing\ KDEPIMLibConfig.cmake in order to use KDEPIMLib.
 
  What I'd rather have is a cmake command that looks in a path for a file,
  and if that file is not found a nice error message is printed (maybe
  something I can specify) and then, based on the REQUIRED option, aborts
  cmake.
 
  Does something like this already exist?
 
 This is an issue which is not yet solved perfectly in cmake, the developers 
 are currently disussing a good solution.
 
 For kdepimlib:
 
 There should also be a
 find_package(KDE4)
 
It is there.

 Once this succeeded, the CMAKE_MODULE_PATH (where cmake searches for modules) 
 should be set so that $top/share/apps/cmake/modules/ is part of it.
 Then KDEPIMlib should be found automatically.
Well, it is found if it is installed.  The problem is when it isn't installed.
Like if someone is trying to build kdepim without installing kdepimlibs first.

 I'll have a closer look at it in the next days.
 
Thanks Alex.

-- 
Let's Keep the Political Talk Out of KDE PLEASE
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: Poppler-qt4

2006-06-29 Thread Pino Toscano
Alle 22:06, giovedì 29 giugno 2006, Wilfried Huss ha scritto:
 Besides, okular's fork of the DVI code has thrown away 9 years of commit
 history. This is also a problem. I thougt KDE switched to SVN so that such
 things would not happen again.

Now the files are really copied, and no history is lost. Luckly SVN is smart 
enough.

Regards,

-- 
Pino Toscano


pgpmv3141BNyR.pgp
Description: PGP signature
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Cmake Module questions

2006-06-29 Thread Tanner Lovelace
Greetings,

After a small hiatus and a new laptop, I'm again looking at KDE
on native mac and I had a few questions about several modules
in kdebase.  In trying to build kdebase under OS X, I had problems
with

runtime/kstart/
kpager/
nsplugins/

Looking at all three of these, they seemed to be pretty X11
centric.  Am I correct in assuming this and would it be appropriate
to therefore surround their add_subdirectory statments
in the CMakeLists.txt one level up with

if (Q_WS_X11)
endif (Q_WS_X11)

If so, I'll go ahead and check in my changes.

By not building those three directories, I was able to get
kdebase building on OS X and I got a few applications
running.  Here are some screenshots I took:

http://www.flickr.com/photos/clubjuggler/sets/72157594182079271/

Kate worked pretty well.  Konqueror worked ok, but
it was EXTREMELY slow and not everything was correct.
Konsole worked except that control characters didn't
work.  Konqueror also tried to bring up the kwallet setup
dialog a couple of times and for some reason it was
sized at twice my screen width!  and resisted me making
it smaller.  I canceled it once, but then tried to go through it
the second time it came up but neither the password fields
nor the Finish button at the end would come un-greyed.

Anyway, thanks in advance for any suggestions about
those directories in question.

Cheers,
Tanner Lovelace

-- 
Tanner Lovelace
clubjuggler at gmail dot com
http://wtl.wayfarer.org/
(fieldless) In fess two roundels in pale, a billet fesswise and an
increscent, all sable.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem